From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Ikjoon Jang <ikjn@chromium.org>,
devicetree@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Guenter Roeck <groeck@chromium.org>,
Benson Leung <bleung@chromium.org>,
linux-input@vger.kernel.org, Hsin-Yi Wang <hsinyi@chromium.org>,
Jiri Kosina <jikos@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec
Date: Fri, 14 May 2021 15:23:42 +0200 [thread overview]
Message-ID: <2a216922-c93b-0e1b-0dee-add6cdc9a3c9@collabora.com> (raw)
In-Reply-To: <20210514122051.266169-3-ikjn@chromium.org>
Hi Ikjoon,
Thank you for the patch.
On 14/5/21 14:20, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v7:
> - remove a label in cbas node
> - fix an erratum in commit message (table --> tablet)
> - dt-binding patchess merged altogether with mt8183 dts
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..1512605a438e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> compatible = "google,extcon-usbc-cros-ec";
> google,usb-port-id = <0>;
> };
> +
> + cbas {
> + compatible = "google,cros-cbas";
> + };
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-14 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 12:20 [RESEND PATCH v7 0/2] Add support cbas tablet mode switch to mt8183 Ikjoon Jang
2021-05-14 12:20 ` [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device Ikjoon Jang
2021-05-17 22:42 ` Stephen Boyd
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
2021-05-14 13:23 ` Enric Balletbo i Serra [this message]
2021-05-17 22:43 ` Stephen Boyd
2021-05-20 9:39 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a216922-c93b-0e1b-0dee-add6cdc9a3c9@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=hsinyi@chromium.org \
--cc=ikjn@chromium.org \
--cc=jikos@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).