From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/10] memory: tegra: Push suspend/resume into SoC drivers
Date: Thu, 22 Apr 2021 03:06:18 +0300 [thread overview]
Message-ID: <2a45a732-ff93-84f0-edf2-f9aa2e1504e6@gmail.com> (raw)
In-Reply-To: <20210420165237.3523732-4-thierry.reding@gmail.com>
20.04.2021 19:52, Thierry Reding пишет:
> -static int tegra_mc_suspend(struct device *dev)
> +static int __maybe_unused tegra_mc_suspend(struct device *dev)
> {
> struct tegra_mc *mc = dev_get_drvdata(dev);
> - int err;
>
> - if (IS_ENABLED(CONFIG_TEGRA_IOMMU_GART) && mc->gart) {
> - err = tegra_gart_suspend(mc->gart);
> - if (err)
> - return err;
> - }
> + if (mc->soc->ops && mc->soc->ops->suspend)
> + return mc->soc->ops->suspend(mc);
>
> return 0;
> }
>
> -static int tegra_mc_resume(struct device *dev)
> +static int __maybe_unused tegra_mc_resume(struct device *dev)
> {
> struct tegra_mc *mc = dev_get_drvdata(dev);
> - int err;
>
> - if (IS_ENABLED(CONFIG_TEGRA_IOMMU_GART) && mc->gart) {
> - err = tegra_gart_resume(mc->gart);
> - if (err)
> - return err;
> - }
> + if (mc->soc->ops && mc->soc->ops->resume)
> + return mc->soc->ops->resume(mc);
>
> return 0;
> }
You added __maybe_unused, but haven't changed tegra_mc_pm_ops to use
SET_SYSTEM_SLEEP_PM_OPS(), so the functions are always used.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-22 0:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 16:52 [PATCH 00/10] memory: tegra: Driver unification Thierry Reding
2021-04-20 16:52 ` [PATCH 02/10] memory: tegra: Unify struct tegra_mc across SoC generations Thierry Reding
2021-04-20 16:52 ` [PATCH 03/10] memory: tegra: Push suspend/resume into SoC drivers Thierry Reding
2021-04-22 0:06 ` Dmitry Osipenko [this message]
2021-04-26 8:47 ` Krzysztof Kozlowski
2021-04-26 12:24 ` Thierry Reding
2021-04-20 16:52 ` [PATCH 04/10] memory: tegra: Make per-SoC setup more generic Thierry Reding
2021-04-26 8:49 ` Krzysztof Kozlowski
2021-04-26 12:21 ` Thierry Reding
2021-04-20 16:52 ` [PATCH 05/10] memory: tegra: Extract setup code into callback Thierry Reding
2021-04-26 8:58 ` Krzysztof Kozlowski
2021-04-26 12:20 ` Thierry Reding
2021-04-20 16:52 ` [PATCH 06/10] memory: tegra: Parameterize interrupt handler Thierry Reding
2021-04-21 23:33 ` Dmitry Osipenko
2021-04-26 9:01 ` Krzysztof Kozlowski
2021-04-26 12:19 ` Thierry Reding
2021-04-20 16:52 ` [PATCH 07/10] memory: tegra: Only initialize reset controller if available Thierry Reding
2021-04-20 16:52 ` [PATCH 08/10] memory: tegra: Unify drivers Thierry Reding
2021-04-21 11:46 ` Dmitry Osipenko
2021-04-26 12:15 ` Thierry Reding
2021-04-20 16:52 ` [PATCH 09/10] memory: tegra: Add memory client IDs to tables Thierry Reding
2021-04-26 9:06 ` [PATCH 00/10] memory: tegra: Driver unification Krzysztof Kozlowski
2021-04-26 12:15 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a45a732-ff93-84f0-edf2-f9aa2e1504e6@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).