From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172C3C433E0 for ; Fri, 5 Jun 2020 09:08:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF2862074B for ; Fri, 5 Jun 2020 09:08:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Mp0YMdHF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF2862074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EMUsA4KC8m74TfvnKFsXAYnhQlcGHIVyTu2JyDbgwPQ=; b=Mp0YMdHFOy1OI3mxpuw3VkW/T 7xcgtDlKZcXpRPFXXePPIPcymR+NUR8btxBm49TTyOrxEcfLOzsGlkeWQtI7cifVaHeuLwWV+QTeW GuVMyxSpr2cKoVehFF785/7tIfZIhQIY7tOwOnN9/hWS8vnHLJzehbhr9gn7nnWQpK5T3vW9EIP6o qjA7UrFhgl7gbZYC/dL30sxf15Z1wI8QoZTOLrJtUkgU1AOJ4SCFOFA+xSxmeQzHQiHlURLpN4yk/ 1ErcC1Uvw2D9ElEDQHl/JkxTuWxCjixBt/xbAYWaYT+Lon8mlMWd765GCTarPhI+eysUWSk76AQD8 R6lkmZvIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh8LS-00025d-EA; Fri, 05 Jun 2020 09:08:58 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jh8LP-000247-Jn for linux-arm-kernel@lists.infradead.org; Fri, 05 Jun 2020 09:08:57 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E38BE8A2349040B75B79; Fri, 5 Jun 2020 17:08:48 +0800 (CST) Received: from [127.0.0.1] (10.166.215.204) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Fri, 5 Jun 2020 17:08:38 +0800 Subject: Re: [PATCH] ARM: imx6: add missing put_device() call in imx6q_suspend_init() To: Markus Elfring , , , References: From: "yukuai (C)" Message-ID: <2ab2cc9f-c720-75ca-e20c-0e4236ff45fd@huawei.com> Date: Fri, 5 Jun 2020 17:08:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.166.215.204] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_020855_809444_1412C8EF X-CRM114-Status: UNSURE ( 9.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anson Huang , Yi Zhang , Fabio Estevam , Sascha Hauer , kernel-janitors@vger.kernel.org, Russell King , LKML , Shawn Guo Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/6/5 3:07, Markus Elfring wrote: >> if of_find_device_by_node() succeed, imx6q_suspend_init() doesn't have a >> corresponding put_device(). Thus add a jump target to fix the exception >> handling for this function implementation. > > Do you find a previous update suggestion useful? > > ARM: imx6: Add missing put_device() call in imx6q_suspend_init() > https://lore.kernel.org/linux-arm-kernel/5acd7308-f6e1-4b1e-c744-bb2e5fdca1be@web.de/ > https://lore.kernel.org/patchwork/patch/1151158/ > https://lkml.org/lkml/2019/11/9/125 Hi, Markus It is useful indeed. Although I didn't run cocci script, since it can produce too many false result which is hard to filter out. BTW, I see you haver done the work already, I guess I won't send any patches related to 'missing put_device after of_find_device_by_node()'. Any idea why these pathes didn't get applied ? Best regards, Yu Kuai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel