From: Yannick FERTRE <yannick.fertre@st.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Philippe CORNU <philippe.cornu@st.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
Alexandre TORGUE <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Vincent ABRIOU <vincent.abriou@st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
LAKML <linux-arm-kernel@lists.infradead.org>,
Benjamin GAIGNARD <benjamin.gaignard@st.com>
Subject: Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume
Date: Fri, 21 Jun 2019 14:01:31 +0000 [thread overview]
Message-ID: <2c169739-febb-12a9-0fa1-d5da053ded67@st.com> (raw)
In-Reply-To: <CACvgo50vSNCTTTKp9D_07tazOE9YkU-zKAsDywvWe6h0NgcEmQ@mail.gmail.com>
Hi Emil,
The msm driver tests the return value & set state to NULL if no error is
detected.
the ltdc driver tests the return value & force to suspend if an error is
detected.
It's not exactly the same.
Best regards
--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division
On 6/20/19 7:12 PM, Emil Velikov wrote:
> Hi Yannick,
>
> On Mon, 17 Jun 2019 at 08:18, Yannick Fertré <yannick.fertre@st.com> wrote:
>
>> @@ -155,15 +154,17 @@ static __maybe_unused int drv_resume(struct device *dev)
>> struct ltdc_device *ldev = ddev->dev_private;
>> int ret;
>>
>> + if (WARN_ON(!ldev->suspend_state))
>> + return -ENOENT;
>> +
>> pm_runtime_force_resume(dev);
>> ret = drm_atomic_helper_resume(ddev, ldev->suspend_state);
>> - if (ret) {
>> + if (ret)
> Hmm the msm driver uses !ret here. Suspecting that you want the same,
> although I haven't checked in detail.
>
> HTH
> -Emil
--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-21 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 7:18 [PATCH 1/3] drm/stm: drv: fix suspend/resume Yannick Fertré
2019-06-18 9:57 ` Philippe CORNU
2019-06-20 15:05 ` Benjamin Gaignard
2019-06-20 17:12 ` Emil Velikov
2019-06-21 14:01 ` Yannick FERTRE [this message]
2019-06-21 14:53 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c169739-febb-12a9-0fa1-d5da053ded67@st.com \
--to=yannick.fertre@st.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.cornu@st.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).