From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61494C2B9F4 for ; Mon, 28 Jun 2021 11:01:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31A2561A2B for ; Mon, 28 Jun 2021 11:01:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31A2561A2B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ff3kgfRFwptxGVBmCNK+Ns9fjYXYTvzzB3Jf2k0bQPg=; b=K7NTVMeEpUQeBH98wpz+alW6F9 a4B69Xn7OujyOVyXif1QDqfyiQ4CqmxldRqXI2DLy2NuvP7E8GUsgD65SrmqsALlnyao2LkF6NsST Cjx66ABGrIyi6WyTe9dnkgrkmNgASL/8N4ib7Ewhyidka39BYgpFiupnYrV+yybYBOxp+Xqp+B+WW 8/9f1xcR3AfByju3YRD6FDyJDlyazoYMn2ooPIWDwifa7aBVLKR2l+DkL7uefIfTqoXGcJMrOLOBP 7Bkp9pewUIdkLdP1p/g1FoLEYkhB14faVQmLfltWnOsHC5+UKGMzzB1BTNxQ2ROlzLMH5GbEi+1pQ VBNcoRwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxozL-007hmZ-Qb; Mon, 28 Jun 2021 10:59:39 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxozH-007hlS-9c for linux-arm-kernel@lists.infradead.org; Mon, 28 Jun 2021 10:59:36 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F18FA82DA2; Mon, 28 Jun 2021 12:59:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1624877973; bh=/uSwIhUTGzgWud23+aNg1TbxMnbf4cZss/WEmETMEjk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=x/vH1wVtGgHw+yvzhphYwEHnlVO5UOyO9VVWdjw6WXS5MjtoaIjT5EZZcYgEIRod4 ynJMaTJHC4Gx3F5FJhvJSPTBK15iV9wiODNuoGRDjbAbnliz5inXIdwXgRU/eWciTF MLawKS6d+wtLoqTyouuSAiCsF9WrNxYjFMwU/aPQ25DSkNlufyl+LDSiz1V0+nLIJS //mkv8ZCZgZx/9WjF021RhUhAKYjOVYYTQ+r2tdzaCmlEGwhBsoJ4P2zEbiae4U5uJ FcYa+pdSUE47JCm4mZXKMXMK0mDTtjsxHW8Mi1P99BymubE1Hh+a1zgSynqj9nyeSk 5hVWfLoPBP2Bg== Subject: Re: [PATCH V7 4/4] soc: imx: Add blk-ctl driver for i.MX8MM To: Adam Ford , "Peng Fan (OSS)" Cc: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?UTF-8?Q?Guido_G=c3=bcnther?= , Andrey Smirnov , devicetree , arm-soc , Linux Kernel Mailing List , Jacky Bai , Schrempf Frieder , Abel Vesa , Peng Fan References: <20210612133134.2738-1-peng.fan@oss.nxp.com> <20210612133134.2738-5-peng.fan@oss.nxp.com> From: Marek Vasut Message-ID: <2c39672b-780a-8e33-038e-0856e32ede7a@denx.de> Date: Mon, 28 Jun 2021 12:59:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_035935_543272_3490B310 X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/14/21 8:07 PM, Adam Ford wrote: > On Sat, Jun 12, 2021 at 7:58 AM Peng Fan (OSS) wrote: >> >> From: Peng Fan >> >> The i.MX8MM SoC has dispmix BLK-CTL and vpumix BLK-CTL, so we add >> that support in this driver. >> >> Reviewed-by: Abel Vesa >> Signed-off-by: Peng Fan > > Maybe my TF-A is too old, but I am not able to wake the device from > suspend-to-ram with this series. I used the device tree from [1] to > enable both the GPCv2 and the blk-ctl stuff. > > [1] - https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210604111005.6804-1-peng.fan@oss.nxp.com/ > > I based both off Shawn's for-next branch. I also ran into issues with this, although it could also be related to GPCv2. On MX8MM , the system sometimes hangs when bringing up the GPCv2 power domain 6 (VPUMIX). It seems that the GPCv2 driver sets GPC_PU_PGC_SW_PUP_REQ register to 0x100 to bring up the VPUMIX and the bit never self-clears. After that, it seems the entire GPC locks up. Have you ever seen that kind of behavior ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel