From: Jeremy Linton <jeremy.linton@arm.com>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
sudeep.holla@arm.com, lenb@kernel.org
Subject: Re: [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag
Date: Tue, 18 Jun 2019 09:21:21 -0500 [thread overview]
Message-ID: <2d1b547f-f9ee-391c-c4f3-0232a08a86bc@arm.com> (raw)
In-Reply-To: <667f95c0-5aa9-f460-a49a-e6dfefc027d8@arm.com>
On 6/17/19 7:34 AM, Valentin Schneider wrote:
> Hi Jeremy,
>
> Few nits below.
>
> Also, I had a look at the other PPTT processor flags that were introduced
> in 6.3, and the only other one being used is ACPI_LEAF_NODE in
> acpi_pptt_leaf_node(). However that one already has a handle on the table
> header, so the check_acpi_cpu_flag() isn't of much help there.
>
> I don't believe the other existing flags will benefit from the helper since
> they are more about describing the PPTT tree, but I think it doesn't hurt
> to keep it around for potential future flags.
That was the thought process.
>
> On 14/06/2019 23:31, Jeremy Linton wrote:
> [...]
>> @@ -517,6 +517,43 @@ static int find_acpi_cpu_topology_tag(unsigned int cpu, int level, int flag)
>> return retval;
>> }
>>
>> +/**
>> + * check_acpi_cpu_flag() - Determine if CPU node has a flag set
>> + * @cpu: Kernel logical CPU number
>> + * @rev: The PPTT revision defining the flag
>> + * @flag: The flag itself
>> + *
>> + * Check the node representing a CPU for a given flag.
>> + *
>> + * Return: -ENOENT if the PPTT doesn't exist, the CPU cannot be found or
>> + * the table revision isn't new enough.
>> + * Otherwise returns flag value
>> + */
>
> Nit: strictly speaking we're not returning the flag value but its mask
> applied to the flags field. I don't think anyone will care about getting
> the actual flag value, but it should be made obvious in the doc:
Or I clarify the code to actually do what the comments says. Maybe that
is what John G was also pointing out too?
>
> -ENOENT if ...
> 0 if the flag isn't set
>> 0 if it is set.
>
> [...]
>> @@ -581,6 +618,21 @@ int cache_setup_acpi(unsigned int cpu)
>> return status;
>> }
>>
>> +/**
>> + * acpi_pptt_cpu_is_thread() - Determine if CPU is a thread
>> + * @cpu: Kernel logical CPU number
>> + *
>> + *
>
> Nit: extra newline
>
>> + * Return: 1, a thread
>> + * 0, not a thread
>> + * -ENOENT ,if the PPTT doesn't exist, the CPU cannot be found or
>> + * the table revision isn't new enough.
>> + */
>> +int acpi_pptt_cpu_is_thread(unsigned int cpu)
>> +{
>> + return check_acpi_cpu_flag(cpu, 2, ACPI_PPTT_ACPI_PROCESSOR_IS_THREAD);
>> +}
>> +
>> /**
>> * find_acpi_cpu_topology() - Determine a unique topology value for a given CPU
>> * @cpu: Kernel logical CPU number
>> @@ -641,7 +693,6 @@ int find_acpi_cpu_cache_topology(unsigned int cpu, int level)
> [...]
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 14:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 22:31 [PATCH v2 0/2] arm64/PPTT ACPI 6.3 thread flag support Jeremy Linton
2019-06-14 22:31 ` [PATCH v2 1/2] ACPI/PPTT: Add support for ACPI 6.3 thread flag Jeremy Linton
2019-06-17 12:34 ` Valentin Schneider
2019-06-18 14:21 ` Jeremy Linton [this message]
2019-06-18 14:40 ` Valentin Schneider
2019-06-18 17:23 ` John Garry
2019-06-18 21:28 ` Jeremy Linton
2019-06-19 9:15 ` John Garry
2019-06-28 15:21 ` Jeremy Linton
2019-06-25 15:20 ` Sudeep Holla
2019-06-14 22:31 ` [PATCH v2 2/2] arm64: topology: Use PPTT to determine if PE is a thread Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d1b547f-f9ee-391c-c4f3-0232a08a86bc@arm.com \
--to=jeremy.linton@arm.com \
--cc=catalin.marinas@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=valentin.schneider@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).