From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45BDAECAAA1 for ; Thu, 15 Sep 2022 11:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DezqG1uadYRwMbJACiaCzMs4kp8CWaWnP3ypnhG0lQg=; b=YqbPaMVFI902fT UYmp+NZZSyJVvoFh48XrHMxpZdGy6efakOpnUNGH3oGg2tMXOMLRfhXqMEgYLZlQt/ZAy8Q4Rpvaw TILC1MMcg3nVfXfqeq5rF9Vy5MYo3sF3XgPS8U22kmZ1BI3gZ1j8D/WQq9G30ppbmgZQXlWjneBeD pO0FqdjNJltOfVUD4A3xg2Ycu+tyy2xrCq3ttL9gi9gzsmG2iy4Okctqu8hO+rhGPb2b/QXiblAYE 7Jj6q7yIH5CNndjhpmGRjNeuQvbkrjZ/eKZZHgPop31s5k3kmyFapuFNW/yJXTUbdyGIiNHTO6hU8 S1TlgCy1w3RLdKLe/Bew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYnK3-007ysQ-Im; Thu, 15 Sep 2022 11:46:23 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYnJz-007yrq-EQ for linux-arm-kernel@lists.infradead.org; Thu, 15 Sep 2022 11:46:20 +0000 Received: by mail-lf1-x136.google.com with SMTP id w8so29914988lft.12 for ; Thu, 15 Sep 2022 04:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=DNXgwpqPIIuqzQRBdCOMAHQNDRiIqcoEBtZfHuZEnuI=; b=Caj3VE0KYQ63gm0H/qtyEmckga6j2I/I7D55jcaHYjmqyDSv+ubOmSFBm4UwYiZwEj l+G7XHskToz21DpzHhpcowet1X5s99fybCUYrYGqmvYSQajPjWNsyM35vgnQylf8WslF TFptD8xDF9wbNgffePeb4NucCk0csVT+6TDTQM3HtyyoEnnhQb9sJF7QLHbxcEOM0Cn1 Fxkr0iTDnGwtUnMREfoHSpNK0oXFYs8VGSbk6QtZGsXJLEvutY39a/HpQNwKYUxRW1Wg XzSxXM7/JI2VMbo61Ty688oRW5cx7Culg2iZuJtB52ntm7hRVMS6NL3XQo2OLAP6Pc1Y LwqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=DNXgwpqPIIuqzQRBdCOMAHQNDRiIqcoEBtZfHuZEnuI=; b=IDWU2XyAkXFOnsvlMgDX0zTq9dI5KKYP2dS+uAlmfyjWOTmxHo1iLUc6sa5MLrbmJx kLVkA7GAdi7AYXJxHDkI4acfHH2AQau1rsMjnR0aal1ieJYmJ/6mI/osZIRc3e4vJ0Fv nmJMpvrnfRpb4XRYfAjG3u13ngRxN4Kg+WvW97Hal67u7VRszEoBdjQrkY3xb7UiFE4o 9u+QT+0qpIEbZnV7G0ajyEtLrK4Z5n7dcbONwzIV/Ilm8ckVsbGlDVZYLMKaBdatM1v3 gRbDYXS2gnaKvq9iuOv3r5bECsNIqmEJTlrZdTBktCz056hiSa3XrqzzaV3JUdxv0h/2 qM/w== X-Gm-Message-State: ACgBeo2wXhZ70QZRPFhQjPHB93PpTKuEKPp/tWkrzUBVQAB+LxXCC6cL c1e036c0zlVnwEvjBCwrH8MEXQ== X-Google-Smtp-Source: AA6agR5IL9rhpZcQF9IYtFoiIZn0QLiK5ag2E6B4j9k5RGj66dITMVwJ1rApg5wOCUOIxxz9lCE/jA== X-Received: by 2002:ac2:4c50:0:b0:49a:3768:da81 with SMTP id o16-20020ac24c50000000b0049a3768da81mr6504701lfk.247.1663242374833; Thu, 15 Sep 2022 04:46:14 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id 7-20020a2e0907000000b00261e7e7b698sm3096292ljj.123.2022.09.15.04.46.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 04:46:14 -0700 (PDT) Message-ID: <2d24ed07-5501-5ee9-e2a9-34ef15216e28@linaro.org> Date: Thu, 15 Sep 2022 14:46:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 0/2] crypto: intel-fcs: Add crypto service driver for Intel SoCFPGA Content-Language: en-GB To: wen.ping.teh@intel.com Cc: bjorn.andersson@linaro.org, catalin.marinas@arm.com, davem@davemloft.net, dinguyen@kernel.org, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, shawnguo@kernel.org, will@kernel.org References: <20220914144137.605279-1-wen.ping.teh@intel.com> <20220915032506.641639-1-wen.ping.teh@intel.com> From: Dmitry Baryshkov In-Reply-To: <20220915032506.641639-1-wen.ping.teh@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220915_044619_509253_D487EAA4 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/09/2022 06:25, wen.ping.teh@intel.com wrote: > From: wen.ping.teh@intel.com > >> This patch introduces a crypto service driver for Intel SoCFPGA >> family. The FPGA Crypto Service (FCS) includes a large set of security >> features that are provided by the Secure Device Manager(SDM) in FPGA. >> The driver provide IOCTL interface for user to call the crypto services >> and send them to SDM's mailbox. >> >> Teh Wen Ping (2): >> crypto: intel-fcs: crypto service driver for Intel SoCFPGA family >> arm64: defconfig: add CRYPTO_DEV_INTEL_FCS > Hi, > > I just found out that there was a previous attempt to upstream this driver > 2 years ago. It was NACK because it did not implement crypto API. Please > drop this review. > https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg44701.html > > I will move this driver to drivers/misc. I think the proper solution would be to implement the existing API first rather than adding a set of custom proprietary IOCTLs that nobody else is going to use. -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel