From: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
To: Lucas Stach <l.stach@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Philippe Cornu <philippe.cornu@st.com>
Subject: Re: [PATCH v1 2/3] ARM: dts: stm32: enable Vivante GPU support on stm32mp157c-ed1 board
Date: Mon, 18 Mar 2019 10:21:24 +0100 [thread overview]
Message-ID: <2dcacbfb-2306-5147-b2d3-43be27319e5a@st.com> (raw)
In-Reply-To: <2cf49be6-474d-350b-8dfd-3fe1bf38af3a@st.com>
Hi Lucas,
I'm going to resend a new version on this DT. I have to move this region elsewhere.
However I didn't get your feedback about statement I did.
Would it be possible to have your feelings ?
Thanks :)
On 2/25/19 4:57 PM, Pierre Yves MORDRET wrote:
> Hi again,
>
> On 2/15/19 5:14 PM, Lucas Stach wrote:
>> Am Freitag, den 15.02.2019, 16:58 +0100 schrieb Pierre-Yves MORDRET:
>>> Enable Vivante GPU driver for stm32mp157c-ed1 board.
>>>
>>> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
>>> ---
>>> arch/arm/boot/dts/stm32mp157c-ed1.dts | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts
>>> b/arch/arm/boot/dts/stm32mp157c-ed1.dts
>>> index 98ef7a0..792f402 100644
>>> --- a/arch/arm/boot/dts/stm32mp157c-ed1.dts
>>> +++ b/arch/arm/boot/dts/stm32mp157c-ed1.dts
>>> @@ -20,6 +20,17 @@
>>> reg = <0xC0000000 0x40000000>;
>>> };
>>>
>>> + reserved-memory {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges;
>>> +
>>> + gpu_reserved: gpu@f8000000 {
>>> + reg = <0xf8000000 0x8000000>;
>>> + no-map;
>>> + };
>>> + };
>>> +
>>
>> I don't think you need this. The GPU driver uses very little contig dma
>> memory. Most of the GPU memory is ordinary paged memory, so setting
>> aside a private memory region of this size is a waste of memory. Most
>> likely you can just allow the GPU driver to use the system global CMA
>> region.
>
> That's correct, but this memory area is also used for U-BOOT splash screen
> rendering.
> Moreover, even if we lack of proof as for today, it turns out performances are
> better with this region as reduces MMU accesses (with Vivante driver)
> Eventually using Android framework application is started more gently whatever
> previous application and CMA status(fragmentation).
> Provided this memory, CMA region is decreased accordingly.
>
> Hope it clarifies.
>
> Regards
>>
>> Regards,
>> Lucas
>>
>>
>>> aliases {
>>> serial0 = &uart4;
>>> };
>>> @@ -53,6 +64,11 @@
>>> status = "okay";
>>> };
>>>
>>> +&gpu {
>>> + contiguous-area = <&gpu_reserved>;
>>> + status = "okay";
>>> +};
>>> +
>>> &i2c4 {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&i2c4_pins_a>;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-18 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 15:58 [PATCH v1 0/3] Add Vivante GPU support on STM32MP157c Pierre-Yves MORDRET
2019-02-15 15:58 ` [PATCH v1 1/3] ARM: dts: stm32: " Pierre-Yves MORDRET
2019-02-15 16:11 ` Lucas Stach
2019-02-25 15:48 ` Pierre Yves MORDRET
2019-02-15 15:58 ` [PATCH v1 2/3] ARM: dts: stm32: enable Vivante GPU support on stm32mp157c-ed1 board Pierre-Yves MORDRET
2019-02-15 16:14 ` Lucas Stach
2019-02-25 15:57 ` Pierre Yves MORDRET
2019-03-18 9:21 ` Pierre Yves MORDRET [this message]
2019-02-15 15:58 ` [PATCH v1 3/3] ARM: dts: stm32: enable Vivante GPU support on stm32mp157c-dk1 board Pierre-Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dcacbfb-2306-5147-b2d3-43be27319e5a@st.com \
--to=pierre-yves.mordret@st.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).