From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C44C43331 for ; Fri, 6 Sep 2019 15:18:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D91520650 for ; Fri, 6 Sep 2019 15:18:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ESPNdtga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D91520650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=obY/MBg1xqRgNNYVYuZjQddYng6XU2rraRwph+NKk0w=; b=ESPNdtgaZLTgqW o5xBRtIDWN4axIrpNe3DvrAwAxTmdqy2eOrFTwlUUhWRkWGOk6jn3d42lV0aJGgWIQyKBygL3G34R yXgH7YKe3hT9RSVUbb7MWYhbQtMYgN7VU4rcxzS3Z2JBqiT24MvApnPi/D1im5H07Fz9aEAgfATBE +i9va+Gvbm5iIkLNE4AN+d/WGEptdDOUKmi+l5tWHbbq9GdxBz0pQ9uAxQQmMZxEM/YvepnWoYuDh j5Ud7TbFKLUnsjniQXhuzBwFFttLs9fTsUjxGD7tPy2h2YezLErnv2hr9hRPvn9oTBlCr5J7j1qh3 IwGi1EVvWLCv835eKmtA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6G0I-0003LD-5I; Fri, 06 Sep 2019 15:18:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i6Fzb-0002gU-Jb; Fri, 06 Sep 2019 15:17:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 211D71576; Fri, 6 Sep 2019 08:17:43 -0700 (PDT) Received: from [10.1.196.105] (unknown [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C75063F59C; Fri, 6 Sep 2019 08:17:40 -0700 (PDT) From: James Morse Subject: Re: [PATCH v3 04/17] arm64, hibernate: rename dst to page in create_safe_exec_page To: Pavel Tatashin References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-5-pasha.tatashin@soleen.com> Message-ID: <2e826560-4005-fa16-8bbb-fc0e25763dcc@arm.com> Date: Fri, 6 Sep 2019 16:17:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190821183204.23576-5-pasha.tatashin@soleen.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_081743_805872_02176A62 X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sashal@kernel.org, mark.rutland@arm.com, vladimir.murzin@arm.com, corbet@lwn.net, marc.zyngier@arm.com, catalin.marinas@arm.com, bhsharma@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, jmorris@namei.org, linux-mm@kvack.org, ebiederm@xmission.com, matthias.bgg@gmail.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, On 21/08/2019 19:31, Pavel Tatashin wrote: > create_safe_exec_page() allocates a safe page and maps it at a > specific location, also this function returns the physical address > of newly allocated page. > > The destination VA, and PA are specified in arguments: dst_addr, > phys_dst_addr > > However, within the function it uses "dst" which has unsigned long > type, but is actually a pointers in the current virtual space. This > is confusing to read. The type? There are plenty of places in the kernel that an unsigned-long is actually a pointer. This isn't unusual. > Rename dst to more appropriate page (page that is created), and also > change its time to "void *" If you think its clearer, Reviewed-by: James Morse Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel