From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A95C433E0 for ; Fri, 10 Jul 2020 07:50:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0A2C206A5 for ; Fri, 10 Jul 2020 07:50:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jDinP+MA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UIwwVZez" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0A2C206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GN0tQNIZmZzsI9HgPHNyA0wgxKpAPe5slQRdg2BK29A=; b=jDinP+MATH7M6gSEfn9TaAJNf sNFdsqSB1G+OYzIVvKdISctU5V6yLKlIn3EPuxo1cVV/mP0cz+DYWOWx8+LuF0mv1AIlkO2BnAKTs BCq0H4KP411+ZI55gnxoQxSC/1yE67CFOImsJn2GbLohRKN9tExnRKsVDl0W6+7Ib5DQ/iz4Abcdb XuTs1MyW5QG2iSAvadOvHGX+bEjg7g6Tc3NsxR0NhruskOW4WCU2AOb89HbMBTBetYSmQ90EjDLoE z5cP5OgqhaeXbCU3vkjf29G9+GAEzXTtprCwgLWWlnva5FpwelkUKIDz3WMLSYsDRzOzVYol5iKDs waxyQB1Lw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtnlx-0003NB-Vo; Fri, 10 Jul 2020 07:48:42 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtnlv-0003Mi-Gk for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 07:48:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594367318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w3lPi8IIyg6JHok2MkrSRXRUKV+20Z+zeyOlBbulHrA=; b=UIwwVZezTDq6vUmce3Y1ef+Ehzm4G3VyUPnegLqxtIOw4MahNujDj9DYBiQ22AT1KosoRF whFbgfxVdWntveU+CGH47c3k7ucYNEYnp0AWblCtvNadzsmUVivZCaOe7p63ePL4M9GI9d yyiK71vwBliW02CQo2kSbPhg2o6llng= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-LK96D_5vMeqe9muglUBL-g-1; Fri, 10 Jul 2020 03:48:36 -0400 X-MC-Unique: LK96D_5vMeqe9muglUBL-g-1 Received: by mail-wm1-f70.google.com with SMTP id z11so5680071wmg.5 for ; Fri, 10 Jul 2020 00:48:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w3lPi8IIyg6JHok2MkrSRXRUKV+20Z+zeyOlBbulHrA=; b=MTzhf0OgKgvnZxFf3WcgWJmKzA1GnGpudVdSUmNEyCl9wpOg9K8b3dyKB0ayRmHF7w x7OSAFLsBTFzcQjnp57pNmfxWPxtgkGPA5W4NMDJp8ohI8HfqFnsvurifZusUl+5oy0O mW+UC2Tb2TIhn+Ydpfs9COt/A7pGL2dwkbbhLCtYz9trdxzD4KB7BT9eYm2xfD/43fI9 iurJ6vET39yFy2ugfeS1Tp+P6zI/uLsF/js5Fpz1Pjbq+eP9BgSzsvHs1jxPe2TxbGV1 q1Ks/8cLf0icfhSLVXeuqLCbjhGmWw5pPpUiI+KSnJTkw5SWKebOSDz0eU1DjQ0eYL4Z vLGA== X-Gm-Message-State: AOAM531FGbBZpuli9D4c3Gocz1DQ/ABIU3NrSvGwqUTCJ25n4mz43Mtv UvOSEH5WOMfYVR/Ln3RRvoXYvxwf5aDqO/g6OZ5mgMoyzB6cj/Al6QB5jYhTZ3XaHfYLr96eC8m 0SCkSvoYqLuGVUUe3q/qwjs34KiEmRUqi+kg= X-Received: by 2002:a7b:c952:: with SMTP id i18mr4118703wml.65.1594367315233; Fri, 10 Jul 2020 00:48:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoVcmgycalDG2NxxBpe/F1Ip5MhErG5G/6zxHhUH+uoCv6KdhugBz3NZfr470zRIHVmrw60A== X-Received: by 2002:a7b:c952:: with SMTP id i18mr4118689wml.65.1594367315031; Fri, 10 Jul 2020 00:48:35 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9541:9439:cb0f:89c? ([2001:b07:6468:f312:9541:9439:cb0f:89c]) by smtp.gmail.com with ESMTPSA id o9sm8786762wrs.1.2020.07.10.00.48.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 00:48:34 -0700 (PDT) Subject: Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters To: Christian Borntraeger , Tianjia Zhang , tsbogend@alpha.franken.de, paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com, chenhuacai@gmail.com References: <20200623131418.31473-1-tianjia.zhang@linux.alibaba.com> <20200623131418.31473-2-tianjia.zhang@linux.alibaba.com> From: Paolo Bonzini Message-ID: <2e986527-1585-e1b4-1251-ef36ac3bd233@redhat.com> Date: Fri, 10 Jul 2020 09:48:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_034839_613086_0C07AD93 X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/06/20 17:31, Christian Borntraeger wrote: > > I have trouble seeing value in this particular patch. We add LOCs > without providing any noticable benefit. All other patches in this series at > least reduce the amount of code. So I would defer this to Paolo if he prefers > to have this way across all architectures. Yes, it adds lines of code but they're just + struct kvm_run *kvm_run = vcpu->run; You could avoid the LoC increase by repeating vcpu->run over and over, but I think the code overall is clearer. Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel