From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E0C9ECAAD1 for ; Thu, 1 Sep 2022 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u4cdypk9KPrTJE2Lv+i+CkURfM8CDxRyW9QcmRyI/ic=; b=SK21AJ4TqStxUo rvd4RTRQpULhVOIg9TBYCw5ZRGZ4iMorjrtW5Mz2W6uKobH8YgahMINIKHc6pp/FQIpfAfd/6F+j9 JQWh5ZKiAHWB8+OcwPuSLCN7qF6Dm/ubo61dBCBi2xDg9ipdB40XehfNrhi70vP/rf1F8AkAsg7gO O4OZ2HLLpu1OIzZ+c8QFKXsnfkPUgdGPFaKdONmkPPXT4Ge1kzXq3b1FSqiho5H/F0u9KaVjONela wuTWJMCwv58oWZ/c1ZCZL/1KrZSy84JfSDglz5yDCRFgXmp9S5YAD/EzIkw/hNYMsuCBdh7gBIr+q DCsSpY2ZD0Qy3zXvBQOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTmOD-00CyRf-W4; Thu, 01 Sep 2022 15:45:58 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTmOB-00CyPu-8M for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 15:45:56 +0000 Received: by mail-lf1-x131.google.com with SMTP id z6so25021465lfu.9 for ; Thu, 01 Sep 2022 08:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=pwTnU1NRYqCTcCUVTKD8Na05COqOczxBt/998o6XYy4=; b=Q1Te17xgrcpyNuRzijNHlA+g+n1O1MNUqLEL/vTX0m1A0HewPL1WFOQVAPZ7KxPvu0 VI1WDz6IZXgDc11TKe3lV95r8U7UOh1WayI+oWovAa8zJIMr1Q5oTO8vry6qdMBpY97z WvLAFtYLvWEUhWMzxh003OIghREZ09oA/bKjg+spidGjdDkKnuQHBm6wx1ZJ6JDkVGhD 0nddj4YGs81ydICVPQwsMfUGI/Mbdw0Pp7v8t3d4cs4PHZPZXx8OVBQDY6kAw0qeWhqg ymGQ7VNYSfFYadAMeBd+d1KY9CytW5Yf3UeNXGxfpGY93CUiX/qIV/TgMA9QjiibvRuD dPrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=pwTnU1NRYqCTcCUVTKD8Na05COqOczxBt/998o6XYy4=; b=a3KszQYTbjl6OlodzdVnsuLxGMqRHGv9h/rl2Tw6O513CqnQYropm+yCeqQZYpmbGc MGn0tgKIVEcZo3osx+xBkDaQ9VpAEK20xn5F1ShFP56bDS9jlI9FFg/dDztOD/WHr9Wp c0/VvZ1KEnTGcZgw4NX8FwjYAZufQU8kv6/1Nm4HXfwfJx/M8KTauWrFCZ6Syl/Ibbdb 2mkZ3NPNjaa1PJAmWeVSRbR5VfhVCTmmKwx3ctSfv/jtYGiNpbDA45ZML6hK+P/xKZZ9 LC/MVKYVyJmMoo000ubsZmfvtV3lTzcolglsIi5XXbsaUGB9e1HY0n6yKLwdVQlu140J pjHg== X-Gm-Message-State: ACgBeo3mngQ10V5fu489JkaL+QOFbpoXmqYb8U69ygB9zTQyXokxI1rU K9/lvyobrGRHugfR3p9WvmokjA== X-Google-Smtp-Source: AA6agR4SF8JzyLedOeOJ13W6f/aUole8ekwKb8ZCgGMPhRfJWyZZpsmdH22j41No67YEX3YkvOnzUw== X-Received: by 2002:a05:6512:260d:b0:492:df5a:e4f9 with SMTP id bt13-20020a056512260d00b00492df5ae4f9mr10276035lfb.90.1662047153618; Thu, 01 Sep 2022 08:45:53 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id b1-20020a056512070100b004947fcf0c0bsm920400lfs.281.2022.09.01.08.45.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 08:45:53 -0700 (PDT) Message-ID: <2fedff34-6a20-f1ce-a756-2bd8671fcd52@linaro.org> Date: Thu, 1 Sep 2022 18:45:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/6] dt-bindings: mfd: add binding for Apple Mac System Management Controller Content-Language: en-US To: "Russell King (Oracle)" Cc: Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , Hector Martin , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org References: <426469c1-13cc-178b-4904-09439d7788e8@linaro.org> <928ddeff-efac-920c-7bbf-dda35a942b93@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_084555_339895_75F63FF6 X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/09/2022 18:24, Russell King (Oracle) wrote: > On Thu, Sep 01, 2022 at 06:15:46PM +0300, Krzysztof Kozlowski wrote: >> On 01/09/2022 18:12, Russell King (Oracle) wrote: >>>>> + compatible: >>>>> + items: >>>>> + - enum: >>>>> + - apple,t8103-smc >>>> >>>> You miss two spaces of indentation on this level. >>> >>> Should that be picked up by the dt checker? >> >> I think yamllint complains about it. It is not a hard-dependency, so >> maybe you don't have it installed. >> >>> >>>>> + - apple,t8112-smc >>>>> + - apple,t6000-smc >>>> >>>> Bring some order here - either alphabetical or by date of release (as in >>>> other Apple schemas). I think t6000 was before t8112, so it's none of >>>> that orders. >>> >>> Ok. >>> >>>>> + - const: apple,smc >>>>> + >>>>> + reg: >>>>> + description: Two regions, one for the SMC area and one for the SRAM area. >>>> >>>> You need constraints for size/order, so in this context list with >>>> described items. >>> >>> How do I do that? I tried maxItems/minItems set to 2, but the dt checker >>> objected to it. >> >> One way: >> reg: >> items: >> - description: SMC area >> - description: SRAM area >> >> but actually this is very similar what you wrote for reg-names - kind of >> obvious, so easier way: >> >> reg: >> maxItems: 2 > > Doesn't work. With maxItems: 2, the example fails, yet it correctly lists > two regs which are 64-bit address and 64-bit size - so in total 8 32-bit > ints. > > Documentation/devicetree/bindings/mfd/apple,smc.example.dtb: smc@23e400000: reg: [[2, 1044381696], [0, 16384], [2, 1071644672], [0, 1048576]] is too long > From schema: /home/rmk/git/linux-rmk/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > Hence, I originally had maxItems: 2, and ended up deleting it because of > the dt checker. > > With the two descriptions, it's the same failure. Yeah, they should create same result. > > I think the problem is that the checker has no knowledge in the example > of how big each address and size element of the reg property is. So, > it's interpreting it as four entries of 32-bit address,size pairs > instead of two entries of 64-bit address,size pairs. Yep, that's it, > if I increase the number of "- description" entries to four then it's > happy. > > So, what's the solution? > If you open generated DTS examples (in your kbuild-output/Documentation/devicetree/bindings/mfd/) you will see which address/size cells are expected. By default it is I think address/size cells=1, so you need a bus node setting it to 2. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel