From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47D96C433F5 for ; Fri, 18 Mar 2022 02:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VQqKw0SChX1A7efquBGBcBmUY4AKB7jIf6HMUJDvkTY=; b=Tep11liz6ggnFJ AL2tBFXZYc7cDwER6aSOLO6V7rtfcskUPbDBLS4OuDeBUDTNPEDjCBN7JO6J76P1Y8Zdizbez5NyO kZI/0fygogDSAHSZ+XdSEyXtGbeeojW7tIfC7Qa1ufLGyWrd0CyUfGFS+1y4mxj8q6ki/lTU07buj izHRYFOb3NAOn/YToJG3oCg1KnJaKvZ9/HqINfL96EQdfYc171rYr8xklyu0mHB98SuC5ZuixOFdm vmK4meTSd3qn9Y9FmMNY8KveyIksE2vlWizicz64ctKi/EXeBtIOLqpij2drqsNhitIPJnuz/N+bF 2wBXtF26+nHpB3lAGnjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV1xV-0009oC-PY; Fri, 18 Mar 2022 02:03:17 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV1xT-0009nW-0W; Fri, 18 Mar 2022 02:03:16 +0000 X-UUID: 1b1b3a15b8b14ba1a74585947c862e15-20220317 X-UUID: 1b1b3a15b8b14ba1a74585947c862e15-20220317 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2009058534; Thu, 17 Mar 2022 19:03:08 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Mar 2022 19:02:19 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Mar 2022 10:02:17 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 18 Mar 2022 10:02:16 +0800 Message-ID: <300c80f9c6217ce1b1ecee7f76043002dde530a3.camel@mediatek.com> Subject: Re: [PATCH v12 2/3] dts: arm64: mt8183: add Mediatek MDP3 nodes From: moudy.ho To: AngeloGioacchino Del Regno , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Hans Verkuil , Jernej Skrabec CC: Chun-Kuang Hu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , "Maoguang Meng" , daoyuan huang , Ping-Hsun Wu , , , , , , , , , Date: Fri, 18 Mar 2022 10:02:16 +0800 In-Reply-To: <7e898858-510a-dae6-2ef4-1cb8b1a42b21@collabora.com> References: <20220317145605.25782-1-moudy.ho@mediatek.com> <20220317145605.25782-3-moudy.ho@mediatek.com> <7e898858-510a-dae6-2ef4-1cb8b1a42b21@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_190315_069275_54569E59 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2022-03-17 at 16:26 +0100, AngeloGioacchino Del Regno wrote: > Il 17/03/22 15:56, Moudy Ho ha scritto: > > Add device nodes for Media Data Path 3 (MDP3) modules. > > > > Signed-off-by: Moudy Ho > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 108 > > ++++++++++++++++++++++- > > 1 file changed, 107 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index fc6ac2a46324..eaa6dac7768b 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -1389,6 +1389,79 @@ > > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX > > 0 0x1000>; > > }; > > > > + mdp3_rdma0: mdp3_rdma0@14001000 { > > Hello Moudy, > > I know, this is already at v12 and I'm truly sorry for noticing this > only now, > but that's a bit critical to solve: you can't use underscores in node > names (but > you can do it in phandles). > > Example: > > mdp3_rdma0: mdp3_rdma0@14001000 <-- THIS IS WRONG > > mdp3_rdma0: mdp3-rdma0@14001000 <--- THIS IS OK > > of course, that's the same also for mdp3-rsz0@..... and the others. > > Please fix this both here and in the yaml bindings in patch 1/3! > > Sorry again, > Angelo > Hi Angelo, Thanks for your help in checking and corresting the errors i haven't found, I'll fix the relevant dts and bindings in the next version. Thanks, Moudy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel