From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C21DC31681 for ; Mon, 21 Jan 2019 17:33:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D8582084A for ; Mon, 21 Jan 2019 17:33:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tQrPEjEC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D8582084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C3umuo0F7CrI/vCVg3RKZeD9yPbVBTAp8m4YLCkbUKU=; b=tQrPEjECB4O7AN uVjj2mIzf0nBrOOPUpybqTBzbAmWlOCw0iuEaBClqeDvHOFwmaO3k17BMID/VGmmWy4kuytTxfELP FPkbG1i68rbFcJROUopbauPtbjdU3jC5wdWw4Lz7YZSR5Q0M/VDxM4AlanIw5UbJ3ufWn3W5d5aln UFM9uj8KAiEv42e7JV7pNDM748COEc852jBscqMFEhM3wcVSaJcfIQuEGFcp/KA9DU2q6slqZAlq3 fdJ1S5a3RJl2IsdlwdFWo8FkJiGhJCILvncfSOuqdUHcw7scaomWMdzRoST8VTqmGxw2qtTSZNPbU VftgKqcF41MPRBtBKISA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gldS4-0002Bq-SP; Mon, 21 Jan 2019 17:33:36 +0000 Received: from mailoutvs23.siol.net ([185.57.226.214] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gldS0-0002BA-Sl for linux-arm-kernel@lists.infradead.org; Mon, 21 Jan 2019 17:33:35 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id DF67A52151C; Mon, 21 Jan 2019 18:33:22 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wQ8XIp_GdfcP; Mon, 21 Jan 2019 18:33:22 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 70AA8521512; Mon, 21 Jan 2019 18:33:22 +0100 (CET) Received: from jernej-laptop.localnet (cpe1-8-82.cable.triera.net [213.161.8.82]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPA id 2CB5C52150D; Mon, 21 Jan 2019 18:33:20 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai Subject: Re: [PATCH 1/3] media: dt: bindings: sunxi-ir: Add A64 compatible Date: Mon, 21 Jan 2019 18:33:19 +0100 Message-ID: <3128239.8RYQUhiYef@jernej-laptop> In-Reply-To: References: <20190111173015.12119-1-jernej.skrabec@siol.net> <20190121095014.b6iq5dubfi7x2pi4@flea> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190121_093333_252672_394BB3B3 X-CRM114-Status: GOOD ( 26.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Maxime Ripard , linux-kernel , linux-sunxi , Rob Herring , Mauro Carvalho Chehab , linux-arm-kernel , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 21. januar 2019 ob 10:57:57 CET je Chen-Yu Tsai napisal(a): > On Mon, Jan 21, 2019 at 5:50 PM Maxime Ripard wrote: > > Hi, > > > > I'm a bit late to the party, sorry for that. > > > > On Sat, Jan 12, 2019 at 09:56:11AM +0800, Chen-Yu Tsai wrote: > > > On Sat, Jan 12, 2019 at 1:30 AM Jernej Skrabec wrote: > > > > A64 IR is compatible with A13, so add A64 compatible with A13 as a > > > > fallback. > > > > > > We ask people to add the SoC-specific compatible as a contigency, > > > in case things turn out to be not so "compatible". > > > > > > To be consistent with all the other SoCs and other peripherals, > > > unless you already spotted a "compatible" difference in the > > > hardware, i.e. the hardware isn't completely the same, this > > > patch isn't needed. On the other hand, if you did, please mention > > > the differences in the commit log. > > > > Even if we don't spot things, since we have the stable DT now, if we > > ever had that compatible in the DT from day 1, it's much easier to > > deal with. > > > > I'd really like to have that pattern for all the IPs even if we didn't > > spot any issue, since we can't really say that the datasheet are > > complete, and one can always make a mistake and overlook something. > > > > I'm fine with this version, and can apply it as is if we all agree. > > I'm OK with having the fallback compatible. I'm just pointing out > that there are and will be a whole bunch of them, and we don't need > to document all of them unless we are actually doing something to > support them. If you don't document them, checkpatch will complain. But if you can live with this warning, that's fine by me. > > On the other hand, the compatible string situation for IR needs a > bit of cleaning up at the moment. Right now we have sun4i-a10 and > sun5i-a13. As Jernej pointed out, the A13's register definition is > different from A64 (or any other SoCs later than sun6i). So we need > someone with an A10s/A13 device that has IR to test it and see if > the driver or the manual is wrong, and we'd likely add a compatible > for the A20. > > Also, the earlier SoCs (A10/sun5i/A20) have IR TX capability. This > was lost in A31, and also all of sun8i / sun50i. So we're going to > need to add an A31 compatible that all later platforms would need > to switch to. > H6 has IR TX peripheral too, but it's different IP block... Do you want me to switch all A31 and newer to different compatible in this series? I can do this, but I haven't any A13 device to test if this is really needed. Or you can argue that this is needed anyway due to missing TX capability. BR, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel