From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D4BC433E2 for ; Wed, 9 Sep 2020 00:36:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0471B216C4 for ; Wed, 9 Sep 2020 00:36:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O6LdHEnM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sPXC7IsL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0471B216C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P+Kn7+tAgy0VD+velGzg2Ur2+14WpqWW4h4i/C0LBxc=; b=O6LdHEnMZS08XoLA+jPd0tQzY Lcqo+fBTvQQwZRO2C/OwNQoTyTzcfoyYv5RXreF8JGQcS5D3Np9e1njXt8UyewKuyLoKLMyJtxVsr JgucoOUG1H+VB3YVkO52qt5SQFNj1DRPIWgnu1LGTB2p970DszZbtj9NEZEgZGaz79f7ivJkVFu7w stKpXn8Je1JrXjlbYBg0NO8TkPyA/AoFLKZDf+uUE1uv+j3vLQAPzyU9LBg6NZlqlSECqWcKJvAyM lmR/18jG4ObpFYnxT9E4tHQfYhi+opLt+BDxzd26qqB/B9RFY9NQTL7/Q5NYELzdbY4m8YKI085Ol REmdTTSBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFo4i-0002lT-2b; Wed, 09 Sep 2020 00:35:00 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFo4f-0002l8-66 for linux-arm-kernel@lists.infradead.org; Wed, 09 Sep 2020 00:34:57 +0000 Received: by mail-pg1-x541.google.com with SMTP id t14so741984pgl.10 for ; Tue, 08 Sep 2020 17:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5uNeaE2Rby/fnh3O4xhlUXs/uwBS9UavtgyEhlwwdSg=; b=sPXC7IsLPz2deia5p0HcEvsDKR9Kr9crl7xYr/9eu5D8tyxWOUHPSEF22CnqKWsN9s y/fwUO6jW6b7YrclRXF1jvV8UKzwH0L30fJByTWmghdYjXTcc/ukXgxMDZo9rokArl4H L+0+iX7RI9bUg3cEDditunnR0787Sz0mQg3bHOJ8m1oUHKFnSsEx/9wvhDpCNNYy5Fu5 RDoBSoaYhWipgzCQ7A4L9e3hagfbmofsl1Tc2qJVQ5UIYewGO5XPEcQKiKID6HRUvRMY lTvounISuepcxoZqvoNsm/d7RQba7VJs3BiRoCC+8r0KbId1J1cU44g/uhv6T/7XNO10 NEUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5uNeaE2Rby/fnh3O4xhlUXs/uwBS9UavtgyEhlwwdSg=; b=B3wW6wbaJaDIsNtluBwqRV2pb3lH0jm6652g2YjyW3CWn3jMLKQcHgIpzrQPmWnCNI B4q6TwgiSyNbrzbJWutT9mA4LSRnZ5mCn+zlMRO+TobYxGkUFjnovo/Cid/esn6+qE5k OKmLzmguNTP11NHVLJ8dPQc8O/R+H/aZKvcZ9qfwkMCWS5wHMugTZOfZRjTCKliQj/ei 7sg4goToDGqyZvcOxSFVpdC3hWHj2uiatbHKsu6iwWGnhhLYP+RQcuJjH3htNh51yPp4 iAt8G3hcnHYM83y2yvGSbCwOq25xNm3N58TuY7sXJqKHS5C6Na8IEuF/gop9V2l19mEp uI2Q== X-Gm-Message-State: AOAM530Em2LBOshowChSte/w63TTVTwglkoSTeUK69pDcTo6tKmmTYJu aqNUxa8+NYbWKx1gJIIASoarPj1CvnPIpLYT X-Google-Smtp-Source: ABdhPJwyvCbykwwDH6n64RR0FkjJokMm2pR13sCHSy9QE0J+66OUiBwzezq0TSZTyrQvgYntDRBeng== X-Received: by 2002:a17:902:8a93:: with SMTP id p19mr1175793plo.101.1599611694678; Tue, 08 Sep 2020 17:34:54 -0700 (PDT) Received: from zen.local (174-21-64-208.tukw.qwest.net. [174.21.64.208]) by smtp.gmail.com with ESMTPSA id l12sm315018pjq.31.2020.09.08.17.34.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 17:34:54 -0700 (PDT) From: Trent Piepho To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/2] ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 Date: Tue, 08 Sep 2020 17:34:53 -0700 Message-ID: <3192458.miyTKKkx7g@zen.local> In-Reply-To: <20200701013320.130441-3-drew@beagleboard.org> References: <20200701013320.130441-1-drew@beagleboard.org> <20200701013320.130441-3-drew@beagleboard.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_203457_257412_964F3EF7 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Drew Fustini , Linus Walleij , linux-kernel@vger.kernel.org, Tony Lindgren , Rob Herring , Haojian Zhuang , Jason Kridner , linux-omap@vger.kernel.org, Robert Nelson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday, June 30, 2020 6:33:20 PM PDT Drew Fustini wrote: > Increase #pinctrl-cells to 2 so that mux and conf be kept separate. This > requires the AM33XX_PADCONF macro in omap.h to also be modified to keep pin > conf and pin mux values separate. > --- a/arch/arm/boot/dts/am33xx-l4.dtsi > +++ b/arch/arm/boot/dts/am33xx-l4.dtsi > @@ -278,7 +278,7 @@ scm: scm@0 { > am33xx_pinmux: pinmux@800 { > compatible = "pinctrl-single"; > reg = <0x800 0x238>; > - #pinctrl-cells = <1>; > + #pinctrl-cells = <2>; > #define AM33XX_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val) > -#define AM33XX_PADCONF(pa, dir, mux) OMAP_IOPAD_OFFSET((pa), 0x0800) ((dir) | (mux)) > +#define AM33XX_PADCONF(pa, conf, mux) OMAP_IOPAD_OFFSET((pa), 0x0800) (conf) (mux) If a dts file uses am33xx_pinmux from am33xx-l4.dtsi, but does not use the AM33XX_PADCONF() macro for all pin settings, like say it uses AM33XX_IOPAD(), then the dtb will be totally broken as pin addresses and values will all be off. Similarly, using AM33XX_PADCONF() with a different pinctrl defined elsewhere would also break. In the latest linux-next kernel, I found one case of the former problem, in am335x-guardian.dts. The barebox bootloader had all the am33xx boards broken when the dts change was imported without adding the OR-two-values special case to the pinctrl driver. Which I then tracked to here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel