From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52690C31E40 for ; Fri, 9 Aug 2019 10:56:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27BD121783 for ; Fri, 9 Aug 2019 10:56:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g8lrcgQh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27BD121783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/E2X3hMRXC8cmKNV7rJraw1jJ4JEguA3YHw5ynNL0E=; b=g8lrcgQhdM30ag Bnzhm2cOiFVQ4IVciKjOkaV+fSZsNNuDAU/JIAlhAjtkmsNLt3CQRh+j+ecymYrbzSpJLvTZh8e3A G2Fwx5LScH/mnsZpu9ny1iSqgwbEN9xSz9K/fjqlZ/tX+M69ggfc/9Gw/YOX5FxDdDNxvybT2AKK3 EZaZGjbcOYIf6QUstJzIiswkOD1eorjE6mbkzYqyotGZEuX1NpYT8/1aHAq44p/tzppd5vXMh+bXL JVTFr21hPBirpoO31mf8K1f6X7UEsBV/j56MXeg83g87yBDJZMpirgXJw4OadgoIw+l9c/Idu1MBg sw1RFpgPcWdj4ggOUdww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hw2ZP-0003Hp-Og; Fri, 09 Aug 2019 10:56:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hw2ZM-0003HT-Kr for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 10:56:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15F3B1596; Fri, 9 Aug 2019 03:56:24 -0700 (PDT) Received: from [10.1.197.61] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 60D033F575; Fri, 9 Aug 2019 03:56:22 -0700 (PDT) Subject: Re: [PATCH 06/19] irqchip/mmp: add missing chained_irq_{enter, exit}() To: Lubomir Rintel , Olof Johansson References: <20190809093158.7969-1-lkundrak@v3.sk> <20190809093158.7969-7-lkundrak@v3.sk> From: Marc Zyngier Organization: Approximate Message-ID: <319ebbbc-2231-42c9-faec-731ad81eb485@kernel.org> Date: Fri, 9 Aug 2019 11:56:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190809093158.7969-7-lkundrak@v3.sk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190809_035624_731871_050F7CCF X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , Stephen Boyd , linux-kernel@vger.kernel.org, Michael Turquette , Russell King , Kishon Vijay Abraham I , Rob Herring , Thomas Gleixner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/08/2019 10:31, Lubomir Rintel wrote: > The lack of chained_irq_exit() leaves the muxed interrupt masked on MMP3. > For reasons unknown this is not a problem on MMP2. > > Signed-off-by: Lubomir Rintel > --- > drivers/irqchip/irq-mmp.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mmp.c b/drivers/irqchip/irq-mmp.c > index af9cba4a51c2e..cd8d2253f56d1 100644 > --- a/drivers/irqchip/irq-mmp.c > +++ b/drivers/irqchip/irq-mmp.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -132,11 +133,14 @@ struct irq_chip icu_irq_chip = { > static void icu_mux_irq_demux(struct irq_desc *desc) > { > unsigned int irq = irq_desc_get_irq(desc); > + struct irq_chip *chip = irq_get_chip(irq); Consider using irq_desc_get_chip() instead, which avoids going through the irq->desc again. > struct irq_domain *domain; > struct icu_chip_data *data; > int i; > unsigned long mask, status, n; > > + chained_irq_enter(chip, desc); > + > for (i = 1; i < max_icu_nr; i++) { > if (irq == icu_data[i].cascade_irq) { > domain = icu_data[i].domain; > @@ -146,7 +150,7 @@ static void icu_mux_irq_demux(struct irq_desc *desc) > } > if (i >= max_icu_nr) { > pr_err("Spurious irq %d in MMP INTC\n", irq); > - return; > + goto out; > } > > mask = readl_relaxed(data->reg_mask); > @@ -158,6 +162,9 @@ static void icu_mux_irq_demux(struct irq_desc *desc) > generic_handle_irq(icu_data[i].virq_base + n); > } > } > + > +out: > + chained_irq_exit(chip, desc); > } > > static int mmp_irq_domain_map(struct irq_domain *d, unsigned int irq, > Otherwise looks OK. M. -- Jazz is not dead, it just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel