From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47628C48BDF for ; Tue, 15 Jun 2021 23:04:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9EBA61245 for ; Tue, 15 Jun 2021 23:04:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9EBA61245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l8UKzmA449c8zsDEjuIuFmtgZdkA7U8R/sW5bank5VY=; b=ydOqidCAQpv9ya jGU7+dOpRg16T2lALREDXLh5f4CSprg+pahAu2fZn7vDt7hUiE6AdKtbrNGo0gYmjPaoW5AvEJ3uV nArNLuJ13M3qRphTQx1vQBHYFPlK1S7qq4S9zWLJuJhUMlKkbjz+p3SnmzYYkaB+kqGZuElVx3lhb phdYNfVQ/l0o9JWm3tEUynKTXTYOgD/CrMLCwHw23s3ZTtPaSAaVSGP28NAkr2nehMKjE3sZCoY/4 y+JlRMmpuLw/GVu1Bm2pTtj+7eLyuvaQyuRDwmROi78eu9nqvhGORh2q3r2+kJmPRTELq74wunq+C bI2j+KmuaYOkd+urNUFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltI4E-003kO5-Ew; Tue, 15 Jun 2021 23:01:59 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltGvo-003JIc-SI; Tue, 15 Jun 2021 21:49:14 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltGvk-0002Ci-Or; Tue, 15 Jun 2021 23:49:08 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring Cc: Bjorn Helgaas , Punit Agrawal , "open list:ARM/Rockchip SoC..." , linux-arm-kernel , "linux-kernel@vger.kernel.org" , PCI , Alexandru Elisei , wqu@suse.com, Robin Murphy , Peter Geis , Ard Biesheuvel , Brian Norris , Shawn Lin Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: Update PCI host bridge window to 32-bit address memory Date: Tue, 15 Jun 2021 23:49:07 +0200 Message-ID: <3238453.R1toDxpfAE@diego> In-Reply-To: References: <20210607112856.3499682-1-punitagrawal@gmail.com> <3105233.izSxrag8PF@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_144912_977620_170BCE3C X-CRM114-Status: GOOD ( 22.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 15. Juni 2021, 23:29:12 CEST schrieb Rob Herring: > On Thu, Jun 10, 2021 at 3:50 PM Heiko St=FCbner wrote: > > > > Hi, > > > > Am Montag, 7. Juni 2021, 13:28:56 CEST schrieb Punit Agrawal: > > > The PCIe host bridge on RK3399 advertises a single 64-bit memory > > > address range even though it lies entirely below 4GB. > > > > > > Previously the OF PCI range parser treated 64-bit ranges more > > > leniently (i.e., as 32-bit), but since commit 9d57e61bf723 ("of/pci: > > > Add IORESOURCE_MEM_64 to resource flags for 64-bit memory addresses") > > > the code takes a stricter view and treats the ranges as advertised in > > > the device tree (i.e, as 64-bit). > > > > > > The change in behaviour causes failure when allocating bus addresses > > > to devices connected behind a PCI-to-PCI bridge that require > > > non-prefetchable memory ranges. The allocation failure was observed > > > for certain Samsung NVMe drives connected to RockPro64 boards. > > > > > > Update the host bridge window attributes to treat it as 32-bit address > > > memory. This fixes the allocation failure observed since commit > > > 9d57e61bf723. > > > > > > Reported-by: Alexandru Elisei > > > Link: https://lore.kernel.org/r/7a1e2ebc-f7d8-8431-d844-41a9c36a8911@= arm.com > > > Suggested-by: Robin Murphy > > > Signed-off-by: Punit Agrawal > > > Tested-by: Alexandru Elisei > > > Cc: Heiko Stuebner > > > Cc: Rob Herring > > > > just for clarity, should I just pick this patch separately for 5.13-rc = to > > make it easy for people using current kernel devicetrees, or should > > this wait for the update mentioned in the cover-letter response > > and should go all together through the PCI tree? > = > This was dropped from v4, but should still be applied IMO. It was probably dropped because I applied it ;-) It's part of armsoc already [0] and should make its way into 5.13 shortly. Heiko [0] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?h= =3Darm/fixes&id=3D8efe01b4386ab38a36b99cfdc1dc02c38a8898c3 > = > Acked-by: Rob Herring > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel