From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09AAC433DB for ; Fri, 29 Jan 2021 13:35:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E4D764DA1 for ; Fri, 29 Jan 2021 13:35:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E4D764DA1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bThE7iZFzTCROSr56n3UIdIqZlaMccmvalxO0g8ZDIg=; b=zDbm/YLto+E6p0v3JygWYlZ4F /xQtd6NLKnq97FRVZSfhV0nrbwlp0cBjvvbN4AZTcAbBqbaGZ1CpKYCdTzobNPF6UNHwfLiKlASsH BooLLGdqB5IZf/6xIrB4H5GCljm/WDaZ+F/l0oY+LGo4qzQVEP0Nhm9GCIvpvnt1UlBVDvq9FFJep 1ajkxIMC/vBrTHT41Tal/pCeLz/bCN97mfVswiz+kIoETQGZvfLw4jYNyzwgbWQvU7IdZrQ7xVvts XIIAH9/s15R1XtmrLsg0sKe2/NosgiAHGbc4RVNGfQtUVReUMBlImiI8stOh0XloW47/1bgDSNrod 85zuiGskg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5TuW-0001vi-Bf; Fri, 29 Jan 2021 13:34:04 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5TuT-0001uw-N3 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 13:34:02 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DRyvJ2TWRzjG2P; Fri, 29 Jan 2021 21:32:44 +0800 (CST) Received: from [127.0.0.1] (10.174.176.220) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Fri, 29 Jan 2021 21:33:52 +0800 Subject: Re: [PATCH v5 4/4] ARM: Add support for Hisilicon Kunpeng L3 cache controller To: Russell King - ARM Linux admin References: <20210116032740.873-1-thunder.leizhen@huawei.com> <20210116032740.873-5-thunder.leizhen@huawei.com> <20dac713-25b7-cddf-cc42-69a834487c71@huawei.com> <20210129101242.GV1551@shell.armlinux.org.uk> From: "Leizhen (ThunderTown)" Message-ID: <3264f57e-37b4-86c9-5cfc-3e42b717ff86@huawei.com> Date: Fri, 29 Jan 2021 21:33:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210129101242.GV1551@shell.armlinux.org.uk> Content-Language: en-US X-Originating-IP: [10.174.176.220] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_083402_007102_D86A00BB X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Arnd Bergmann , devicetree , Greg Kroah-Hartman , Will Deacon , linux-kernel , Haojian Zhuang , Rob Herring , Wei Xu , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/1/29 18:12, Russell King - ARM Linux admin wrote: > On Fri, Jan 29, 2021 at 03:23:27PM +0800, Leizhen (ThunderTown) wrote: >> On 2021/1/28 22:24, Arnd Bergmann wrote: >>> I see that cache-l2x0 uses raw_spin_lock_irqsave() instead of >>> spin_lock_irqsave(), to avoid preemption in the middle of a cache >>> operation. This is probably a good idea here as well. >> >> I don't think there's any essential difference between the two! I don't know >> if the compiler or tool will do anything extra. I checked the git log of the >> l2x0 driver and it used raw_spin_lock_irqsave() at the beginning. Maybe >> there's a description in 2.6. Since you mentioned this potential risk, I'll >> change it to raw_spin_lock_irqsave. > > See bd31b85960a7 ("locking, ARM: Annotate low level hw locks as raw") OK, thanks. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel