From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC09C2B9F8 for ; Tue, 25 May 2021 12:06:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7EB06100B for ; Tue, 25 May 2021 12:06:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7EB06100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=nUVStk6JxhWvXpOMDPqSfyeoRqfrQJiS7k8LaWY2Y2w=; b=be8Ub4QIbau/eOO5rmOzgADmZX d9lPK/iuWTGbNvhnSVAWAC3CT+EcdHSXlleH/Zu2R003TJySksNfwl+ToLlcQv2d4aqTVbntFArI4 Pj+gfP7Vbhyl/rE9KXign4+lfMOnpA5mKxXpG4pmsr2+d342tK/g1anW4uDWppNP4IZLoH/ZgNwB8 6d0b6MRCwcNlvGfWnt0tjKC9E7QQt7jdzBCKYBau4NJrC1fr9eImjj2AxZDBCZ6bTMiLAxPnjcz29 58p8Nz1Tw5EpgSEWXrSpoieuhXaDBMwhfp3lkR5uBRjeWWRD8SPy1eSgfXJ/yBam90uWEDAdu31xH P+IYPzYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llVn3-004tnJ-Uv; Tue, 25 May 2021 12:04:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llVmz-004tlt-W1 for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 12:04:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3117CD6E; Tue, 25 May 2021 05:03:58 -0700 (PDT) Received: from [10.57.0.178] (unknown [10.57.0.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 317913F719; Tue, 25 May 2021 05:03:55 -0700 (PDT) Subject: Re: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for "full_auxtrace" To: Leo Yan , Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Al Grant , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210519041546.1574961-1-leo.yan@linaro.org> <20210519041546.1574961-5-leo.yan@linaro.org> From: James Clark Message-ID: <326bfc02-e02d-997b-2f7f-1c0565f4d5cc@arm.com> Date: Tue, 25 May 2021 15:03:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210519041546.1574961-5-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_050402_112881_E481FAD8 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/05/2021 07:15, Leo Yan wrote: > The option "opts->full_auxtrace" is checked at the earlier place, if it > is false the function will directly bail out. So remove the redundant > checking for "opts->full_auxtrace". > > Suggested-by: James Clark > Signed-off-by: Leo Yan > --- > tools/perf/arch/arm64/util/arm-spe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c > index bacdf366040d..a4420d4df503 100644 > --- a/tools/perf/arch/arm64/util/arm-spe.c > +++ b/tools/perf/arch/arm64/util/arm-spe.c > @@ -116,7 +116,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > return 0; > > /* We are in full trace mode but '-m,xyz' wasn't specified */ > - if (opts->full_auxtrace && !opts->auxtrace_mmap_pages) { > + if (!opts->auxtrace_mmap_pages) { > if (privileged) { > opts->auxtrace_mmap_pages = MiB(4) / page_size; > } else { > Reviewed-by: James Clark Thanks James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel