linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
	robh@kernel.org,  shawnguo@kernel.org, festevam@gmail.com,
	catalin.marinas@arm.com, will@kernel.org,
	 georgi.djakov@linaro.org, cdleonard@gmail.com
Cc: devicetree@vger.kernel.org, kernel@puri.sm,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] arm64: dts: imx8mq: Add interconnect for lcdif
Date: Tue, 01 Dec 2020 12:27:08 +0100	[thread overview]
Message-ID: <34146e8424bf9fdf5865fc954ee9964612ab88dc.camel@pengutronix.de> (raw)
In-Reply-To: <20201201100124.4676-4-martin.kepplinger@puri.sm>

Am Dienstag, den 01.12.2020, 11:01 +0100 schrieb Martin Kepplinger:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 244e28e54b35..7384a69ed36c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>  #include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>  #include "imx8mq-pinfunc.h"
>  
> 
> 
> 
>  / {
> @@ -522,6 +523,8 @@
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "lcdif-dram";

This needs to be documented in the binding. Also I would argue that you
can drop the lcdif prefix in the name, as it's part of the lcdif DT
node.

Regards,
Lucas

>  				status = "disabled";
>  
> 
> 
> 
>  				port@0 {



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-01 11:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 10:01 [PATCH 0/6] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-01 10:01 ` [PATCH 1/6] arm64: dts: imx8m: Add NOC nodes Martin Kepplinger
2020-12-01 10:01 ` [PATCH 2/6] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-01 10:01 ` [PATCH 3/6] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-01 11:27   ` Lucas Stach [this message]
2020-12-01 10:01 ` [PATCH 4/6] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-01 10:01 ` [PATCH 5/6] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-01 11:29   ` Lucas Stach
2020-12-01 10:01 ` [PATCH 6/6] arm64: defconfig: updates for 5.10 Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34146e8424bf9fdf5865fc954ee9964612ab88dc.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=catalin.marinas@arm.com \
    --cc=cdleonard@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=georgi.djakov@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).