From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7777EECE588 for ; Wed, 16 Oct 2019 09:00:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DB0421A49 for ; Wed, 16 Oct 2019 09:00:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Oheg5zd3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="UDSYSJtE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DB0421A49 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bhbANFVKjiTcTDnrxCC9gQsx4sP0SqIWnXCa4Tjm17g=; b=Oheg5zd3mx1USn FZEZwOwBhgWu4s6T0UKVxZcEJhag/RnkW1JXkwy7knynRF715dbWHOfXOtnCaJBZd5CA5qx2GFRbL LGMAaJDhWqana9qL7zNl1FoiR/qSP7ycQ+PQaYiQtgI2paoggsJNscJA1QRzCD8akoZyvnlM2du1x Uo9ILjut43rMGWghNpkhQeR4YkJcV1WRrSzQf7lvcTzHbej6DzeFYnLqsDeQDGe+rgMVgg1K23pCH qU86inTcPPyO/R+zU/Ib5kSzdt6hYcyADV75KryfSAaWOpgMDgCANw5VdVm5NcVw/BNv7X9IwzRQp ZPUavMeBGo+uEK7kiVGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKfAM-0000he-Mt; Wed, 16 Oct 2019 09:00:22 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKfAI-0000Vc-Gn for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 09:00:20 +0000 Received: by mail-wr1-x444.google.com with SMTP id v8so27080156wrt.2 for ; Wed, 16 Oct 2019 02:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=FWwSZ7wVHB66iuc6hwPySPcSnpuZXmN+p1/bCDDEZAo=; b=UDSYSJtEKugyDuq3KMpdtgOOFzhbwAnFU4ZHVk/+xe+ABJ96+ug84qKCiMiV2jqyQa Njv7sRzHFCpauHdKZFWwRP0m+5MVLn4AhaVYieFt49Ho2dYnBY0vn7k5Ug+Nl/Ghq+o6 nveOswF2JtJ4xceyVyyooCOCmvd8HTws5+h5VU6uUQThGLvMa+oqwNKyS+7Twodw3CjA 48R3xyCTlsZ47z46SHSH/GQ8WYVK6Xlejnmg/w+peYethFa0qHtGR+77fN48BWDtdUO0 srnSh4tnrIuhDEiNUJc01vM7ctZtyAV1kuVzeIJ37ajYYxFRR/T1MHZm8DsbfAfdWTrX 9SfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=FWwSZ7wVHB66iuc6hwPySPcSnpuZXmN+p1/bCDDEZAo=; b=OaWViHwcagUlURjmT41m5Ld+upJW9yWQjLzpKoSbEzvv10SvIDfrNAFIe6VSN4ZiD3 J6BWGlDEUq4mp9jCMtP+OWuO3YPvw/DuQIO6vKHDBGehgVGRsxe+OoOKeish7nHycoGz 9qnoOF3/EXA3Y5OPcfCizLd2E0Msj/QpvAW86HhUeP+cLL9DK7JUb9kEjaj5kYrOdhB0 KeDTCpH+ZuZt5vmaVGmWAVoU97bgfXgZ7bhGVgT/eiFrMfwfMdGMyDwUxVyNVcecxK+N 9XijnluDIPdrhM9ofSVzTOme0SXaSCCDHGKDgZUaue/8fcY6UFDXESyb0O3JCKwQW4RC z3zg== X-Gm-Message-State: APjAAAUdj7xkg1px7TdUBOrXfr4ZPvNs7VqU3xAvaADi1rwCz7psVAYI UggV70ZAc9FVZ0KPd7B4k+qjJw== X-Google-Smtp-Source: APXvYqy8jmTWK22einYBZkkJUT3gZQaCWv3cRPLnG6y72qAhJWTSUhHTPba7TgOkJn0GB6oggXGTqA== X-Received: by 2002:a05:6000:11cd:: with SMTP id i13mr1616456wrx.197.1571216414621; Wed, 16 Oct 2019 02:00:14 -0700 (PDT) Received: from [10.1.4.98] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id p85sm2026845wme.23.2019.10.16.02.00.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Oct 2019 02:00:13 -0700 (PDT) Subject: Re: [PATCH v7 4/7] arm64: dts: meson: g12: Add minimal thermal zone To: Amit Kucheria References: <20191004090114.30694-1-glaroque@baylibre.com> <20191004090114.30694-5-glaroque@baylibre.com> From: guillaume La Roque Message-ID: <347c0fe0-62de-8ef5-c1ca-8958fef81820@baylibre.com> Date: Wed, 16 Oct 2019 11:00:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_020018_568306_03E71166 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux PM list , Daniel Lezcano , LKML , Eduardo Valentin , linux-amlogic@lists.infradead.org, Zhang Rui , lakml Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 10/16/19 1:20 AM, Amit Kucheria wrote: > On Fri, Oct 4, 2019 at 2:31 PM Guillaume La Roque wrote: >> Add minimal thermal zone for two temperature sensor >> One is located close to the DDR and the other one is >> located close to the PLLs (between the CPU and GPU) >> >> Acked-by: Martin Blumenstingl >> Reviewed-by: Neil Armstrong >> Tested-by: Christian Hewitt >> Tested-by: Kevin Hilman >> Signed-off-by: Guillaume La Roque >> --- >> .../boot/dts/amlogic/meson-g12-common.dtsi | 57 +++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> index 0660d9ef6a86..a98c16e163c2 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi >> @@ -12,6 +12,7 @@ >> #include >> #include >> #include >> +#include >> >> / { >> interrupt-parent = <&gic>; >> @@ -94,6 +95,61 @@ >> #size-cells = <2>; >> ranges; >> >> + thermal-zones { >> + cpu_thermal: cpu-thermal { >> + polling-delay = <1000>; >> + polling-delay-passive = <100>; > Ordinarily, you would need to set these delays to 0 in interrupt mode > to prevent polling overhead. I've just submitted a patch to of-thermal > that should fix this requirement. Could you check if it works for you? it's working for me. thanks for your review. >> + thermal-sensors = <&cpu_temp>; >> + >> + trips { >> + cpu_passive: cpu-passive { >> + temperature = <85000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + >> + cpu_hot: cpu-hot { >> + temperature = <95000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "hot"; >> + }; >> + >> + cpu_critical: cpu-critical { >> + temperature = <110000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "critical"; >> + }; >> + }; >> + }; >> + >> + ddr_thermal: ddr-thermal { >> + polling-delay = <1000>; >> + polling-delay-passive = <100>; >> + thermal-sensors = <&ddr_temp>; >> + >> + trips { >> + ddr_passive: ddr-passive { >> + temperature = <85000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "passive"; >> + }; >> + >> + ddr_critical: ddr-critical { >> + temperature = <110000>; /* millicelsius */ >> + hysteresis = <2000>; /* millicelsius */ >> + type = "critical"; >> + }; >> + }; >> + >> + cooling-maps { >> + map { >> + trip = <&ddr_passive>; >> + cooling-device = <&mali THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; >> + }; >> + }; >> + }; >> + }; >> + >> ethmac: ethernet@ff3f0000 { >> compatible = "amlogic,meson-axg-dwmac", >> "snps,dwmac-3.70a", >> @@ -2412,6 +2468,7 @@ >> assigned-clock-rates = <0>, /* Do Nothing */ >> <800000000>, >> <0>; /* Do Nothing */ >> + #cooling-cells = <2>; >> }; >> }; >> >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel