From: Adrian Hunter <adrian.hunter@intel.com>
To: Manish Narani <manish.narani@xilinx.com>,
ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com
Cc: devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, git@xilinx.com
Subject: Re: [PATCH v2 3/4] mmc: sdhci-of-arasan: Modify clock operations handling
Date: Thu, 2 Apr 2020 13:10:02 +0300 [thread overview]
Message-ID: <34dffb3a-aa90-db27-7465-df840d148658@intel.com> (raw)
In-Reply-To: <1585546879-91037-4-git-send-email-manish.narani@xilinx.com>
On 30/03/20 8:41 am, Manish Narani wrote:
> The SDHCI clock operations are platform specific. So it better to define
> them separately for particular platform. This will prevent multiple
> if..else conditions and will make it easy for user to add their own
> clock operations handlers.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 208 +++++++++++++++++------------
> 1 file changed, 119 insertions(+), 89 deletions(-)
Would you mind splitting this into a patch that moves the existing
structures first, and then a second patch to make the changes.
Also, I notice there is 'struct sdhci_arasan_data' but also
'struct sdhci_arasan_of_data sdhci_arasan_data'. This is confusing, so
perhaps a preparatory patch that renames the latter from sdhci_arasan_data
to somethine else e.g. sdhci_arasan_generic_data
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-02 10:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 5:41 [PATCH v2 0/4] Add support for Xilinx Versal SDHCI in Arasan driver Manish Narani
2020-03-30 5:41 ` [PATCH v2 1/4] dt-bindings: mmc: arasan: Document 'xlnx, versal-8.9a' controller Manish Narani
2020-03-30 5:41 ` [PATCH v2 2/4] sdhci: arasan: Add support for Versal Tap Delays Manish Narani
2020-04-02 10:11 ` Adrian Hunter
2020-03-30 5:41 ` [PATCH v2 3/4] mmc: sdhci-of-arasan: Modify clock operations handling Manish Narani
2020-04-02 10:10 ` Adrian Hunter [this message]
2020-04-06 13:55 ` Manish Narani
2020-03-30 5:41 ` [PATCH v2 4/4] mmc: sdhci-of-arasan: Fix kernel-doc warnings Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34dffb3a-aa90-db27-7465-df840d148658@intel.com \
--to=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).