From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
akpm@linux-foundation.org
Cc: linux-arch@vger.kernel.org, preid@electromag.com.au,
yamada.masahiro@socionext.com, linux-pm@vger.kernel.org,
linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
William Breathitt Gray <vilhelm.gray@gmail.com>,
linux-gpio@vger.kernel.org, lukas@wunner.de,
geert@linux-m68k.org, andriy.shevchenko@linux.intel.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v18 14/14] gpio: pca953x: Utilize the for_each_set_clump8 macro
Date: Wed, 9 Oct 2019 13:14:50 -0400 [thread overview]
Message-ID: <3543ffc3668ad4ed4c00e8ebaf14a5559fd6ddf2.1570641097.git.vilhelm.gray@gmail.com> (raw)
In-Reply-To: <cover.1570641097.git.vilhelm.gray@gmail.com>
Replace verbose implementation in set_multiple callback with
for_each_set_clump8 macro to simplify code and improve clarity.
Cc: Phil Reid <preid@electromag.com.au>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-pca953x.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index de5d1383f28d..10b669b8f27d 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -10,6 +10,7 @@
#include <linux/acpi.h>
#include <linux/bits.h>
+#include <linux/bitops.h>
#include <linux/gpio/driver.h>
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
@@ -456,7 +457,8 @@ static void pca953x_gpio_set_multiple(struct gpio_chip *gc,
unsigned long *mask, unsigned long *bits)
{
struct pca953x_chip *chip = gpiochip_get_data(gc);
- unsigned int bank_mask, bank_val;
+ unsigned long offset;
+ unsigned long bank_mask;
int bank;
u8 reg_val[MAX_BANK];
int ret;
@@ -466,15 +468,10 @@ static void pca953x_gpio_set_multiple(struct gpio_chip *gc,
if (ret)
goto exit;
- for (bank = 0; bank < NBANK(chip); bank++) {
- bank_mask = mask[bank / sizeof(*mask)] >>
- ((bank % sizeof(*mask)) * 8);
- if (bank_mask) {
- bank_val = bits[bank / sizeof(*bits)] >>
- ((bank % sizeof(*bits)) * 8);
- bank_val &= bank_mask;
- reg_val[bank] = (reg_val[bank] & ~bank_mask) | bank_val;
- }
+ for_each_set_clump8(offset, bank_mask, mask, gc->ngpio) {
+ bank = offset / 8;
+ reg_val[bank] &= ~bank_mask;
+ reg_val[bank] |= bitmap_get_value8(bits, offset) & bank_mask;
}
pca953x_write_regs(chip, chip->regs->output, reg_val);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-09 17:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 17:14 [PATCH v18 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 01/14] bitops: " William Breathitt Gray
2019-10-09 21:18 ` Andrew Morton
2019-10-10 13:18 ` Andy Shevchenko
2019-10-09 17:14 ` [PATCH v18 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 04/14] gpio: 104-idi-48: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 05/14] gpio: gpio-mm: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 06/14] gpio: ws16c48: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 07/14] gpio: pci-idio-16: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 08/14] gpio: pcie-idio-24: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 09/14] gpio: uniphier: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 10/14] gpio: 74x164: Utilize the " William Breathitt Gray
2019-10-10 13:16 ` Andy Shevchenko
2019-10-09 17:14 ` [PATCH v18 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 12/14] gpio: pisosr: Utilize the " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 13/14] gpio: max3191x: " William Breathitt Gray
2019-10-09 17:14 ` William Breathitt Gray [this message]
2019-10-10 13:16 ` [PATCH v18 14/14] gpio: pca953x: " Andy Shevchenko
2019-10-09 17:38 ` [PATCH v18 00/14] Introduce " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3543ffc3668ad4ed4c00e8ebaf14a5559fd6ddf2.1570641097.git.vilhelm.gray@gmail.com \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=preid@electromag.com.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).