From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F234C433F5 for ; Wed, 23 Mar 2022 14:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YydgEM8MJbJAsA8xYXniXa21sWw7/g1UHK8z0A6B4zA=; b=jgtlOb64zhzwYT ZaCBSANh6naJsnIbbH7CaPGmoadmscFbvatl1VvGyagwvmefEFMsd0hq/q/ddyKzcRvqDD3EPiqh1 UqqhgYl2bnWgia1jlFmjSszXOlOtHsRUPy0epZJNCgwgSKEs8j4m7U/11eC6KW6QVtHLRVINjbMxg x92HeDSd8r/OLDGQn/JS2XRy1WyVf/+JvX9/Aos9nsKkV/DN2WNYoRvU+nYg3wWz4jhUWwdJoHEhx BjlcCENd3JYQCL9/JrmidB/jEj5/CH5SUax3wWL5P6iPeJKR74f+QXfP2SDoSFZxxSE/MHSeXR12u AAUEbHWx3i7ex+GFOowQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX1hr-00Drkr-0X; Wed, 23 Mar 2022 14:11:23 +0000 Received: from mail-ed1-f46.google.com ([209.85.208.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nX1hn-00Drk7-LG for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 14:11:21 +0000 Received: by mail-ed1-f46.google.com with SMTP id r23so2033688edb.0 for ; Wed, 23 Mar 2022 07:11:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:content-language:to:cc:references:in-reply-to :content-transfer-encoding; bh=4HA4+cV5Cx2YJ/wnGG8SlUcCWZl88X9bJXGKc8DKpxk=; b=tq9iZqfwLmeZofejUeF90CBnWi9cGb4Qfn4iv6jv62is4MQ1ycNay5Eyh/NB19TH4j 7AAYr7mfF/3bY94uhJ7DtUp2hedk6Kjl8OOvcAlfnFdQqJNwjfRSCv+b6W1G409wMGXm fFr7vjg5wqpuYiOpc/nPnBqPopWudmRMf39s0Z7LdPMXlAJ/nTpxpzbBhVBV+UX4ilsT ddvXbllMR7fPTZsd5GZLcuyjdOHSaSUFMqpGLY/dPmDfSin/ALOVwBFub8qB8ZBY1sXI Qm/rBYRvSNQvWcK14Aqrm/8woalfipZLHXOQgUb+yOWV/GQqmS31yxP3tvObJicI1T31 mrCw== X-Gm-Message-State: AOAM5321UXKQgXvQISlaZviHqzsjRiJYBNe4BKa4B5khgMK8b6F1Hnqv eWf7yMfeKClHPLzBvxiJgYU= X-Google-Smtp-Source: ABdhPJy0t1OjP/Hq1l00yzZQD24L/hzLXOOrAXXXbbnSzOp4xPY+DuUEXsDeBfbMxTTh3SauXo5aCQ== X-Received: by 2002:a05:6402:4414:b0:419:28bc:55dc with SMTP id y20-20020a056402441400b0041928bc55dcmr316217eda.130.1648044678168; Wed, 23 Mar 2022 07:11:18 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id n13-20020a170906724d00b006cedd6d7e24sm9974442ejk.119.2022.03.23.07.11.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 07:11:17 -0700 (PDT) Message-ID: <354951e0-d2a8-bf4f-e0c5-081e836bb3c3@kernel.org> Date: Wed, 23 Mar 2022 15:11:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] dt-bindings: mmc: imx-esdhc: Change imx8mn and imx8mp compatible fallback Content-Language: en-US To: Adam Ford Cc: arm-soc , Adam Ford-BE , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-mmc , devicetree , Linux Kernel Mailing List References: <20220323134019.3796178-1-aford173@gmail.com> <35f58894-ed6d-0af0-e483-7a161ad6625a@kernel.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_071119_733603_BB755E2F X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/03/2022 15:00, Adam Ford wrote: > On Wed, Mar 23, 2022 at 8:56 AM Krzysztof Kozlowski wrote: >> >> On 23/03/2022 14:40, Adam Ford wrote: >>> The SDHC controller in the imx8mn and imx8mp have the same controller >>> as the imx8mm which is slightly different than that of the imx7d. >>> Using the fallback of the imx8mm enables the controllers to support >>> HS400-ES which is not available on the imx7d. >>> >>> Signed-off-by: Adam Ford >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml >>> index 7dbbcae9485c..d6ea73d76bdd 100644 >>> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml >>> @@ -39,14 +39,14 @@ properties: >>> - items: >>> - enum: >>> - fsl,imx8mm-usdhc >> >> Your change looks reasonable, but why imx8mm is compatible with imx7d? > > I saw that, and I wasn't sure the best way to go about fixing it. If > I move the 8mm out of the imx7d category, do I need to add it to the > enum list associated with the imx8mm, or can I just delete it from the > enum leaving the const for imx8mm good enough? > The DTS is using: compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc" which looks incorrect, based on what you wrote in commit description. Since fsl,imx8mm-usdhc has its own compatibility-group and defines the properties for entire family (imx8mm + imx8mn + imx8mp), then I would assume that either fsl,imx8mm-usdhc is not be compatible with imx7d or everything is compatible with imx7d. IOW, DTS and bindings should be changed to one of following: 1. Everything compatible with imx7d: compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc"; compatible = "fsl,imx8mq-usdhc", "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc"; 2. A new group: compatible = "fsl,imx8mm-usdhc"; compatible = "fsl,imx8mq-usdhc", "fsl,imx8mm-usdhc"; Which one, I am not sure. My commit 80fd350b95 organized it in (1) approach, because also that time there was no new group for 8mm (added in commit 431fae8). I assume NXP engineer knows better, so the better solution would be (2). In such case, imx8mm has to be moved to the first enum and all DTS have to be adjusted. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel