From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 622D7C7618A for ; Mon, 20 Mar 2023 11:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bZepWdU5GU2YK6Sq1uysLV47IsYkL9SRmCqjDBBhGFw=; b=RvqRZUrv6+lQrh /Kfmgg+U8IqQAcKyhuZSDA4fI3MR5y2vLdf/X8Vjcpi/U2MWtGx6yQl8dAvwJ7eT86pyaSmx7oTtT iQTLbq5b30jE9C+/UsQnHkkeufQlfIN5yz/k7tQjzqn8UjRSHMfidGF5AtpnRNstcO1daxmAHcSVN qnqDmgl9Vq+QwWtA4Uc4RiA8XR/Up1tC/dvSJ1xtebEZtb1mk4wxpqqefzGAYvFOGLRrEHwbsM+Jt in088RRCbI9+swPnoTXuy90Q6C6bkbuilJwljpzC2dtaEMTAD5bkP8h3LzIXGc6BYdYGN1V9kT64i MSgh2rwXOXXfn6UU57sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peDrU-008qPN-0o; Mon, 20 Mar 2023 11:39:36 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peDrG-008qLc-1o for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 11:39:24 +0000 Received: by mail-ed1-x529.google.com with SMTP id h8so45418379ede.8 for ; Mon, 20 Mar 2023 04:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679312360; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ShGrWTqpBYO/SMDmz1FUp9/Cnckjt6bpBWjpINOQBvM=; b=U5Ba8vnx02o1jOVTya5gjvxG5eePkXUJIz4BznDZi7oYV1LDrxHQ26lvfzstsTZT4X EXuW1gu10S78je91uYVaZUzxMxVGfSn94GBy1g2rcGTjchTCsTjkAROrqX5VOE5CVbO6 YUPjYluatcvO8hNlU8ymefXUIadav9vsZD64CZAZ9Y7iNidtJyJD+Gw3YAM24e+MUOJp BQOezhqfh93cWmi9ORCcfvQRYEC0OkuFw5FVrPemhN3GBKl+XBen5Zw8eTs1WZov9ON3 9zzPSP6hoZJwq/3Dvtf9dswvnGQXd3FtnZuWQHoVGuUPgpa3QUpDkxt2GR1ae5+u7whg Ax7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679312360; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ShGrWTqpBYO/SMDmz1FUp9/Cnckjt6bpBWjpINOQBvM=; b=IMVtpGcw4LOd1r3XYPlGWvE0SxNY55kRBArgnlASqjgQkmRBLPgR9b31OYzqwkNm+8 JNvC4loIt43FXfncGbdVkzrvhELy7uDo19TEvTniKTO6KDVdQfkW6bV5IhsNT+9TvsFB JYEjc6hHzt2ZXnXagXOxTVXJs6rerk3nZKFDV5IOahs8tS6CwsEbJgAlvuQBB4swdT/3 tUmweUgPxNDdxjXQC0LSj37B7MOLkS6qBSgaA/vDzawSE2ntPpqPt+mFs7HZqmMbAnel sURscWyFM31WE+3VauO2j2U2HeR7RNodzx62h0MzhtugA1bFbjjhqjapOjvxw68qW9HI Qwjw== X-Gm-Message-State: AO0yUKXQr8zyiqWXBOLbMrjE2mU9lkDp9Bz5lVBynuq6dbqzAUTI+S+t yMwqlGIEfbnK8gv4Q/hMVtb3ag== X-Google-Smtp-Source: AK7set9OOcOsno7fRwtj0mHO3kQekqDD2nlgrGFWHIJ62wqI55Bbl2295GpLbftS8sfcz0gn7Gb5dw== X-Received: by 2002:a17:907:6295:b0:932:f88c:c2ff with SMTP id nd21-20020a170907629500b00932f88cc2ffmr9752264ejc.34.1679312360028; Mon, 20 Mar 2023 04:39:20 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:458e:64e7:8cf1:78b0? ([2a02:810d:15c0:828:458e:64e7:8cf1:78b0]) by smtp.gmail.com with ESMTPSA id ch19-20020a170906c2d300b00933d64cd447sm1645621ejb.121.2023.03.20.04.39.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 04:39:19 -0700 (PDT) Message-ID: <355d5dde-cc86-018c-85d5-51cf59bdb36a@linaro.org> Date: Mon, 20 Mar 2023 12:39:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct i.MX8MQ support Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , Xu Yang Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jun Li References: <20230320020714.955800-1-peng.fan@oss.nxp.com> <8efe78d3-ff50-1970-3a90-28bab4992bad@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_043922_597849_0D8EEFEE X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/03/2023 12:02, Peng Fan wrote: >> Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct >> i.MX8MQ support >> >> On 20/03/2023 03:07, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> The previous i.MX8MQ support breaks rockchip,dwc3 support, so use >>> select to restrict i.MX8MQ support and avoid break others. >>> >>> Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ") >>> Signed-off-by: Peng Fan >>> --- >>> .../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++------- >>> 1 file changed, 14 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> index 16c7d06c9172..6347a6769ee3 100644 >>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >>> @@ -28,15 +28,22 @@ allOf: >>> else: >>> $ref: usb-xhci.yaml# >>> >>> +select: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - fsl,imx8mq-dwc3 >> >> And what about all snps,dwc3 devices there (without specific compatible)? >> Previously they were selected and now they are not... so you just disabled >> schema for all of them. > [Peng Fan] > > I am not sure how to address: > https://lore.kernel.org/all/CAL_Jsq+nrqTX5ND3=+kFUmStx-+b=qpE_WsL_Le-YX8c285-5A@mail.gmail.com/ > > Rob suggested use select, but I am not sure how to use it here. Use > an extra yaml file with select or else. > >> >>> + required: >>> + - compatible >>> + >>> properties: >>> compatible: >>> - oneOf: >>> - - items: >>> - - const: fsl,imx8mq-dwc3 >> >> I don't understand why you remove your compatible. > [Peng Fan] > > My last change drops 'contains' by mistake, and breaks This I understand. > rockchip,dwc3, so just bring back the original content This is not a reason to make your compatible undocumented. You basically revert your patch. It does not make any sense to me. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel