From: Alistair Popple <alistair@popple.id.au>
To: Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
Eddie James <eajames@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Rob Herring <robh+dt@kernel.org>, Jeremy Kerr <jk@ozlabs.org>,
Ingo Molnar <mingo@redhat.com>,
linux-arm-kernel@lists.infradead.org, linux-fsi@lists.ozlabs.org
Subject: Re: [PATCH v2 03/11] ABI: Update FSI path documentation
Date: Fri, 08 Nov 2019 20:27:47 +1100 [thread overview]
Message-ID: <3563232.FuPAt9pb84@townsend> (raw)
In-Reply-To: <20191108051945.7109-4-joel@jms.id.au>
On Friday, 8 November 2019 4:19:37 PM AEDT Joel Stanley wrote:
> The paths added back in 4.13 weren't quite correct. The in reality the
Minor nit-pick, it should read "In reality the...". Otherwise looks reasonable.
Acked-by: Alistair Popple <alistair@popple.id.au>
> files documented lived under
>
> /sys/devices/../fsi0/rescan
> /sys/devices/../fsi0/break
> /sys/devices/../fsi0/slave@00:00/term
> /sys/devices/../fsi0/slave@00:00/raw
>
> In 5.5 with the addition of the FSI class they move to
>
> /sys/devices/../fsi-master/fsi0/rescan
> /sys/devices/../fsi-master/fsi0/break
> /sys/devices/../fsi-master/fsi0/slave@00:00/term
> /sys/devices/../fsi-master/fsi0/slave@00:00/raw
>
> This is closer to how the (incorrect) documentation described them.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Documentation/ABI/testing/sysfs-bus-fsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-fsi b/Documentation/ABI/testing/sysfs-bus-fsi
> index 57c806350d6c..320697bdf41d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-fsi
> +++ b/Documentation/ABI/testing/sysfs-bus-fsi
> @@ -1,25 +1,25 @@
> -What: /sys/bus/platform/devices/fsi-master/rescan
> +What: /sys/bus/platform/devices/../fsi-master/fsi0/rescan
> Date: May 2017
> KernelVersion: 4.12
> -Contact: cbostic@linux.vnet.ibm.com
> +Contact: linux-fsi@lists.ozlabs.org
> Description:
> Initiates a FSI master scan for all connected slave devices
> on its links.
>
> -What: /sys/bus/platform/devices/fsi-master/break
> +What: /sys/bus/platform/devices/../fsi-master/fsi0/break
> Date: May 2017
> KernelVersion: 4.12
> -Contact: cbostic@linux.vnet.ibm.com
> +Contact: linux-fsi@lists.ozlabs.org
> Description:
> Sends an FSI BREAK command on a master's communication
> link to any connnected slaves. A BREAK resets connected
> device's logic and preps it to receive further commands
> from the master.
>
> -What: /sys/bus/platform/devices/fsi-master/slave@00:00/term
> +What: /sys/bus/platform/devices/../fsi-master/fsi0/slave@00:00/term
> Date: May 2017
> KernelVersion: 4.12
> -Contact: cbostic@linux.vnet.ibm.com
> +Contact: linux-fsi@lists.ozlabs.org
> Description:
> Sends an FSI terminate command from the master to its
> connected slave. A terminate resets the slave's state machines
> @@ -29,10 +29,10 @@ Description:
> ongoing operation in case of an expired 'Master Time Out'
> timer.
>
> -What: /sys/bus/platform/devices/fsi-master/slave@00:00/raw
> +What: /sys/bus/platform/devices/../fsi-master/fsi0/slave@00:00/raw
> Date: May 2017
> KernelVersion: 4.12
> -Contact: cbostic@linux.vnet.ibm.com
> +Contact: linux-fsi@lists.ozlabs.org
> Description:
> Provides a means of reading/writing a 32 bit value from/to a
> specified FSI bus address.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-08 9:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 5:19 [PATCH v2 00/11] fsi: Patches for 5.5 Joel Stanley
2019-11-08 5:19 ` [PATCH v2 01/11] fsi: Add fsi-master class Joel Stanley
2019-11-08 9:17 ` Alistair Popple
2019-11-08 5:19 ` [PATCH v2 02/11] fsi: Move master attributes to " Joel Stanley
2019-11-08 9:18 ` Alistair Popple
2019-11-08 5:19 ` [PATCH v2 03/11] ABI: Update FSI path documentation Joel Stanley
2019-11-08 9:27 ` Alistair Popple [this message]
2019-11-08 5:19 ` [PATCH v2 04/11] trace: fsi: Print transfer size unsigned Joel Stanley
2019-11-08 9:21 ` Alistair Popple
2019-11-08 5:19 ` [PATCH v2 05/11] fsi: core: Fix small accesses and unaligned offsets via sysfs Joel Stanley
2019-11-08 5:19 ` [PATCH v2 06/11] fsi: fsi_master_class can be static Joel Stanley
2019-11-08 5:19 ` [PATCH v2 07/11] fsi: Move defines to common header Joel Stanley
2019-11-08 5:19 ` [PATCH v2 08/11] dt-bindings: fsi: Add description of FSI master Joel Stanley
2019-11-08 9:23 ` Alistair Popple
2019-11-08 10:28 ` Greg KH
2019-11-08 5:19 ` [PATCH v2 09/11] fsi: Add ast2600 master driver Joel Stanley
2019-11-08 9:29 ` Alistair Popple
2019-11-08 5:19 ` [PATCH v2 10/11] fsi: aspeed: Add trace points Joel Stanley
2019-11-08 5:19 ` [PATCH v2 11/11] fsi: aspeed: Fix OPB0 byte order register values Joel Stanley
2019-11-08 9:31 ` Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3563232.FuPAt9pb84@townsend \
--to=alistair@popple.id.au \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).