From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CE0C2D0EF for ; Sat, 18 Apr 2020 09:49:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36146221F4 for ; Sat, 18 Apr 2020 09:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DIPkD/fX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36146221F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V6Y8m4UsxJNvBbppyQH3a19kRJ0WauYd8B0YlwybNIc=; b=DIPkD/fXgpEvO6 apGCNRfEP+qS9naVu91SCA9PANFemyaUAMXtedUrIL/2QW1ElpjOJy4XlxC1BcUF7HXMZT+OLkJYx 6pafao4ZIFjko9H0Ixm8CgxXufCiy0ElUoch+pS/PPUMXadXk0cRDopTg1qk0M605opvn/oVzk0fk D06YD0bb79ExJpL3NcQ7UFD5Vu4mDw2HAbIfLb+CopOsXo1/BKM8OmvBYbZNYT+kgdq8+NtByV80B 3ST5PW20RG53Fc77l1cV4dkX2WMT5NZNkGfy2w/Ze+0LwJQyGa99BPvbtj31zm7ue/CTDS0mTw92L JvB7l2p4o4BlSXKLs84A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPk6j-0000oU-Gj; Sat, 18 Apr 2020 09:49:53 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPk6g-0000lp-0M; Sat, 18 Apr 2020 09:49:51 +0000 Received: from p57b77241.dip0.t-ipconnect.de ([87.183.114.65] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPk6X-0000lO-Su; Sat, 18 Apr 2020 11:49:41 +0200 From: Heiko Stuebner To: Johan Jonker Subject: Re: [PATCH v4 2/3] ARM: dts: rockchip: add rga node for rk322x Date: Sat, 18 Apr 2020 11:49:41 +0200 Message-ID: <3593382.iQIKm1rSL1@phil> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200418_024950_048947_2FBB2A8F X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, justin.swartz@risingedge.co.za, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 18. April 2020, 11:15:27 CEST schrieb Johan Jonker: > Hi Justin, Heiko, > > In the discussion about "rockchip,px30-rga" it was mentioned that: > "no status for soc internal components without any board-specifics". > The binding is in mainline, but the dts node is missing I think. > Should this also be changed? yep, drop the status disabled from the dtsi and that then results in not needing the board-level enablement (background: rga is a simple mem2mem device without any board-specific hooks) > > Johan > > +&rga { > + status = "okay"; > +}; > + > > > Add a node to define the presence of RGA, a 2D raster > > graphic acceleration unit. > > > > Signed-off-by: Justin Swartz > > --- > > arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi > > index 340ed6ccb..29d50bebc 100644 > > --- a/arch/arm/boot/dts/rk322x.dtsi > > +++ b/arch/arm/boot/dts/rk322x.dtsi > > @@ -621,6 +621,17 @@ > > status = "disabled"; > > }; > > > > + rga: rga@20060000 { > > + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga"; > > + reg = <0x20060000 0x1000>; > > + interrupts = ; > > + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>; > > + clock-names = "aclk", "hclk", "sclk"; > > + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; > > + reset-names = "core", "axi", "ahb"; > > > + status = "disabled"; > > remove? > > > + }; > > + > > iep_mmu: iommu@20070800 { > > compatible = "rockchip,iommu"; > > reg = <0x20070800 0x100>; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel