From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2334C2B9F4 for ; Fri, 25 Jun 2021 13:26:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E00661628 for ; Fri, 25 Jun 2021 13:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E00661628 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ZouEl08jF6P/D1241NZ6fpj2WZjGGFM87gZFm4EXaRU=; b=XSMFDaUgIAqy6uB2KngaanVhbB 5wK+R0Bc4wm4YnkPEZXUZ5atGjUQ/IJcN6OJaf9g0GcGXHOd3B6A4DSOkpNpgIQrRQ/gydQt3XI6Y ERHXb0MWK5BRESOLUSsptqLGp6NcqPaOnjznY0y2gfPwbQ5xar2S2o0F9dRz99CFE/UIKN4X+e+P2 Hq6MDQd5cFY2rvlJ5fisxt2ekFGTO9guIJLKSrnYOfk8m2pQadepNiCF4ZovNX5xvdoE8yjtc8EWw Lih5VmfqOgIoF3guFwQ65oU5n7PDHh3JcIbCcQrCbNfjsyHYj9IUrn5ZDPgWDW8INKgo8vN/cBYiy 3uvf108Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwlpl-001f2e-Qd; Fri, 25 Jun 2021 13:25:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwlph-001f0p-Gq for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 13:25:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A5B031B; Fri, 25 Jun 2021 06:25:19 -0700 (PDT) Received: from [10.57.8.165] (unknown [10.57.8.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 391E73F694; Fri, 25 Jun 2021 06:25:17 -0700 (PDT) Subject: Re: [PATCH v5 5/5] perf arm-spe: Don't wait for PERF_RECORD_EXIT event To: Leo Yan , Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Dave Martin , Al Grant , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210519071939.1598923-1-leo.yan@linaro.org> <20210519071939.1598923-6-leo.yan@linaro.org> From: James Clark Message-ID: <369fd454-d94d-daa1-ead4-b42645ec4282@arm.com> Date: Fri, 25 Jun 2021 14:25:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210519071939.1598923-6-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_062521_708315_8E658B62 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/05/2021 08:19, Leo Yan wrote: > When decode Arm SPE trace, it waits for PERF_RECORD_EXIT event (the last > perf event) for processing trace data, which is needless and even might > cause logic error, e.g. it might fail to correlate perf events with Arm > SPE events correctly. > > So this patch removes the condition checking for PERF_RECORD_EXIT event. > > Signed-off-by: Leo Yan > --- > tools/perf/util/arm-spe.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c > index 5c5b438584c4..58b7069c5a5f 100644 > --- a/tools/perf/util/arm-spe.c > +++ b/tools/perf/util/arm-spe.c > @@ -717,11 +717,7 @@ static int arm_spe_process_event(struct perf_session *session, > sample->time); > } > } else if (timestamp) { > - if (event->header.type == PERF_RECORD_EXIT) { > - err = arm_spe_process_queues(spe, timestamp); > - if (err) > - return err; > - } > + err = arm_spe_process_queues(spe, timestamp); > } > > return err; > For the whole set: Reviewed-by: James Clark Tested-by: James Clark I see a big improvement in decoding involving multiple processes because the timestamps are now correlated with the comm and mmap events. For example perf-exec samples are visible right before the exec is done, and on an application that forks, samples are visible from all processes. For example: perf record -e arm_spe// -- bash -c "stress -c 1" perf script perf-exec 4502 [003] 259755.050409: 1 l1d-access: ffff80001014b840 sched_clock+0x40 ([kernel.kallsyms]) perf-exec 4502 [003] 259755.050409: 1 tlb-access: ffff80001014b840 sched_clock+0x40 ([kernel.kallsyms]) perf-exec 4502 [003] 259755.050409: 1 memory: ffff80001014b840 sched_clock+0x40 ([kernel.kallsyms]) perf-exec 4502 [003] 259755.050411: 1 tlb-access: ffff800010120fb8 __rcu_read_lock+0x0 ([kernel.kallsyms]) bash 4502 [003] 259755.050411: 1 branch-miss: ffff8000105b2a40 memcpy+0x80 ([kernel.kallsyms]) bash 4502 [003] 259755.050411: 1 tlb-access: 0 [unknown] ([unknown]) ... stress 4502 [003] 259755.051468: 1 l1d-access: ffff800010259a24 __vma_adjust+0x1f4 ([kernel.kallsyms]) stress 4502 [003] 259755.051468: 1 tlb-access: ffff800010259a24 __vma_adjust+0x1f4 ([kernel.kallsyms]) stress 4502 [003] 259755.051468: 1 memory: ffff800010259a24 __vma_adjust+0x1f4 ([kernel.kallsyms]) Previously samples were only attributed to 'stress', which was obviously wrong. James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel