From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404EBC433B4 for ; Mon, 17 May 2021 14:58:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 024D360BBB for ; Mon, 17 May 2021 14:58:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 024D360BBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sGoevcn+EGpTZmK8mXezcDH8fzjQF5gSNjIqt8epsUE=; b=CgkTJeEKr+RX43J7/e0U5WR4t vqpSNyTK0mK2GDpqGLviorV5qX9aXSQQO8wFVrSYy5h/IWOat/pg4T4kbDwKGUK5oPW63X0lpFnJL iI4DkhnvidvBT1ivPWT6OWnCXtOOx1jakfOvy/VHk4NPA0ZAiQc0H1BsRaGTL48wXhL95MNLhyR9F H6Pm/K+xunlA9J5xDi0sz0Pvq6TtCK5bcOR9VvrGKDIo/vXl/hEcevOFhKQgP+M8JyAFfRsn12I/J VLQw9CLMpnrXEPEWDx3lDtaYdkH4Yia2WWmgiCee7uZde8Iy6pPdFeSxGoBPWy88/q7ZIIDtYBgGn TTqnMcOYA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liefk-00FKXm-So; Mon, 17 May 2021 14:56:45 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liefh-00FKXT-Ow for linux-arm-kernel@desiato.infradead.org; Mon, 17 May 2021 14:56:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=YBUa9ZRCcehhyJHtzpeD5LHz4EfoHSWuK0ObWVWzHzA=; b=IVH1413dC32B7ic3MmG/Vii9Q5 jZsrq5KTKUp7sD1mUnwWrQvAZzUOmEy60F5zkHjhQCJW7QLnwF4y1HrmsjeMVJiXtpJQAhUgXsHas PIaKMIDAfKiAvzQ39l76nneG0yJZ1ykY3YpxqsN10vxcawTG+EI578M3lcEcYrIrfwkcAicuGdaTX MOPHUZ1oKqVVyDT+AjV/l3xJbiIjnr8O1l0Mnw0MR0UxUzsZmURNuBioX83srytaPFZ0bRHUlBYDy 53/MfSbLWGZpQ/TNmWz4W6UWYxp1sclecegVKmnBiYjY4p1jdfrIIHPqR6EUM8Wx2y/7NEb2sj6TJ U15QPyWA==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liefd-00DtFT-NE for linux-arm-kernel@lists.infradead.org; Mon, 17 May 2021 14:56:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 19BD2106F; Mon, 17 May 2021 07:56:36 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 815AE3F73B; Mon, 17 May 2021 07:56:33 -0700 (PDT) Subject: Re: [PATCH v12 1/8] arm64: mte: Handle race when synchronising tags To: Marc Zyngier Cc: Catalin Marinas , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones References: <20210517123239.8025-1-steven.price@arm.com> <20210517123239.8025-2-steven.price@arm.com> <87cztpv4mo.wl-maz@kernel.org> From: Steven Price Message-ID: <37fe19b5-6494-41c5-e541-ddc873a82be0@arm.com> Date: Mon, 17 May 2021 15:56:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87cztpv4mo.wl-maz@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_075637_836270_21A087F7 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2021 15:03, Marc Zyngier wrote: > Hi Steven, Hi Marc, > On Mon, 17 May 2021 13:32:32 +0100, > Steven Price wrote: >> >> mte_sync_tags() used test_and_set_bit() to set the PG_mte_tagged flag >> before restoring/zeroing the MTE tags. However if another thread were to >> race and attempt to sync the tags on the same page before the first >> thread had completed restoring/zeroing then it would see the flag is >> already set and continue without waiting. This would potentially expose >> the previous contents of the tags to user space, and cause any updates >> that user space makes before the restoring/zeroing has completed to >> potentially be lost. >> >> Since this code is run from atomic contexts we can't just lock the page >> during the process. Instead implement a new (global) spinlock to protect >> the mte_sync_page_tags() function. >> >> Fixes: 34bfeea4a9e9 ("arm64: mte: Clear the tags when a page is mapped in user-space with PROT_MTE") >> Signed-off-by: Steven Price >> --- >> --- >> arch/arm64/kernel/mte.c | 21 ++++++++++++++++++--- >> 1 file changed, 18 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c >> index 125a10e413e9..c88e778c2fa9 100644 >> --- a/arch/arm64/kernel/mte.c >> +++ b/arch/arm64/kernel/mte.c >> @@ -25,6 +25,7 @@ >> u64 gcr_kernel_excl __ro_after_init; >> >> static bool report_fault_once = true; >> +static spinlock_t tag_sync_lock; > > What initialises this spinlock? Have you tried this with lockdep? I'd > expect it to be defined with DEFINE_SPINLOCK(), which always does the > right thing. You of course are absolute right, and this will blow up with lockdep. Sorry about that. DEFINE_SPINLOCK() solves the problem. Thanks, Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel