From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F9AC2D0E4 for ; Sat, 21 Nov 2020 02:53:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0548223FD for ; Sat, 21 Nov 2020 02:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ObjoyGxT"; dkim=temperror (0-bit key) header.d=sholland.org header.i=@sholland.org header.b="MSULuAWf"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="sAVWfcR6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0548223FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iQFrJCAf8HcS8OUwDJ9yYRskIYZOVIhm0ysXxrkqn78=; b=ObjoyGxTPQDghwOMgKXH2Eb3L iL+DWJrA2JxyGuIQbX7OCDc9w9QXuMFtl/ciPS2YqHuQ6Nmm16YJPUkg3aVNIVePpjmWsY+lC1rAb +jveVsBwwvmNB5zNGldXaIQnpvOamICwE9OUGzKKRaDP332n9j8mEuyZ0uuc9DryHatsCj1X8A0Zz J+aXc8YWvqyiwU+dTxQB72cb53qTrwc3Glw/hT9rZfn2OdXFCdVsnbcnC6vlgDsNrsRG2vUxEzrzr Im6pa6rdBUUaIJuC1W29imztrKdGQb0AbFJBFHdQ+OfDP/r0WYV+YSpoOCnbhcpXOGThMYaWLAB/J ygDX7ZdWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgJ0L-00082l-4f; Sat, 21 Nov 2020 02:52:01 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgJ0H-00082A-7G for linux-arm-kernel@lists.infradead.org; Sat, 21 Nov 2020 02:51:58 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 27AD810F3; Fri, 20 Nov 2020 21:51:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 20 Nov 2020 21:51:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=O u73bD4f45P9uvVKv0KtV27VfJnt6NKTFMndwelV6do=; b=MSULuAWfZNB+8eVnW c0xx2MQ5RRLIdgBFOuvrufrIxtG9MUmcyOsIwdHCxm5Rsnr+HeZI+nnuhYZq66+L Yg9hBUCXqRkCtvJqra9ntwKHI495kwMjpEWghgOkgpfi9rBursCrS/JP2IwITRnw 5H8xg5Q0907S0hjxKpTczfX9XkI0Nm7qI8nMn+Ye0kLH3gqg/aGVwo2T+Kh+2OZP J7WC4+psb87PQGp1e7bBhhOlfEGaSvFkPeRm+AnDRNsF8rGMmtBVHl/CV5pNYbgd Y1Na3fabPWm15fZh2w6kZCi4rCdn4qd5n1gNg42ifFIZyVKQNyUddw77EQoW+mb8 Aff5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ou73bD4f45P9uvVKv0KtV27VfJnt6NKTFMndwelV6 do=; b=sAVWfcR6RH9QwlyY1gQ81V2/VwA+G7J2mcB/ULi4dbRmqoFlPOwQ1j9nR CF6GsNpB8UnSyODJWtiNz4t76XrKG4nOnaDPCTyAOcBJ6QmgQvqTNU9IfcGQSO8B oOdpf/M3m1paqvxrUMiHSoQtsI70v2bv5Zron+nrk16KBha+rGc2C/jvUFa5m+lN lJ5aSRRyIY8kgyQRQWsFzUZMRsR/vnSvAKa3w2wZcH6Crwqw7M2imcMKPYIW20Zk eprdHf4lddcM343KvmzXbKlhYjPXJEkIClw3BJIkDdHYVFac4eDV139Ycf38mj8p /D6a9VjPC/uVc4XpWWcU7JKHGG8rA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeguddgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepvddttdejieduudfgffevteekffegffeguddtgfefkeduvedukeff hedtfeevuedvnecukfhppeejtddrudefhedrudegkedrudehudenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Received: from [70.135.148.151] (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA id 723433280060; Fri, 20 Nov 2020 21:51:49 -0500 (EST) To: Icenowy Zheng , Maxime Ripard References: <20201107124958.2222253-1-icenowy@aosc.io> <20201107125332.2223197-1-icenowy@aosc.io> <20201110103925.rbej5ueo2fefbmlp@gilmour.lan> <6175E674-E8BC-4199-8BE8-A983065C32D5@aosc.io> <20201116155508.364dg6ycklwylswe@gilmour.lan> <8FFC1A6C-9CA4-4F94-91C4-F111A7519979@aosc.io> <20201120155939.3ajmbny2pka2vsnf@gilmour> From: Samuel Holland Subject: Re: [linux-sunxi] Re: [PATCH 3/3] arm64: allwinner: dts: a64: add DT for PineTab developer sample Message-ID: <38ee5feb-e35d-801f-99a1-65e23618e73b@sholland.org> Date: Fri, 20 Nov 2020 20:51:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_215157_471711_15ECC88B X-CRM114-Status: GOOD ( 20.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Maxime, On 11/20/20 5:30 PM, Icenowy Zheng wrote: >>>>>>> +/ { >>>>>>> + model = "PineTab Developer Sample"; >>>>>>> + compatible = "pine64,pinetab-dev", "allwinner,sun50i-a64"; >>>>>>> +}; >>>>>> >>>>>> Changing the DT and the compatible half-way through it isn't ok. Please >>>>>> add a new DT with the newer revision like we did for the pinephone >>>>> >>>>> We did this on Pine H64. >>>> >>>> What are you referring to? I couldn't find a commit where we did what >>>> you suggested in that patch to the pine H64. >>> >>> Oh the situation is complex. On Pine H64, we didn't specify anything at >>> start (which is the same here), the DT is originally version-neutral >>> but then transitioned to model B, then reverted to model A. Here the DT is always >>> for the sample. >>> >>> However, for Pine H64 there's model A/B names, but for PineTab there's no >>> any samples that are sold, thus except who got the samples, all PineTab >>> owners simply owns a "PineTab", not a "PineTab xxx version". >> >> It's fairly simple really, we can't really predict the future, so any DT >> submitted is for the current version of whatever board there is. This is I don't think that was the intention at all. The DT was submitted for a future product, whatever that future product ends up being at the time of its release. Since there are necessarily no users until the product ships, there is no chance of breaking users by modifying the DT. >> what we (somewhat messily) did for the PineH64, for the pinephone, or >> really any other board that has several revisions Surely a non-public prototype doesn't count as a separate revision! This sort of policy strongly discourages ever shipping a board with out-of-the-box mainline Linux support. Because if there any hardware bugs fixed between initial upstreaming and production, the manufacture must come up with a new DT name. This is hostile to the users as well, because the "canonical" DT name no longer matches the "canonical" (read: the only one ever available) version of the hardware. Do you want manufacturers to submit their initial board DT as "$BOARD-prototype.dts", just in case they have to make a change before production? And only after the board is shipped (with out-of-tree patches, of course, to use $BOARD.dts, since the shipped board is *not* the prototype) submit a "$BOARD.dts" to mainline? Maxime, can you clarify specifically what the line is where a device tree is "locked down" and further changes to the hardware require a new name? First sample leaves the factory? $NUMBER units produced? First sold to the public for money? Without some guidance, or a change in policy, this problem is going to keep coming up again and again. You'll note that so far it has mostly affected Pine devices, and I don't think that's because they make more board revisions than other manufacturers. It's because they're actively involved in getting their boards supported upstream. For other manufacturers, it's some user sending in a device tree months after the hardware ships to the public -- of course the hardware is more stable at that point. I think Pine's behavior is something we want to encourage, not penalize. > Okay. But I'm not satisfied with a non-public sample occupies > the pinetab name. Is rename it to pinetab-dev and add a > pinetab-retail okay? To me, naming the production version anything but "pinetab" isn't satisfying either. Samuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel