From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Laibin Qiu <qiulaibin@huawei.com>, <adrian.hunter@intel.com>,
<ulf.hansson@linaro.org>, <yuehaibing@huawei.com>
Cc: <linux-mmc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
Date: Fri, 9 Apr 2021 09:42:03 +0200 [thread overview]
Message-ID: <39dd50a7-6e85-49e4-8072-e88fcc471714@foss.st.com> (raw)
In-Reply-To: <20210409023801.3326572-1-qiulaibin@huawei.com>
Hi Laibin
On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
> ---
> drivers/mmc/host/sdhci-st.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "top-mmc-delay");
> pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pdata->top_ioaddr)) {
> - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> + if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
> - }
>
> pltfm_host->clk = clk;
> pdata->icnclk = icnclk;
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-09 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 2:38 [PATCH -next] mmc: sdhci-st: Remove unnecessary error log Laibin Qiu
2021-04-09 7:42 ` Patrice CHOTARD [this message]
2021-04-12 7:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39dd50a7-6e85-49e4-8072-e88fcc471714@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=adrian.hunter@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=qiulaibin@huawei.com \
--cc=ulf.hansson@linaro.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).