From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE857C6377D for ; Thu, 22 Jul 2021 14:19:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC4AA6128D for ; Thu, 22 Jul 2021 14:19:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC4AA6128D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=holtmann.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=va+F0NXiWKqe2li3kV/PxnD1i3Z/Isu/FL0kQytA8IY=; b=sb4RdcEZ9gv5l5 4tDEQPyBbT2FPjjkCSceZznml1n78mSuhWd1kWTBsvSJ3hD+yK5WANhmUmHwohJH3Q3FTs4Ff0EcJ K4C8I0f5DnZhV55oIWr3F+gCGFlIkBVdyYRpqMOzaN61v34tvyDFidvJGi0kffq+EM1oRWFOAo3K5 araYJax10S8AaHEW3gI0zL5K9Kyf1qZsx+0lZijwlzOB6biUcD5s/DKjD/r42IRFtdRIXE8SURSQo BFd+gMzfpoXSvssQBdqfBLE4AuNEH+KZ1eMYgIz5Eej6HpfF3sI1vWaZorKK8xdfLpjRiomVIixSG WmBg2nzB85AC+B953wGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6ZVt-001rjC-LX; Thu, 22 Jul 2021 14:17:25 +0000 Received: from coyote.holtmann.net ([212.227.132.17] helo=mail.holtmann.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6ZVp-001riV-FV for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 14:17:22 +0000 Received: from smtpclient.apple (p5b3d2eb8.dip0.t-ipconnect.de [91.61.46.184]) by mail.holtmann.org (Postfix) with ESMTPSA id CD78ACECDD; Thu, 22 Jul 2021 16:17:12 +0200 (CEST) Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH] Bluetooth: btusb: Fix a unspported condition to set available debug features From: Marcel Holtmann In-Reply-To: <20210709134625.1235015-1-jun.miao@windriver.com> Date: Thu, 22 Jul 2021 16:17:12 +0200 Cc: matthias.bgg@gmail.com, Johan Hedberg , Luiz Augusto von Dentz , Bluetooth Kernel Mailing List , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-Id: <3A8EB08F-C6D1-4B92-B72B-265C49DC5940@holtmann.org> References: <20210709134625.1235015-1-jun.miao@windriver.com> To: Jun Miao X-Mailer: Apple Mail (2.3654.100.0.2.22) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_071721_708553_0E05D351 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jun, > When reading the support debug features failed, there are not available > features init. Continue to set the debug features is illogical, we should > skip btintel_set_debug_features(), even if check it by "if (!features)". > > Fixes: c453b10c2b28 ("Bluetooth: btusb: Configure Intel debug feature based on > available support") > Signed-off-by: Jun Miao > --- > drivers/bluetooth/btusb.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel