From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F9EC65BAF for ; Wed, 12 Dec 2018 09:53:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A42320849 for ; Wed, 12 Dec 2018 09:53:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CDQDlLu/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="hn6s3Fs/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A42320849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cdE5SNxd0XaqZ+pq4AZs52MEtKDE4x/9QgDxnNPqmSk=; b=CDQDlLu/kcCxO0 8ZYdvYFvJFhYrsdpwbbLoe9HDs+n/HMl/yEs5XI7AVo9UVqtUiniP+t+h0EXUeKGKbyd8QLHrsHNl GKONWvT4BIS0VVVUYVJXJ8/LOJK5ux4GjEE99lAR4JOn3pPxj9iWM6aTcHHkRhxtSqLNjhGgY05vM 8LRRHOFYDeSvN2H407h4Hzf6eBRjvqAvSn6aEUM1snPpvQH62k5Opvy8dphRKu5HBtw1Kb2BpId9j H31aGe1hitH+EnD1/QLC1AfQG5czMWZd7FJVYsD9/wO51kCdssxDjn/dWOXMRJJA29NaQUZ4lVE86 vSEN1FbJisqS9zYg3PhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX1Cu-0005M0-Sz; Wed, 12 Dec 2018 09:53:32 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gX1CA-0004Uk-8t for linux-arm-kernel@lists.infradead.org; Wed, 12 Dec 2018 09:53:30 +0000 Received: by mail-wr1-x441.google.com with SMTP id t27so16981939wra.6 for ; Wed, 12 Dec 2018 01:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nv8bbRUzaZfQDsS8yEcIj3gOlk8xcibqLVUbMTOOInI=; b=hn6s3Fs/vTQPdf24mHkDcXC2Hbj1+0alDqmBCHE1+3f3rwYM+PbHVWpykJSlF9/SNY gRGKmmafyODbDSwgXUh19ioM3fuC/8ypjRe4wao2ubIcTI9rmNkUa5uKqUMW+WFqvcxm A2nyY7ed0QHqQojroBRQ6Px0WwkA6g4drb925NFSYZQ+8elIenH4O4XHDKGIwolnJhiU ABnhQEf5Zp+10qWKJ5/PqSlJu2Y62A/czQAYQqwe88vFwI3S1hGCBz+gM3HVBGjNTFdg SOnd1sjVKW6ttvblIi+GScP6eYSHZECmc6B8REPqaaNPsq4FutqeHGMVB2AUl6UVK5o8 v+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=nv8bbRUzaZfQDsS8yEcIj3gOlk8xcibqLVUbMTOOInI=; b=bZNMB/wnLpQDDZDE4rmuVzLzimdfpEMS4ZKDuANGsldhG8KrgHTxTFdJIDDatNGP/J enfrAaFD64vqYVNcf7yse8k81hUjYqeIdjb/RWDm9JACWUjLhQ2eqkH2g6O4QiHgK7z4 DHkFAIJs514sCP5+yNRs0zugd8k7kpAYFPeAZAx1Ke2gGjYupyaNVgmmf9buhMpKr8+4 nBsTzTPuHyGD+2J96FtuGLHb+NTSV2s8Tx28B/ojzCjLg3ysGlP9BV1qbo5/7e7lOh7/ oKUo7yfMQHxLPjLVcq77eDDk7pLcdQd+iukSRrVcj5Ph1h/8iE8AgCRd/vdYwiLdD/RI HQ/g== X-Gm-Message-State: AA+aEWZM+/+57eY6OloAAS9hUYbOYcoOuLUEHXFbGAKN/QQjmE1uh9+t SMwiViBYecJyua1cb7v1x4FBrZxNvF0cwQ== X-Google-Smtp-Source: AFSGD/VHzTlTXbjrVTR5xJoi4oFPqYWwRPJmN0zGrViJZFr3TL31IG7c7Yri1KPawuhFEVGTz4N4nw== X-Received: by 2002:a5d:65ce:: with SMTP id e14mr16110339wrw.150.1544608354032; Wed, 12 Dec 2018 01:52:34 -0800 (PST) Received: from [10.1.3.173] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id i192sm2420979wmg.7.2018.12.12.01.52.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 01:52:33 -0800 (PST) Subject: Re: [PATCH v2 0/3] ARM: dts: meson: add the APB/APB2 busses To: Martin Blumenstingl References: <20181208165025.27689-1-martin.blumenstingl@googlemail.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwE0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAcLAXwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8g Organization: Baylibre Message-ID: <3aad3554-9320-e356-c78d-5dec0cccb380@baylibre.com> Date: Wed, 12 Dec 2018 10:52:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181212_015246_819940_B0CEDFF9 X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, khilman@baylibre.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/2018 23:09, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Dec 11, 2018 at 10:16 AM Neil Armstrong wrote: >> >> On 08/12/2018 17:50, Martin Blumenstingl wrote: >>> This adds the APB bus on Meson8 and Meson8b as well as the APB2 bus on >>> Meson6. This is preparation work for adding the Mali GPU which is >>> located on theses busses. >>> >>> Meson6 seems to have it's APB at 0xc8000000 instead of 0xd0000000. The >>> region at 0xd0000000 is called APB2 or A9_APB and it has a different >>> size (256k) compared to Meson8 and Meson8b (2M). >>> >>> Addresses and sizes are taken from the Amlogic 3.10 kernel sources: >>> - Meson6: [0] >>> - Meson8: [1] >>> - Meson8b: [2] >>> >>> >>> Changes since v1 at [3]: >>> - re-send the patches but this time don't include the old patches >>> which still had a typo in the patch description (ABP vs APB) >>> >>> >>> [0] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson6/include/mach/io.h#L61 >>> [1] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8/include/mach/io.h#L53 >>> [2] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8b/include/mach/io.h#L53 >>> [3] http://lists.infradead.org/pipermail/linux-amlogic/2018-December/009424.html >>> >>> >>> Martin Blumenstingl (3): >>> ARM: dts: meson6: add the APB2 bus >>> ARM: dts: meson8: add the APB bus >>> ARM: dts: meson8b: add the APB bus >>> >>> arch/arm/boot/dts/meson6.dtsi | 8 ++++++++ >>> arch/arm/boot/dts/meson8.dtsi | 8 ++++++++ >>> arch/arm/boot/dts/meson8b.dtsi | 8 ++++++++ >>> 3 files changed, 24 insertions(+) >>> >> >> Reviewed-by: Neil Armstrong > thank you for taking the time to review this! > >> But frankly I'll squash the meson8/meson8b patches with the mali node patches ! > I didn't do this because I realized that there are different busses > between Meson6 and Meson8/Meson8b. so I wanted to have a commit > message which describes this. > if you prefer I can still squash the Meson8 and Meson8b patches into > their corresponding GPU .dts patch but I would like to keep the Meson6 > patch (as I'm not planning to add the Mali GPU until someone can > actually test it on that SoC) Yes this is what I was thinking actually ! Neil > > > Regards > Martin > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel