From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25581C433ED for ; Mon, 3 May 2021 14:32:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E49B611AD for ; Mon, 3 May 2021 14:32:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E49B611AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2Iwih13ZFAzPxpX2v7e8HjwyOQyN9E7Ggs63eu3xOK4=; b=RiKKir0hbgejOz7uvzq/lGQxJ CKMVyQ7Ig5pX4g51EakwAWL8K/s4G3F1knqFM4dkrCK/F3U7/zk2HRXtEWSeWv7h21rJ3bkUVbC/W QAj6NGwPfPWAsgDw1xkJJlbBqfkJcCDLLHpSiuW/+oDMKBSt/aBLqce14nb7qTIxckyKOITmNrBXy G+g4s+0aR6zoQRx35olIPotwII+Zq22ARyIYd/8PmsR4JtE53NEW2JbGU73Z7re5YEw6o9P2HJcJp hwcibTsWvxUarP61WDTebpayAIzWXx60kgkfobgNMUOyLRga9yvU96hDSlLxHxKwUT6y4Bf2S+1RN T/ADCvn1w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldZaO-00E4As-CQ; Mon, 03 May 2021 14:30:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldZaL-00E4AT-Cv for linux-arm-kernel@desiato.infradead.org; Mon, 03 May 2021 14:30:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:Date:Message-ID:From: References:Cc:To:Subject:Sender:Reply-To:Content-ID:Content-Description; bh=k0XzSTSuTQYjUScgNLZ+70L+d3HY3s5BjUlQFLx9vCY=; b=Q+ZSeA+2Un6Ro7xHqkFOEluCJA 7F///1mPb2Iaq0I19AdVneGtCU64Dc3WXDLbAAiMwVANoxCmvoTxwnLkuI8kyq8x5jNDPPC8p9mQS eNi/pDv4h5UC3RJbaq7abqF9FNEBX0pLszu3RbEzBJCacWWduL33j2pAopx7TVKvWBvUmEBVWmSgp TQAEibZ+F5x5HnivpuL5hlHjCt4Q47QbbYuixu5UV2gpxgjP0PR7lxyztIL55uj+ibofViNLRZb9v OSNIiZDvphZjBGMU2WTXZIX95EA/qUUE4VOLDqq5/vQkf55ZAR06cFyzZWr7bxb/yFI1eFOYqTlPn aOB+FdsQ==; Received: from mail-he1eur02on0704.outbound.protection.outlook.com ([2a01:111:f400:fe05::704] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldZaI-0037se-K9 for linux-arm-kernel@lists.infradead.org; Mon, 03 May 2021 14:30:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JS/CAUwuIPGMrlJ7R3SxdrDAiHeF9x9F4J4Nkn4vQo9kx2lCilxF8LgkiXomSCI95MNm6HyuEjYf4XaetyTkbmZVbKsch9M2Wdjb6Q3XmBVFikZt0HIYGFvll03QqodlLtE4QCK5oEzQhv5eghBSFdDprE1KL4LglBfAASLNWQ+oTeCPh0+xWHCppcQJcR3QyenMsrb08m7xKxDiDBkTj+EyhcDm/z7upq2viObM8fCr4qEzd5px0MBUgVy+vJDj9Y/bNJ54kKGFTR0+0qXGL5f1+IdEXzGwT5H3Akw9A2Se+t2buOxA61mmGPEIZYL1GAekUwys7wpSN0FK4CCScw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k0XzSTSuTQYjUScgNLZ+70L+d3HY3s5BjUlQFLx9vCY=; b=foXpR4SOGNphgcr/LNriQL639SQe4HcLbV/XiEV4qif65jd40aK3Ih2ArnIhDCBCZ6eJ0xdJGzydM+OUblw8dLPB5TXqXTER9HFRrA8LaMEQM5wSSH77eSTwlj1A8bPN9deZ0JyTCVhE64HfqZ6m+clfKvWnlXayXkgMacU7cusEAoax2Czp4605k/VdIvdOR2wpkBiwD8+EH2EcAwM9Mpfhzvmz2i0Uy3PBBWavQtTRbqNYXe7L9BUiBCYJa4tFc69zAhYQ5CebenaAMyAH0tPHk0sWI5xXfKODCGs0j3OLGQJC0I3Ae63DsqSlLFmJTrf3swxar/3++jY+0jdVrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k0XzSTSuTQYjUScgNLZ+70L+d3HY3s5BjUlQFLx9vCY=; b=E7hz3SFnsYTQYssrw5NlGnXsnuton0D3zlDlIPid/HNvdG18y1AawpvP4EHA8BnNl5wL63+/ylWQBFT4CwsYYp1CQ8FdIiorhtD3t2GZp6DLrHZk1f44A0y3FU7dwJJXiMyQYdd8PTWGRYZPKr9iYsPKOMhNof4g2vtzkT+J8Ls= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=kontron.de; Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) by AM0PR10MB2068.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:4f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.38; Mon, 3 May 2021 14:30:01 +0000 Received: from AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::3d8a:f56b:3a0c:8a87]) by AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM ([fe80::3d8a:f56b:3a0c:8a87%7]) with mapi id 15.20.4087.044; Mon, 3 May 2021 14:30:01 +0000 Subject: Re: [PATCH 09/16] soc: imx: gpcv2: add support for optional resets To: "Peng Fan (OSS)" , robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, l.stach@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, aford173@gmail.com, abel.vesa@nxp.com References: <20210429073050.21039-1-peng.fan@oss.nxp.com> <20210429073050.21039-10-peng.fan@oss.nxp.com> From: Frieder Schrempf Message-ID: <3caab947-4e47-a11f-e482-bb1250a3efc5@kontron.de> Date: Mon, 3 May 2021 16:30:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <20210429073050.21039-10-peng.fan@oss.nxp.com> Content-Language: en-US X-Originating-IP: [109.250.134.29] X-ClientProxiedBy: AM0PR08CA0010.eurprd08.prod.outlook.com (2603:10a6:208:d2::23) To AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:157::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.10.27] (109.250.134.29) by AM0PR08CA0010.eurprd08.prod.outlook.com (2603:10a6:208:d2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.29 via Frontend Transport; Mon, 3 May 2021 14:30:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c7d7319-b3a2-47d2-ad85-08d90e3fefb4 X-MS-TrafficTypeDiagnostic: AM0PR10MB2068: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jlwxinihYqpXL68N9A6x0bMlOCZrCuYSBKiCkzUJJINptX0ERg0K+J0dBc9PdDw2betQpJLeg+/rJHzZB/XswFoB01HUhLFH8Tg50xLF0i5mz8+zXGNPXcO9t+lSAf/VpinhEkXfSTglP2hfvlmLrOUXVfVrGh/wN21xgJdFz8d+IVwVbi2X0xi8CaE1jweyjJla3PBuaMYShr/lb+duI9R91Px/vEwStD8MS2AreO7283EGGJYFRlg1KxobDPhr7I+ZjTeC494R5C+agV6GCbSKeKExXDEPFoIv7l5dgZXCBWLOzSmrpVthgUxun2Rv0x31yjp+cpOuGJnLZX34ukfYvUryUTBFlod0HujkJkm8Xe2/f2szYj67JftS6qremzFVoc/NZuXZEZK03NjNe+CfZPtBdpwZ6TdsNTFwzofmLzQ4+vy5buqRQZ2ypwjjkIL1dLRpSABkQrzKQ7099rRvsqlYCoOBNuAIy0L/VPWn366/T8/fIqNuMXUWwIR4ZDHxOnQaZ2/PgviIr2OnR9CwBbEWNg2KFBxZoNU6wEmFFVzxq98xSml6GabLXmsHGCPDY8ZgRLqA8V81rdjTKJDwwr0t6A2giga2/mpkhCI8U23hx2oE9OTaKm7QmQJ4VR0LS1kUuQKjIjBJ5elBssmj7Q+58b220m1ookXcNy8TtolKLkk2NH/cczcjENAL X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(396003)(39850400004)(346002)(366004)(136003)(376002)(956004)(38100700002)(31686004)(2616005)(8676002)(16526019)(186003)(4326008)(478600001)(2906002)(66556008)(66946007)(66476007)(26005)(7416002)(83380400001)(31696002)(53546011)(36756003)(16576012)(6486002)(5660300002)(316002)(44832011)(8936002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?eEtKZHBXclBaSTM3eU1LWm1IUHkwNUZzRjFOcHJzWWpvYnk3QTd5NUc4cXg0?= =?utf-8?B?RWNCQU9oNVJyRWRialRKRWhPVEM5K2I5UWJ6Rm50VUZkajRqNzZ2MWpITmlu?= =?utf-8?B?VWtjZElyMVhpTTJrMmQ4T3hwang5a1BSR2NpUm5RRFh1K1l1SSthdGlwWXZJ?= =?utf-8?B?YmJqRUd6V1RNL1A5MC9KbFhERlJGTVpNaG9kTy9sWHFoT1ExUWFwTkFVS1hw?= =?utf-8?B?aVh3Vk43eW8xSlhVUUtOVm43bStidUxlb1dzYTVsVHNsR1VpTE5vU3kveCtr?= =?utf-8?B?UUlCK0p4UUtOWnVKeEJPRmxOaUcwS3BBYUNGTjhQeURpdHd0Z3VEdGdGK3dk?= =?utf-8?B?dVFtdFNrYW5DWldIT2dIVWtkc2pFYXhpNVVPMW9tYzVGTFByWVdFQlY4cE5p?= =?utf-8?B?bkdBT0ZYUkdCVSt0OEhMbmFnayszeGhKZTkyUTZpeitZeEVDakVnbjNpTUVC?= =?utf-8?B?NkFQYVo1OUZWLzdra3RSV3BKYTZtVVJrS0F6NFlGNVg0U25XZUppVnNqSlBk?= =?utf-8?B?RGNZMHg0MkdOR3N0WmtkRmN3Z0pKK1pOMzVwSkRzRXk3NnQ3OWpxbVNuazY1?= =?utf-8?B?ZHEyT0lZNWEwU1BKVnJpN1RuSi9GbUFuYW5hMDVDTnhZc1pKc2cvTHF2Nko4?= =?utf-8?B?aWhYZWJJeVZueWJ5ZXRFWDB4M3dXNThvckt4K0pYelpadTFTL2NFQVhYSHEv?= =?utf-8?B?dEFnd25PbkRyQkplalB5cytpZWVVYVVMQ3VINGU0bHVqTmRta21vMGRoemJt?= =?utf-8?B?UTJXSVJtbUl2aUNwVFdQMnVjb3RIMHhPRUlZdkFFbDU3SndvK2xTdjJXTDJI?= =?utf-8?B?dDcrdGRtQmduSEhxWDU1bXczQlhJZE52ejNLR1JheEVGalhQNlUzK3UvNlly?= =?utf-8?B?SC81cXpZdE9ieTRkdWJlWk1mSWcrUzhlVVpCQWpYM2MyUU5CMXpYWVdnNUtD?= =?utf-8?B?bVM5bWhleGpmbHdRbzgzU1dua1JmdzRBbU0wc0VySFZQSTZERVFDaWMvci9j?= =?utf-8?B?WHU0S1pST3FsbDlpbjRKMmd6ZDBtWDUvMXBmQzdQWERaNks5eEQ1Q1BRc2Rr?= =?utf-8?B?UHNHbjhZbXN6Mkk0MnVVWTF2MUhlbWgvdGU5QlVNd24yNVA1c3BvSDJyNGdQ?= =?utf-8?B?Tmd1RExyUFBRa2VDTTFkU3BveXFoTWdieXY0Wkg4SlVDekV5ZDJ3UmNSRW9p?= =?utf-8?B?c3pXeWErZzY4ZEh3d1NpbG5UL3BRNjM4YkVadWIvR3lmanpMWEtxZG9jb3Ur?= =?utf-8?B?SnpjNmVPa0pOYWFBTnlReTVWWXBmR3ZkcEhHa2dRdHozNFhoM1Y3dmRPT3VY?= =?utf-8?B?QWdvZE1zT2JHVk5JcUpnOGhiNUV2Z2hJRkZHRUNmRkxiWHlWMzRhd2lZYVpX?= =?utf-8?B?QmZRQjJ0d2xWRGRqc2orNnNXNjZ0Smgrb2dqQnptYk04U1NpTUI1TzI5UDU2?= =?utf-8?B?Q1VibDBuWEkrcEhyRm9vR0RnT0pMcEVxMDVJdDNUZ200SmM2Mng0SVJsODZp?= =?utf-8?B?RG9oRjNrOEtpaDBIaFFBSHQxaTRZdW1zQjQzcWpOU3Zsb2dlbU5JeVpITTl3?= =?utf-8?B?MUxhQkRmWEh6bzlMbFB2WFFPSkEwSEdJL3J2MXJoc3dlYXlUSVlSTU9GdUlI?= =?utf-8?B?Z1JIVDJIYXA5cU1SaU9BSEl4R25KSXVhKzdCd1JqaFkweDZ4WmtkbU50ZGRu?= =?utf-8?B?b3B0b0ZVd3Z5Y2ErcXJvNDRhbUYwdi9Rbk5BSks3aU5KelFuT1ZXbm9xcHFX?= =?utf-8?Q?QtEjWzIx2Oxagt0jTrDmmhikxmc3443m7mPxfWM?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: 8c7d7319-b3a2-47d2-ad85-08d90e3fefb4 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2963.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2021 14:30:01.8478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: izHpEgftTvVomk4u3RtBZri56GcdzKY3nUUuprP1NIdm0/7zwozd+YTSnQ1B+ncNgg39hk0uRtoQlkDYbLzYeKBFdeIQf01yxzZKXRU8PeM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2068 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210503_073006_699074_047A9173 X-CRM114-Status: GOOD ( 24.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29.04.21 09:30, Peng Fan (OSS) wrote: > From: Lucas Stach > > Normally the reset for the devices inside the power domain is > triggered automatically from the PGC in the power-up sequencing, > however on i.MX8MM this doesn't work for the GPU power domains. > > Add support for triggering the reset explicitly during the power > up sequencing. > > Signed-off-by: Lucas Stach > --- > drivers/soc/imx/gpcv2.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index 640f4165cfba..4a2c2a255d1a 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -108,6 +109,7 @@ struct imx_pgc_domain { > struct generic_pm_domain genpd; > struct regmap *regmap; > struct regulator *regulator; > + struct reset_control *reset; > struct clk_bulk_data *clks; > int num_clks; > > @@ -163,6 +165,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > goto out_regulator_disable; > } > > + reset_control_assert(domain->reset); > + > if (domain->bits.pxx) { > /* request the domain to power up */ > regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, > @@ -185,6 +189,11 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > GPC_PGC_CTRL_PCR, 0); > } > > + /* delay for reset to propagate */ > + udelay(5); > + > + reset_control_deassert(domain->reset); > + > /* request the ADB400 to power up */ > if (domain->bits.hskreq) { > regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, > @@ -531,11 +540,17 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > domain->voltage, domain->voltage); > } > > + Spurious blank line. Otherwise: Reviewed-by: Frieder Schrempf > domain->num_clks = devm_clk_bulk_get_all(domain->dev, &domain->clks); > if (domain->num_clks < 0) > return dev_err_probe(domain->dev, domain->num_clks, > "Failed to get domain's clocks\n"); > > + domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev); > + if (IS_ERR(domain->reset)) > + return dev_err_probe(domain->dev, PTR_ERR(domain->reset), > + "Failed to get domain's resets\n"); > + > pm_runtime_enable(domain->dev); > > if (domain->bits.map) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel