From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C647AC433E0 for ; Tue, 11 Aug 2020 22:18:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92DCB206DC for ; Tue, 11 Aug 2020 22:18:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZQl8Cxt2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ljaB4/dB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92DCB206DC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+rJKcfgJljPz3tgHtIUkQmRbR9k3cXK2DZ+WbUDQG/M=; b=ZQl8Cxt2aSS1lcNjbls5ARZ2F guCJWdbQMpFHhj85zCf/U7tQFRLyAnzfGhSGhqg1bQEt28mXRkzSE7+uAZzdQU0bQNjJRssqFZfld HW3qTfWMmSXG4XSZW9S1G/3AWU9rNAHN1OubAXLQqBI/ARw6qk+xaxCoNF3Lp5F2mxFE37kMr/gdA GX9ixaeVA4Y6M1G9OMDEwIY4vrnx6d997EMH8gLfMvaGOIRC6RfBbM+Ex+RbxIybSRGTu3ndk3WEq LUcwvNpslzHsvUxAE6Xj48cAdzWnCFsiSLDvNjKydteJPpYVFWot53yoQLUTZiq47Wb12nOaPSSE2 b9IfX6rIQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5cZW-0005LG-HO; Tue, 11 Aug 2020 22:16:42 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5cZT-0005Kn-Ng for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 22:16:41 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 07BMGbgC063567; Tue, 11 Aug 2020 17:16:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1597184197; bh=BcWdkWNK3kpKapQgO0Xm+UzannjeCmDE1NXrFwsfTB4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ljaB4/dBwG/aLQBpo6mo2P87hLFTB+ZATdNP2lBZmqAiYqbsRLkBmZ9GZr9LW1zV3 u8mYH3RcQlEpvmGrZnc4/da3TBOWUVkiRoDE63824bSl7V4kx6P1sVmkaOmdm8cxQd 4k5QqHRZiE9iFz0jSGenhHpyEMSEWELXyk0ztnRw= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07BMGbl1057518; Tue, 11 Aug 2020 17:16:37 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 11 Aug 2020 17:16:37 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 11 Aug 2020 17:16:37 -0500 Received: from [10.250.38.37] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 07BMGaYB054572; Tue, 11 Aug 2020 17:16:36 -0500 Subject: Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver To: Pavel Machek References: <20200722153146.8767-1-dmurphy@ti.com> <20200722153146.8767-3-dmurphy@ti.com> <20200811105413.r2m2f7bubuz55rrt@duo.ucw.cz> <935119fa-6d1f-8e99-51f9-87966b4d03ad@ti.com> <20200811220109.GA9105@amd> From: Dan Murphy Message-ID: <3ce38a31-a4f0-4cd7-ad09-6bdad27e6756@ti.com> Date: Tue, 11 Aug 2020 17:16:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200811220109.GA9105@amd> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_181640_116765_50ADAF2E X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek.behun@nic.cz, jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Pavel On 8/11/20 5:01 PM, Pavel Machek wrote: > Hi! > >>> Actually... This is quite impressive ammount of code to >>> zero-initialize few registers. Could the regmap be told to set the >>> range to zero, or use loops to reduce ammount of code? >> I am not aware of any regmap calls that will set a range of registers to a >> certain value. >> >> Well it depends on where we want to create the default cache values. >> >> Either we run through a for..loop during driver probe and delay device start >> up or we keep the simple arrays and increase the driver total size. > for loop will be better. > > Plus, REGCACHE_RBTREE is very likely overkill. Well if I eliminate the reg_cache then I can eliminate the defaults too. Dan > Best regards, > > Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel