From: Neil Armstrong <narmstrong@baylibre.com>
To: daniel@ffwll.ch, Laurent.pinchart@ideasonboard.com, sam@ravnborg.org
Cc: martin.blumenstingl@googlemail.com,
dri-devel@lists.freedesktop.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] drm/meson: rework encoders to pass ATTACH_NO_CONNECTOR
Date: Fri, 12 Nov 2021 14:24:25 +0100 [thread overview]
Message-ID: <3e0e5a2f-a81b-dcba-e379-4786c4a5de7b@baylibre.com> (raw)
In-Reply-To: <20211020123947.2585572-1-narmstrong@baylibre.com>
On 20/10/2021 14:39, Neil Armstrong wrote:
> This serie finnally reworks the drm/meson driver by extracting the encoders
> in their own file and moves to bridge-only callbacks.
>
> This permits passing the ATTACH_NO_CONNECTOR bridge attach flag and finally
> use the CVBS & HDMI display-connector driver.
>
> This will ease Martin Blumenstingl writing the HDMI transceiver driver for
> the older Meson8/8b SoCs, and sets the proper architecture for the work in
> progress MIPI-DSI support.
>
> Finally, this serie will path the way to a removal of the device component
> and use the drmm memory management.
>
> Changes since v2 at [2]:
> - patch 1: no changes
> - patch 2: added martin's ack
> - patch 3: moved ->enable & ->disable to atomic, added sam's & martin's acks
> - patch 4: added martin's ack
> - patch 5: added martin's ack
> - patch 6: moved ->enable & ->disable to atomic, added martin's ack
>
> Changes since v1 at [1];
> - patch 1: added sam's review tag, fixed include order, fixed doc wording
> - patch 2: added sam's ack tag, switched to dev_dbg()
> - patch 3: moved mode_set to atomic_enable, removed DRM_DEBUG, fixed include order
> - patch 4: added sam's ack tag & applied to drm-misc-next
> - patch 5 & 6: added sam's ack tag
> - patch 7: added sam's review tag, stopped saving connector, moved mode_set to atomic_enable,
> added missing atomic state callbacks, fixed include order, switched to dev_dbg/dev_err
>
> [1] https://lore.kernel.org/r/20211014152606.2289528-1-narmstrong@baylibre.com
> [2] https://lore.kernel.org/r/20211015141107.2430800-1-narmstrong@baylibre.com
>
> Neil Armstrong (6):
> drm/bridge: display-connector: implement bus fmts callbacks
> drm/meson: remove useless recursive components matching
> drm/meson: split out encoder from meson_dw_hdmi
> drm/meson: encoder_hdmi: switch to bridge
> DRM_BRIDGE_ATTACH_NO_CONNECTOR
> drm/meson: rename venc_cvbs to encoder_cvbs
> drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR
>
> drivers/gpu/drm/bridge/display-connector.c | 86 ++++
> drivers/gpu/drm/meson/Kconfig | 2 +
> drivers/gpu/drm/meson/Makefile | 3 +-
> drivers/gpu/drm/meson/meson_drv.c | 71 ++-
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 342 +-------------
> drivers/gpu/drm/meson/meson_encoder_cvbs.c | 284 +++++++++++
> ...meson_venc_cvbs.h => meson_encoder_cvbs.h} | 2 +-
> drivers/gpu/drm/meson/meson_encoder_hdmi.c | 446 ++++++++++++++++++
> drivers/gpu/drm/meson/meson_encoder_hdmi.h | 12 +
> drivers/gpu/drm/meson/meson_venc_cvbs.c | 293 ------------
> 10 files changed, 881 insertions(+), 660 deletions(-)
> create mode 100644 drivers/gpu/drm/meson/meson_encoder_cvbs.c
> rename drivers/gpu/drm/meson/{meson_venc_cvbs.h => meson_encoder_cvbs.h} (92%)
> create mode 100644 drivers/gpu/drm/meson/meson_encoder_hdmi.c
> create mode 100644 drivers/gpu/drm/meson/meson_encoder_hdmi.h
> delete mode 100644 drivers/gpu/drm/meson/meson_venc_cvbs.c
>
>
> base-commit: f6632721cd6231e1bf28b5317dcc7543e43359f7
>
Applied to drm-misc-next
Now https://lore.kernel.org/all/20211029135947.3022875-1-narmstrong@baylibre.com/ has been applied, we should have no regression.
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-11-12 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 12:39 [PATCH v3 0/6] drm/meson: rework encoders to pass ATTACH_NO_CONNECTOR Neil Armstrong
2021-10-20 12:39 ` [PATCH v3 1/6] drm/bridge: display-connector: implement bus fmts callbacks Neil Armstrong
2021-10-20 12:39 ` [PATCH v3 2/6] drm/meson: remove useless recursive components matching Neil Armstrong
2021-10-20 12:39 ` [PATCH v3 3/6] drm/meson: split out encoder from meson_dw_hdmi Neil Armstrong
2021-10-20 12:39 ` [PATCH v3 4/6] drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR Neil Armstrong
2021-10-20 12:39 ` [PATCH v3 5/6] drm/meson: rename venc_cvbs to encoder_cvbs Neil Armstrong
2021-10-20 12:39 ` [PATCH v3 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR Neil Armstrong
2021-11-12 13:24 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0e5a2f-a81b-dcba-e379-4786c4a5de7b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).