From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA7E0C433ED for ; Tue, 18 May 2021 17:08:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29E36611BF for ; Tue, 18 May 2021 17:08:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29E36611BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G5JeV03fXmZtYlyj6Lj8u4QdGDeAJDRNyksqw34ZIac=; b=H+LvIlPTNx4GzYIF3Hbg+Dwfn nn+pThJr9m5aix95X7pKx4NLIKKbMYiVV6Oi0sMuvpGnWKL/DJuYynssC9mlXSDDljp/hq3VRQ1ZY Mdu4RMh9LgBs2hali63WWfOeAKUZK00BUjx6FV/W0+K28XeVHDsNK8Pu7uxtV+5a9nueAuD9F1+Qo G3FPxmff1Qjcfb+0A+Vd1shcOjV7hXI2Pestxh6w6qurrreZMbMt2bZ8PIT9LUj9l57OTg3rQqMjq XO2D9uRRFBSS0YBGQnRc9R9TKAq1en4URe94bIh/hWcWSA38hO2eBkctXqKPUYYbsvgsx4ZPXulyu gkndt5DxQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj3Ax-001RPU-GA; Tue, 18 May 2021 17:06:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj3As-001RP9-EL for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 17:06:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=sRVnXnlv2Kygi4VkDrpByRlu3WM07w2AUJMWm4+wmKg=; b=bKigfWRcrvIKA4GSciNCZ/Exzj Eert0WbhWhwpz/jxEoH6BbQ34GgdovViqZ1ERZxb/PYQ4S0DDe18oXA2Foq2Gg7B+i6EZH+eKSrg/ 4zAZiFsieUJog59Vw/PTfgMnTfMV50YoVARbjy/DHjYlfX4/NoSTgh9C42INFxH1E657rhDOMVqtu lj69wTP8x+Y98gxj6l0ITNjYfKuInnDMzEnflsJ18/vx1dvGpRqyUnxDR0GxXwloprzoY64v1UdRK 6goKRkjnrWdsgPBx4/tpRBsNiftRs5zysgN3OGl1AfNynbbQOsdjdrq9r71FEXL6Jrc5jR+NV76NY ZMciymxQ==; Received: from hostingweb31-40.netsons.net ([89.40.174.40]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj3Ap-00EpRv-9N for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 17:06:29 +0000 Received: from [77.244.183.192] (port=62022 helo=[192.168.178.41]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lj3Aj-000CdH-Ny; Tue, 18 May 2021 19:06:21 +0200 Subject: Re: [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Jingoo Han , Gustavo Pimentel References: <20210517163623.GA21579@bjorn-Precision-5520> From: Luca Ceresoli Message-ID: <3e61b95e-f3e4-b5f2-d87f-eec42bcd630f@lucaceresoli.net> Date: Tue, 18 May 2021 19:06:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210517163623.GA21579@bjorn-Precision-5520> Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_100627_514901_0108F24B X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Bjorn, On 17/05/21 18:36, Bjorn Helgaas wrote: > On Mon, May 17, 2021 at 05:41:17PM +0200, Luca Ceresoli wrote: >> This is an series of mixed improvements to the DRA7 PCI controller driver: >> allow building as a loadabel module, allow to get and enable a clock and a >> small cleanup. >> >> Luca >> >> Luca Ceresoli (5): >> PCI: dwc: export more symbols to allow modular drivers >> PCI: dwc: pci-dra7xx: make it a kernel module >> PCI: dwc: pci-dra7xx: allow to build as a loadable module >> PCI: dwc: pci-dra7xx: remove unused include >> PCI: dwc: pci-dra7xx: get an optional clock > > This driver has a poor record of subject lines: > > PCI: pci-dra7xx: Prepare for deferred probe with module_platform_driver > PCI: dwc: Move dw_pcie_setup_rc() to DWC common code > PCI: dwc/dra7xx: Use the common MSI irq_chip > PCI: dwc: pci-dra7xx: Fix runtime PM imbalance on error > > The "PCI: dwc:" ones are fine -- they apply to the shared dwc core, > not specifically to dra7xx. > > The driver-specific ones: > > PCI: pci-dra7xx: > PCI: dwc/dra7xx: > PCI: dwc: pci-dra7xx: > > are redundant and waste space. There's no need to mention "dwc" for > dra7xx-specific things, and no need to mention "PCI" twice. > > We should use the "PCI: dra7xx:" prefix for things specific to this > driver. > > The rest of the subject line should start with a capital letter. The > subject line should contain specific information when practical. For > example, > > PCI: dwc: Export dw_pcie_link_up(), dw_pcie_ep_reset_bar() for modular drivers > PCI: dra7xx: Allow building as module > PCI: dra7xx: Remove unused linux/init.h include > PCI: dra7xx: Get optional external clock > > I would squash 2/5 and 3/5, similar to a98d2187efd9 ("PCI: meson: > Build as module by default") and 526a76991b7b ("PCI: aardvark: > Implement driver 'remove' function and allow to build it as module"). Thanks for the prompt review. I'll wait a few days for any more comments and then resend. -- Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel