From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B7CC48BE6 for ; Mon, 14 Jun 2021 09:30:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9341A61360 for ; Mon, 14 Jun 2021 09:30:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9341A61360 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lucaceresoli.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Lou2nmS3/YO7GPOmKe97o3i4dMo1s/8teLynyZ0vx/o=; b=vsqWsVh3wEoGch3i3KqLZOqQJf Tq8RJG+FDeHCiozy2qpAZFq7MDvtT3xU04Ri9BcdCUj55jOaf8z1nfZMzuaX1MH9IIEyOIl23WnUj XK7+uaTXHgFUNEndTUAv0rDXmTHWZ2PXzCfWMlCcUeL2RQ/4H4xI5mA2XTZsUEUerPWiBeu83ZiMb rqdqHFQsIVZ2Z2GtRHqltXy7HMOLpCaxVUNnI98zvAWmD5oeusZw9KhHeAUycosOFTEedM3jjvHmL jjrSyFymQV6OPjGvsGYBWP54kisLIItjk0NGdzBDnInNRGvJDo/BGjCAtzEPbLH86c4rnw1D4Gt5z 8Wo3eueg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsitt-00DLTZ-6c; Mon, 14 Jun 2021 09:28:57 +0000 Received: from hostingweb31-40.netsons.net ([89.40.174.40]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsitp-00DLRy-5w for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 09:28:55 +0000 Received: from [77.244.183.192] (port=64040 helo=[192.168.178.41]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1lsiti-00079a-67; Mon, 14 Jun 2021 11:28:46 +0200 Subject: Re: [PATCH v3 1/4] fpga: dfl: reorganize to subdir layout To: trix@redhat.com, mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com, gregkh@linuxfoundation.org, krzysztof.kozlowski@canonical.com, dinguyen@kernel.org, nava.manne@xilinx.com, yilun.xu@intel.com, davidgow@google.com, fpacheco@redhat.com, richard.gong@intel.com Cc: linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210611162129.3203483-1-trix@redhat.com> <20210611162129.3203483-3-trix@redhat.com> From: Luca Ceresoli Message-ID: <3e83dee8-4746-b22b-c032-1d73364f9cb7@lucaceresoli.net> Date: Mon, 14 Jun 2021 11:28:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210611162129.3203483-3-trix@redhat.com> Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_022853_434478_18F4C55B X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tom, On 11/06/21 18:21, trix@redhat.com wrote: > From: Tom Rix > > Follow drivers/net/ethernet/ which has control configs > NET_VENDOR_BLA that map to drivers/net/ethernet/bla > Since fpgas do not have many vendors, drop the 'VENDOR' and use > FPGA_BLA. > > There are several new subdirs > altera/ > dfl/ > lattice/ > xilinx/ > > Each subdir has a Kconfig that has a new/reused > > if FPGA_BLA > ... existing configs ... > endif FPGA_BLA > > Which is sourced into the main fpga/Kconfig > > Each subdir has a Makefile whose transversal is controlled in the > fpga/Makefile by > > obj-$(CONFIG_FPGA_BLA) += bla/ > > This is the dfl/ subdir part. > > Create a dfl/ subdir > Move dfl-* files to it. > Add a Kconfig and Makefile > > Because FPGA_DFL is now used in dfl/Kconfig in a if/endif > block, all the other configs in dfl/Kconfig implicitly depend > on FPGA_DFL. So the explicit dependence can be removed. Also > since FPGA_DFL depends on HAS_IOMEM, it can be removed from the > other configs. > > Signed-off-by: Tom Rix > --- > MAINTAINERS | 2 +- > drivers/fpga/Kconfig | 80 +------------------- > drivers/fpga/Makefile | 18 +---- > drivers/fpga/dfl/Kconfig | 83 +++++++++++++++++++++ > drivers/fpga/dfl/Makefile | 16 ++++ > drivers/fpga/{ => dfl}/dfl-afu-dma-region.c | 0 > drivers/fpga/{ => dfl}/dfl-afu-error.c | 0 > drivers/fpga/{ => dfl}/dfl-afu-main.c | 0 > drivers/fpga/{ => dfl}/dfl-afu-region.c | 0 > drivers/fpga/{ => dfl}/dfl-afu.h | 0 > drivers/fpga/{ => dfl}/dfl-fme-br.c | 0 > drivers/fpga/{ => dfl}/dfl-fme-error.c | 0 > drivers/fpga/{ => dfl}/dfl-fme-main.c | 0 > drivers/fpga/{ => dfl}/dfl-fme-mgr.c | 0 > drivers/fpga/{ => dfl}/dfl-fme-perf.c | 0 > drivers/fpga/{ => dfl}/dfl-fme-pr.c | 0 > drivers/fpga/{ => dfl}/dfl-fme-pr.h | 0 > drivers/fpga/{ => dfl}/dfl-fme-region.c | 0 > drivers/fpga/{ => dfl}/dfl-fme.h | 0 > drivers/fpga/{ => dfl}/dfl-n3000-nios.c | 0 > drivers/fpga/{ => dfl}/dfl-pci.c | 0 > drivers/fpga/{ => dfl}/dfl.c | 0 > drivers/fpga/{ => dfl}/dfl.h | 0 > 23 files changed, 102 insertions(+), 97 deletions(-) > create mode 100644 drivers/fpga/dfl/Kconfig > create mode 100644 drivers/fpga/dfl/Makefile > rename drivers/fpga/{ => dfl}/dfl-afu-dma-region.c (100%) > rename drivers/fpga/{ => dfl}/dfl-afu-error.c (100%) > rename drivers/fpga/{ => dfl}/dfl-afu-main.c (100%) > rename drivers/fpga/{ => dfl}/dfl-afu-region.c (100%) > rename drivers/fpga/{ => dfl}/dfl-afu.h (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-br.c (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-error.c (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-main.c (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-mgr.c (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-perf.c (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-pr.c (100%) You should update Documentation/fpga/dfl.rst too as it mentions "drivers/fpga/dfl-fme-pr.c". This update was in your initial patch 5 so it's lost now, but it really should be in this patch. > rename drivers/fpga/{ => dfl}/dfl-fme-pr.h (100%) > rename drivers/fpga/{ => dfl}/dfl-fme-region.c (100%) > rename drivers/fpga/{ => dfl}/dfl-fme.h (100%) > rename drivers/fpga/{ => dfl}/dfl-n3000-nios.c (100%) > rename drivers/fpga/{ => dfl}/dfl-pci.c (100%) > rename drivers/fpga/{ => dfl}/dfl.c (100%) Same as above. -- Luca _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel