From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3EA6C433E0 for ; Fri, 5 Mar 2021 11:01:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 174DC64FD2 for ; Fri, 5 Mar 2021 11:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 174DC64FD2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KpgXZfvD7tmu/pQZ3Q0E8Qn3mBpeWMSaeDoF6ctvW1Q=; b=JPurBCNkr4EFX87IWcyxW/Mt+ NVqgsj251FptZ+xSsMc2vbDJW3xyI6S5HT8RaY1rI/vEAJHMFCXbe4HdgKoOz/+4wM+2RhV7h/xog 1duXlx7WeIBSvJsPMFc55Rm0DvcE3vc6R1tJn4WFhgNa8kUd3jQCxxwYO6kXxHcUNC2wEcgItANyg DgxsbucO+rKrJVHFH3DmoMApz7OnKx3pf2vaUuJWifkZHV+EKS42xovEWmlB/2z7pq174hFIVdDm8 FrtL6lvol9TiyOVszRSYdgB6R61V0CJ0ql11dUwfBtzGUGHUmoDKEnMQH+4TuuH4DKtNQHqyLdqXP 2RlyD/tqg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI8Ag-00Ef3R-Lb; Fri, 05 Mar 2021 10:59:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI8AW-00Ef0k-PR for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:58:57 +0000 Received: from mail-wm1-f71.google.com ([209.85.128.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lI8AV-0001GC-Px for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 10:58:52 +0000 Received: by mail-wm1-f71.google.com with SMTP id w10so3446061wmk.1 for ; Fri, 05 Mar 2021 02:58:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4aJfVlauewtRE5vCynuYGIqgJwZdZisFk3AW2s1txII=; b=m6MVpphEFektFthF/mhqvK4bHiwo1yBPdta7cxO4AF1jaq9tmZ3GXH9nODLevCFokk nSWFS6WijZgFhoU8+eTbDY8oGetXEl+2va81tqE867NgZ8ruewqrQUowFDgy9/sAUxGn UANYJpvI/7DP4XmYWYVUdGw8A7Wd2Z1FpQT7BHlXGWR354FJT4ebcF+T568qWKWnQAKx jYON+u2WFDXcdrAmXNFIqquovLHW0F5xMnZ9tU3m4b++10Uv7UAY3BXicTlRdzoEvuz+ /qfOxx2Z+NLozLUmLaLLn6HJpC+Zu/Q2mvwchYiSz/tyvQS4MDdAsZm7LrL7TOGo2Loa nvnA== X-Gm-Message-State: AOAM532KjpIBUYkeILDIKZyHop40U5FUzCt1IVO861soNMrRsvmV2mZY 0T9Dhwif9saAiaxwtlyOKvBeNXT9nmAJ2cHMrQvX20YIPszekQQj5x6C2UBK7bjD3LJeX4+r2HE EaeGMI5BgBTXplsPQ8ZSpg0gJzmFodeF0pAqXkkBJ2o/62N5gLD3k X-Received: by 2002:a7b:cb99:: with SMTP id m25mr8423371wmi.64.1614941931427; Fri, 05 Mar 2021 02:58:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmQw4qIFRa6N+eh+U12JE4vYPax7TgkB7xnzrasYQiJvSoeqLGr8BCj354zBBg7bPpy0fgIA== X-Received: by 2002:a7b:cb99:: with SMTP id m25mr8423363wmi.64.1614941931318; Fri, 05 Mar 2021 02:58:51 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id h2sm4309640wrq.81.2021.03.05.02.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Mar 2021 02:58:51 -0800 (PST) Subject: Re: [RFT PATCH v3 24/27] tty: serial: samsung_tty: Add support for Apple UARTs To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , Andy Shevchenko , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-25-marcan@marcan.st> From: Krzysztof Kozlowski Message-ID: <3ed6840e-1c12-4145-c2d5-cb05cac156e9@canonical.com> Date: Fri, 5 Mar 2021 11:58:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210304213902.83903-25-marcan@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_105856_253342_E181E4FD X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 22:38, Hector Martin wrote: > Apple SoCs are a distant descendant of Samsung designs and use yet > another variant of their UART style, with different interrupt handling. > > In particular, this variant has the following differences with existing > ones: > > * It includes a built-in interrupt controller with different registers, > using only a single platform IRQ > > * Internal interrupt sources are treated as edge-triggered, even though > the IRQ output is level-triggered. This chiefly affects the TX IRQ > path: the driver can no longer rely on the TX buffer empty IRQ > immediately firing after TX is enabled, but instead must prime the > FIFO with data directly. > > Signed-off-by: Hector Martin > --- > drivers/tty/serial/Kconfig | 2 +- > drivers/tty/serial/samsung_tty.c | 238 +++++++++++++++++++++++++++++-- > include/linux/serial_s3c.h | 16 +++ > 3 files changed, 247 insertions(+), 9 deletions(-) > Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel