From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DAC2C606C1 for ; Mon, 8 Jul 2019 15:51:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 736CE21479 for ; Mon, 8 Jul 2019 15:51:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E2wpid5N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 736CE21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=03/brph6pEnln/ZklOTX9znvm/+xUQTq3m5Mbke92ss=; b=E2wpid5NZfAVuq dNDImiZKtJy1HL/a9a6Li4C5C+MzYG0Y+cGRmhUouohRhEnoJLbKMlEfBTWnJprbesTr75I0CE4fq rMhgi0S3kaS1bpwBm6qAk+3AOH/RFsR9jZMm4orG+Dfve046rDSVdTfDh+hUbWQqnu+vIQKewMPm/ t+fkj3rP/srZYmpatfsMOVZA4DvaOy3BHK6x11GUGv5anM0mUXXSc1AR/eOl21hKDWSDVYwIk+ue3 6BSb4zwleidQj19x37ehebYHXZhAM3vHcl/JYpUD6GQ1qVfW2PRFax4cyYIKjRGysKnJVR+bpHhRO O/USO0fLWm08/xxbdmyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkVvK-0008NU-6U; Mon, 08 Jul 2019 15:51:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkVuO-0007Yz-QZ for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2019 15:50:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 45F27360; Mon, 8 Jul 2019 08:50:28 -0700 (PDT) Received: from [10.1.197.45] (e112298-lin.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7C5A3F59C; Mon, 8 Jul 2019 08:50:26 -0700 (PDT) Subject: Re: [PATCH v3 5/9] perf/arm_pmu: Move PMU lock to ARMv6 events To: Mark Rutland References: <1562596377-33196-1-git-send-email-julien.thierry@arm.com> <1562596377-33196-6-git-send-email-julien.thierry@arm.com> <20190708151941.GA36116@lakrids.cambridge.arm.com> From: Julien Thierry Message-ID: <3f53256e-7a13-1f2d-4931-0f9a9ac6d60c@arm.com> Date: Mon, 8 Jul 2019 16:50:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190708151941.GA36116@lakrids.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190708_085029_003359_FDB0122C X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peterz@infradead.org, liwei391@huawei.com, will.deacon@arm.com, Russell King , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, namhyung@kernel.org, jolsa@redhat.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/07/2019 16:19, Mark Rutland wrote: > On Mon, Jul 08, 2019 at 03:32:53PM +0100, Julien Thierry wrote: >> Perf event backend for ARMv8 and ARMv7 no longer uses the pmu_lock. >> The only remaining user is the ARMv6 event backend. >> >> Move the pmu_lock out of the generic arm_pmu driver into the ARMv6 code. > > Moving this into the ARMv6 PMU code makes sense to me. > > [...] > >> @@ -502,6 +508,8 @@ static void armv6pmu_init(struct arm_pmu *cpu_pmu) >> cpu_pmu->stop = armv6pmu_stop; >> cpu_pmu->map_event = armv6_map_event; >> cpu_pmu->num_events = 3; >> + >> + raw_spin_lock_init(this_cpu_ptr(&pmu_lock)); > > This needs to initialize the lock on each CPU in order for armv6mpcore. > > In __armpmu_alloc we had: > > for_each_possible_cpu(cpu) { > struct pmu_hw_events *events; > events = per_cpu_ptr(pmu->hw_events, cpu); > raw_spin_lock_init(&events->pmu_lock); > ... > } > > ... which did that for us. > Oops, thanks for spotting that. Will fix it for next version. > Otherwise, this looks good to me. > Thanks, -- Julien Thierry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel