From: Gaston Gonzalez <gascoar@gmail.com>
To: linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com,
juerg.haefliger@canonical.com, rdunlap@infradead.org,
dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com,
unixbhaskar@gmail.com, mitaliborkar810@gmail.com,
phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gascoar@gmail.com
Subject: [PATCH v2 3/3] staging: vc04_services: update TODO file
Date: Thu, 30 Dec 2021 08:31:29 -0300 [thread overview]
Message-ID: <3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com> (raw)
In-Reply-To: <cover.1640776340.git.gascoar@gmail.com>
There are no struct typedef remaining inside vc04_services/. Hence, remove the
task from the TODO file.
While at it, fix the items sequential numbering.
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
drivers/staging/vc04_services/interface/TODO | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
index 39810ce017cd..241ca004735c 100644
--- a/drivers/staging/vc04_services/interface/TODO
+++ b/drivers/staging/vc04_services/interface/TODO
@@ -80,11 +80,7 @@ vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process.
The code in vchiq_bcm2835_arm.c should fit in the generic platform file.
-12) Get rid of all the struct typedefs
-
-Most structs are typedefd, it's not encouraged in the kernel.
-
-13) Get rid of all non essential global structures and create a proper per
+11) Get rid of all non essential global structures and create a proper per
device structure
The first thing one generally sees in a probe function is a memory allocation
@@ -92,6 +88,6 @@ for all the device specific data. This structure is then passed all over the
driver. This is good practice since it makes the driver work regardless of the
number of devices probed.
-14) Clean up Sparse warnings from __user annotations. See
+12) Clean up Sparse warnings from __user annotations. See
vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter"
is never disclosed to userspace.
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-30 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 11:31 [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers Gaston Gonzalez
2021-12-30 11:31 ` [PATCH v2 1/3] staging: vc04_services: bcm2835-audio: " Gaston Gonzalez
2021-12-30 11:31 ` [PATCH v2 2/3] staging: vc04_services: bcm2835-camera: " Gaston Gonzalez
2021-12-30 11:31 ` Gaston Gonzalez [this message]
2022-01-06 12:51 ` [PATCH v2 3/3] staging: vc04_services: update TODO file Dan Carpenter
2021-12-30 13:20 ` [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com \
--to=gascoar@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=juerg.haefliger@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitaliborkar810@gmail.com \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rdunlap@infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).