From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A648EC433EF for ; Tue, 22 Mar 2022 21:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xC2Aive00BaVC9wHVqvtGj5DzUO8DbfG35WL6BmH84s=; b=ALuRKQmaVFRFBq YEDpKuRe8T8qbxura611mn4eJjiLrf0JGaLSXirdCQYtN3Bns9egcHsvDZFHZhfTZbLbuXjk/kOSq 5gNJPm0MO1hIxsv9P8Vc28uYanBRJKGwDVhz+KEhXH0xX+B9w3RVf8X4QAF8S6Mkwu/tu3lo19RMR g87w3Qpja7v5i12xLLiba/hdl5XSGDTVh66IMrluTbJcCWXy7+JIkNXrY/lZhO8KkKOM/JxE8duZX kmDun7hVnhzedIkUU+jf4ZiTdNZkTZGb9BVxYhUsEDGK/WhcJVjfeDhW8rAKYvDI+uHTZQ1c6iRWA 2wh1gZ0ELXto5R3Nen7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWm4r-00CCmp-F0; Tue, 22 Mar 2022 21:30:05 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWm4o-00CClO-4R for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 21:30:03 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9BBAC83B3B; Tue, 22 Mar 2022 22:29:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1647984598; bh=UYycdJVYXZ+3TfiHG7Yw3v4KtwVGkyT5W7RqJn0lWuk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mu7eh1CwoiWow2/EUcRCc/2EsO3Chg5SG4fhBNlSOjxSVyOF7upBr2WMCos/XcoSc 44SC/Q9celfGsVFoHRwP+cpXel+awhTKqjZpU7klP9urIA1REqTHE17dLmFKF8+qCM EI4QP57eBDfU8DYtTD+Skzj72gZtZUiIm6TVnLmoREVB6qL/kRVT2m9GvsKDT25ML0 w5q4mpLEWyPweRvLdbh0PO5ZBJDEAgfPRs1u/NGwIDHgcsjbeBs9Z5QIy/ROmB0i6+ f3gD4qqj8oJHFWukexadC/+4DmzAGwqk1n96v7IL/dKXfhsqsDiqn4ITXUjC0aUh1h 1BFKSQiq5HgGA== Message-ID: <3f7bdca8-0da7-fe2d-7bcb-9768b12bb759@denx.de> Date: Tue, 22 Mar 2022 22:29:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/4] dt-bindings: soc: Add i.MX8MP media block control DT bindings Content-Language: en-US To: Laurent Pinchart , linux-arm-kernel@lists.infradead.org, Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , NXP Linux Team , Fabio Estevam , Paul Elder , Lucas Stach , devicetree@vger.kernel.org, Rob Herring References: <20220322190324.12589-1-laurent.pinchart@ideasonboard.com> <20220322190324.12589-2-laurent.pinchart@ideasonboard.com> From: Marek Vasut In-Reply-To: <20220322190324.12589-2-laurent.pinchart@ideasonboard.com> X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_143002_426059_1444DFBD X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/22/22 20:03, Laurent Pinchart wrote: > From: Paul Elder > > The i.MX8MP Media Block Control (MEDIA BLK_CTRL) is a top-level > peripheral providing access to the NoC and ensuring proper power > sequencing of the peripherals within the MEDIAMIX domain. Add DT > bindings for it. > > There is already a driver for block controls of other SoCs in the i.MX8M > family, so these bindings will expand upon that. > > Signed-off-by: Paul Elder > Reviewed-by: Rob Herring > Reviewed-by: Laurent Pinchart > Signed-off-by: Laurent Pinchart Reviewed-by: Marek Vasut [...] > + power-domain-names = "bus", "mipi-dsi1", "mipi-csi1", "lcdif1", "isi", > + "mipi-csi2", "lcdif2", "isp2", "isp1", "dwe", > + "mipi-dsi2"; Nit, I cannot say I'm a big fan of calling the power domain "mipi-csi1" and "mipi-csi2", they are both MIPI CSI2, except there are two of them CSI2 (#1 and #2). Maybe mipi-csi2-1 and mipi-csi2-2 would be better ? DTTO for the LCDIF, where we have lcdifv3 and then mx8mp lcdifv3 and eventually we will have power domain for lcdif #3 instance in this SoC in hdmimix, so maybe some lcdif-1/lcdif-2 would be a better name ? [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel