From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1650BC43381 for ; Fri, 1 Mar 2019 10:25:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D20682087E for ; Fri, 1 Mar 2019 10:25:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oZ820/+q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="p03DdZ5o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D20682087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=awd22cxNz/43cKQ/VLmd5w3vXBf7/GcHOJ4yU39TVW8=; b=oZ820/+qYTko+n pp0k2jiJHYUBsKZQJl9FjCu9zOl4f4m1EC1MC8AVzAYscpNek21D4Se7yYHbNcqqgv9lsGlWujrku 4C3eRvyGxpPo5O3CTSxXSd72Wi7Xn9RKSjTM7LowmpJdlCGlYlp40RQg0LcZaAYBB4ovl/Tr8VZF3 vUT0ETn2ERoVKy6SBe7T5eSqhHQonpkMXnvjDgjjrzm6vTPE9i/L1u3gqulexwOtRhjfS6iGZy4F1 KUKEvPauF7Gt+5lDaxsiiwWE9V9NSk/jAgU0fNoSoZcfrMempc07XjXxQR3gvVSaE8iDNfKnZ0DKW 0sP7Vw74SVpSXFCGF26A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzfM6-0003tf-62; Fri, 01 Mar 2019 10:25:26 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzfM2-0003sy-49 for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2019 10:25:23 +0000 Received: by mail-wm1-x344.google.com with SMTP id g20so10922075wmh.5 for ; Fri, 01 Mar 2019 02:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yBbXNoqYu9MdmiBMgr7H4sE0/jUYZZJwQjhQHWNmLsQ=; b=p03DdZ5ow6R6pdSOmCSb63GRVD4bUXp2oUCn1RrAvyoKFLwSCmRsvsURVzRBeD83vE BsNAIrEpZvZ+3uLulJYf6ALnwcgjS5MvABFCDAq9hSkoVEr6eQuDofI2G21Lb68GAyxC tFW1nDP/jiy2st9Ax5JHYDfo9F3TENK1KSiZfPbyp7JuBDcqko+VNC1uOFWPcERZKPAH qeW6Yg65WTulL8TY9HbogNjLEUHOvDqm2f99pJGIeiAMqgDVAxWw+i7Do2goPtyzXeuD 8Nqb0JsIK9mco2E9qUa5sUYnRbiWbTh67qzH2LDldkcCPCo7fXll5Cyr+mCB/AM0d5sl KIQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=yBbXNoqYu9MdmiBMgr7H4sE0/jUYZZJwQjhQHWNmLsQ=; b=iwLtFTquKBeHgJbd0KVFwHH8dmdcGZKXLRoLqsdkOFS3R51/rU7Oz+c7PgusTXzWaM 8G1wDiY57hkCyBf6RMLDheXa9hQ0zhozRrckYjvVOnAm5M37H+1o8kpukF6m9DRyI+Iw YVpWdYoOVTlFWKRBe2H85G5oEcdHLk3/Vjgs875sPMzHxw1g9WHMKP+cZzCJR28yErrw /3w8jECsgE27yh8oxqvgqPwCuNhdPoCDugppKp+xPM7Far+11e2Izt3FQIFwk54g93Z3 7ivBsg7TJB2yxQbJ4zV0fQ4V/GKo7KgU+2/GN4SFa/jfa58kh+jPxI7D/NSIxUg2jmnW BwVg== X-Gm-Message-State: APjAAAX5y/daFCUvAL9hA7f1KidOiEOYZXUEKpTHwUrI310YSSSmEdNa jwXRJs5yswNCf1id2jhf+ZMBVQ== X-Google-Smtp-Source: APXvYqwGlkN2dlx9qrXJI2bFW0UdrFVtpdb0k1eu256x04A33jLxHMSd7y+S8N9AOg+xW5eAhlAL7w== X-Received: by 2002:a1c:a941:: with SMTP id s62mr2713576wme.16.1551435920191; Fri, 01 Mar 2019 02:25:20 -0800 (PST) Received: from [10.1.2.12] (lmontsouris-657-1-212-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id p1sm20390373wrx.50.2019.03.01.02.25.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 02:25:19 -0800 (PST) Subject: Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Rob Herring References: <20190212151413.24632-1-narmstrong@baylibre.com> <20190212151413.24632-5-narmstrong@baylibre.com> <20190228162906.GA2387@bogus> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: <402e6364-26f2-b0f3-c7f5-f9b32b076c5c@baylibre.com> Date: Fri, 1 Mar 2019 11:25:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190228162906.GA2387@bogus> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_022522_201455_9595EC59 X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/02/2019 17:29, Rob Herring wrote: > On Tue, Feb 12, 2019 at 04:14:09PM +0100, Neil Armstrong wrote: >> Adds the bindings for the Amlogic G12A USB Glue HW. >> >> The Amlogic G12A SoC Family embeds 2 USB Controllers : >> - a DWC3 IP configured as Host for USB2 and USB3 >> - a DWC2 IP configured as Peripheral USB2 Only >> >> A glue connects these both controllers to 2 USB2 PHYs, >> and optionnally to an USB3+PCIE Combo PHY shared with the PCIE controller. >> >> The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including >> routing of the OTG PHY between the DWC3 and DWC2 controllers, and >> setups the on-chip OTG mode selection for this PHY. >> >> The PHYs are children of the Glue node since the Glue controls the interface >> with the PHY, not the DWC3 controller. >> >> The PHY interconnect is handled into ports subnodes, which eases describing >> which PHY is enabled (like the USB3 shared PHY) and futures layouts on >> derivatives of the G12A Family. >> >> Signed-off-by: Neil Armstrong >> --- >> .../devicetree/bindings/usb/amlogic,dwc3.txt | 109 ++++++++++++++++++ >> 1 file changed, 109 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt >> index 9a8b631904fd..c7c4726ef10d 100644 >> --- a/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/amlogic,dwc3.txt >> @@ -40,3 +40,112 @@ Example device nodes: >> phy-names = "usb2-phy", "usb3-phy"; >> }; >> }; >> + >> +Amlogic Meson G12A DWC3 USB SoC Controller Glue >> + >> +The Amlogic G12A embeds a DWC3 USB IP Core configured for USB2 and USB3 >> +in host-only mode, and a DWC2 IP Core configured for USB2 peripheral mode >> +only. >> + >> +A glue connects the DWC3 core to USB2 PHYs and optionnaly to an USB3 PHY. >> + >> +One of the USB2 PHY can be re-routed in peripheral mode to a DWC2 USB IP. >> + >> +The DWC3 Glue controls the PHY routing and power, an interrupt line is >> +connected to the Glue to serve as OTG ID change detection. >> + >> +Required properties: >> +- compatible: Should be "amlogic,meson-g12a-usb-ctrl" >> +- clocks: a handle for the "USB" clock >> +- clock-names: must be "usb" >> +- resets: a handle for the shared "USB" reset line >> +- reset-names: must be "usb" > > -name for a single entry is pointless. > >> +- reg: The base address and length of the registers >> +- interrupts: the interrupt specifier for the OTG detection >> + >> +Required child nodes: >> + >> +USB Ports are described as child 'port' nodes grouped under a 'ports' node, >> +with #address-cells, #size-cells specified. >> + >> +Each 'port' sub-node identifies a possible USB Port served by an USB PHY >> +identified by the 'phy' property as decribed in ../phy/phy-bindings.txt >> + >> +Each 'port' is identified by a reg property to number the port. >> + >> +The following table lists for each supported model the port number >> +corresponding to each PHY serving a physical USB Port. >> + >> + Family Port 0 Port 1 Port 2 Port 3 Port 4 >> +--------------------------------------------------------------- >> + G12A USBHOST_A USBOTG_B Reserved Reserved USB3_0 >> + >> +A child node must exist to represent the core DWC3 IP block. The name of >> +the node is not important. The content of the node is defined in dwc3.txt. >> + >> +A child node must exist to represent the core DWC2 IP block. The name of >> +the node is not important. The content of the node is defined in dwc2.txt. >> + >> +PHY documentation is provided in the following places: >> +- Documentation/devicetree/bindings/phy/meson-g12a-usb2-phy.txt >> +- Documentation/devicetree/bindings/phy/meson-g12a-usb3-pcie-phy.txt >> + >> + >> +Example device nodes: >> + usb: usb@ffe09000 { >> + compatible = "amlogic,meson-g12a-usb-ctrl"; >> + reg = <0x0 0xffe09000 0x0 0xa0>; >> + interrupts = ; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + clocks = <&clkc CLKID_USB>; >> + clock-names = "usb"; >> + resets = <&reset RESET_USB>; >> + reset-names = "usb"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + /* USB2 Port 0 */ >> + usb20: port@0 { >> + reg = <0>; >> + phys = <&usb2_phy0>; > > 'ports' and 'port' are reserved for the graph binding. Don't use it for > your own thing. > > Can't you just make 'phys' a list using 0 phandle if you need to skip > entries. Yep, finally this would be simpler. > >> + }; >> + >> + /* USB2 Port 1 */ >> + usb21: port@1 { >> + reg = <1>; >> + phys = <&usb2_phy1>; >> + }; >> + >> + /* USB3 Port 0 */ >> + usb3: port@4 { >> + reg = <4>; >> + phys = <&usb3_pcie_phy PHY_TYPE_USB3>; >> + }; >> + }; >> + >> + dwc2: usb@ff400000 { >> + compatible = "amlogic,meson-g12a-usb", "snps,dwc2"; >> + reg = <0x0 0xff400000 0x0 0x40000>; >> + interrupts = ; >> + clocks = <&clkc CLKID_USB1_DDR_BRIDGE>; >> + clock-names = "ddr"; >> + dr_mode = "peripheral"; >> + g-rx-fifo-size = <192>; >> + g-np-tx-fifo-size = <128>; >> + g-tx-fifo-size = <128 128 16 16 16>; >> + }; >> + >> + dwc3: dwc3@ff500000 { > > usb@... or usb3@... Ok > >> + compatible = "snps,dwc3"; >> + reg = <0x0 0xff500000 0x0 0x100000>; >> + interrupts = ; >> + dr_mode = "host"; >> + snps,dis_u2_susphy_quirk; >> + snps,quirk-frame-length-adjustment; >> + }; >> + }; >> -- >> 2.20.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel