From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC22C43387 for ; Sat, 29 Dec 2018 16:51:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ADE72087F for ; Sat, 29 Dec 2018 16:51:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gTc90Eot"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=davidjohnsummers.uk header.i=@davidjohnsummers.uk header.b="KILhWlr1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ADE72087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davidjohnsummers.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=euOp6ZK70yPKJ/jfOMb1oOssbJ9WwLafrQ1k7yQgLFA=; b=gTc90EotFuHgtbIubKpcsLdEr cWHLqeLMEVcQxshlt8gq4l6BGR7f+1qpsy9h5hPaDOpR9CnaTRKIxiEjJkeA06Ed67ywqpTM1Ugw1 kNIQ72bMrzaUOUanvAEBu9WvF4lRZRoj5JyclkcdHn2HcfdCpeJ8lg6e/i2H/taKXAUZFnDXWNFt3 ejBG8M4F/QQvoQM1oZGhGY2Zi/sc0lKHfCJL1Xvl1RuYQmUHNqnV+TpfnnCKORrxX8gdwvoidI9th 0YNskcVgzK441GHGFd8JPuDLd1bCddN6E5MebkndtCwkLCgBJCPC2f3bQ7P6SHQlMG7DEC6bJw5JM lpGO6nFyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdHq1-0003Wx-Fj; Sat, 29 Dec 2018 16:51:49 +0000 Received: from mail-gw.unlimitedwebhosting.co.uk ([149.255.60.88]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdHpy-0003WW-3g for linux-arm-kernel@lists.infradead.org; Sat, 29 Dec 2018 16:51:48 +0000 Received: from uwhbsf01.unlimitedwebhosting.co.uk (mail-gw.unlimitedwebhosting.co.uk [149.255.60.72]) by mail-gw.unlimitedwebhosting.co.uk (Postfix) with ESMTPS id E7D2462C6769 for ; Sat, 29 Dec 2018 16:51:31 +0000 (GMT) X-ASG-Debug-ID: 1546102291-055413120a642cbf0001-tbGyMd Received: from cloud706.unlimitedwebhosting.co.uk (no-dns-yet.unlimited.uk.net [149.255.62.7]) by uwhbsf01.unlimitedwebhosting.co.uk with ESMTP id 4Xk1gUi3wNTA2lXI (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 29 Dec 2018 16:51:31 +0000 (GMT) X-Barracuda-Envelope-From: beagleboard@davidjohnsummers.uk X-Barracuda-Effective-Source-IP: no-dns-yet.unlimited.uk.net[149.255.62.7] X-Barracuda-Apparent-Source-IP: 149.255.62.7 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=davidjohnsummers.uk; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7MXD+ztR+FtTB/RkKDaq2mL5feL/v7vSreZCl8OzH9U=; b=KILhWlr12xv+V30G1egXbKjLie TgOFt0jrUO8WwcYqqFqvNzgbL3O8D75mRnXLFJlyi3pFRlzZt7SI2QZRoigro4RScR7o/Cwv96T6D lhrlV8/nVgqfE7QMr0h1vpnmcQxffkeXX+hOJQCB8izV8BDZMIX5NqQ1l3Tlcl7PKraUGmeMJnG8y DWFnKm+nbKNXR+qyk4j5hp1UIKNkJxVmhLcJJbS4GpBMsi5zgac2nIm9L2oTeaG23OAWph28Kyb4z o8WE7symQTcIQ94VTabkYB5bktIHhzdmb7pInipK5TAc2yV+OpvZ4uSqURs+eAesiqB3UtPSTOTGT dyt0cBkQ==; Received: from [87.112.196.180] (port=35718 helo=[192.168.2.187]) by cloud706.unlimitedwebhosting.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gdHph-003Lfu-TN; Sat, 29 Dec 2018 16:51:30 +0000 Subject: Re: [PATCH] bluetooth: realtek: devicetree: Add device tree description to bluetooth rtl drivers To: Marcel Holtmann X-ASG-Orig-Subj: Re: [PATCH] bluetooth: realtek: devicetree: Add device tree description to bluetooth rtl drivers References: <20181229115513.31153-1-beagleboard@davidjohnsummers.uk> From: David Summers Message-ID: <40484b38-efbb-4a05-23af-c9ec6920c0df@davidjohnsummers.uk> Date: Sat, 29 Dec 2018 16:51:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181229115513.31153-1-beagleboard@davidjohnsummers.uk> Content-Language: en-PH X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud706.unlimitedwebhosting.co.uk X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - davidjohnsummers.uk X-Get-Message-Sender-Via: cloud706.unlimitedwebhosting.co.uk: authenticated_id: davidjoh/from_h X-Authenticated-Sender: cloud706.unlimitedwebhosting.co.uk: beagleboard@davidjohnsummers.uk X-Source: X-Source-Args: X-Source-Dir: X-Barracuda-Connect: no-dns-yet.unlimited.uk.net[149.255.62.7] X-Barracuda-Start-Time: 1546102291 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://149.255.60.72:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at unlimitedwebhosting.co.uk X-Barracuda-Scan-Msg-Size: 2667 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.0 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.64738 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181229_085146_452438_6D69C9D3 X-CRM114-Status: GOOD ( 21.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-bluetooth@vger.kernel.org, robh+dt@kernel.org, Johan Hedberg , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org And just looking at my patch, I remember I wrote this a month or so ago, thought it had been checked - but a couple of changes didn't make it in: 1) "bluetoooth" is spelled "bluetooth" 2) The realtek compatible should be wrapped in a "#ifdef CONFIG_BT_HCIUART_RTL" as hci_h5 needs that to have the realtek links in I'll make these changes in a few days, but leave this patch here - in case there are any other comments. Would hope to get basic nod by next week (yes know bad time for people over Christmas), as its free time I have to do the device tree that needs these in ... Regards, David. On 29/12/2018 11:55, David Summers wrote: > This patch add the relevent device tree handles to the bluetooth driver > for serial realtek devices. > > Specifically it takes all devices listed in btrtk.c identifes from the > realtek web site which are serial devices (this invariably means > devices that end with and "s" in the device name). > > Most of these devices are dual wifi and bluetooth, with wifi on and > sdio connection, and bluetooth on a serial uart. As these two > interfaces will need independent listings in the device tree, the > nodes here have "-bluetooth" added. The only exception is the > rtl8761atv device, which is bluetooth only - and only has a uart > interface. > > Can devicetree people revive the naming scheme used here, and confirm > it is acceptable. > > Marcel, if the device tree people are happy can you apply to the > bluetooth tree. > > Thanks, > > David. > > Signed-off-by: David Summers > --- > drivers/bluetooth/hci_h5.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c > index 8eede1197cd2..61c9e729efc1 100644 > --- a/drivers/bluetooth/hci_h5.c > +++ b/drivers/bluetooth/hci_h5.c > @@ -925,6 +925,20 @@ static struct h5_vnd rtl_vnd = { > }; > #endif > > +#ifdef CONFIG_OF > +static const struct of_device_id h5_of_match[] = { > + { .compatible = "realtek,rtl8723as-bluetoooth"}, > + { .compatible = "realtek,rtl8723bs-bluetoooth"}, > + { .compatible = "realtek,rtl8723ds-bluetoooth"}, > + { .compatible = "realtek,rtl8761atv"}, > + { .compatible = "realtek,rtl8821as-bluetoooth"}, > + { .compatible = "realtek,rtl8821cs-bluetoooth"}, > + { .compatible = "realtek,rtl8822bs-bluetoooth"}, > + { } > +}; > +MODULE_DEVICE_TABLE(of, h5_of_match); > +#endif > + > #ifdef CONFIG_ACPI > static const struct acpi_device_id h5_acpi_match[] = { > #ifdef CONFIG_BT_HCIUART_RTL _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel