From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8550C43461 for ; Fri, 11 Sep 2020 14:45:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 546AC214F1 for ; Fri, 11 Sep 2020 14:45:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uzYnAw2L"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="UJE/6zWt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 546AC214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vqIMgDF/4COJuJiwacUu5/xbFaTmJgkxl8aqAYFR5N4=; b=uzYnAw2LfeyoXw7cgRFzhpZF2 sGweDsgj1MLxoe8+hocl2mugyS+LZ9IAjtSImPG4wHkRyvQ6qv5SYgJH+Zz5ocnC8KmQEMxukB8v6 7O3mAxhFBqrzK43wQ3MF6qXD/iP6XGXBZcoZbviCxKoweDHTCZ4Kn09xOaj5HMQFUR3DB3yjQeoyx 5oKr2Jkq1xs9xja5h4O6kurqNOzEx0BslVKT8FtDSjrRX87tjmB/4epX7V5NejXv4V32fdjh43DGo 1BP8PJWAA180T1+kb9wGc705ZsPn8Z2uV3NU6o4WTweE85I8RlZGZF1DMrWOTiIjhwZRu44sfo9Iq 29zaq3lhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGkHo-0005mS-JD; Fri, 11 Sep 2020 14:44:24 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGkHk-0005lc-Vn; Fri, 11 Sep 2020 14:44:22 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08BEiH8S080691; Fri, 11 Sep 2020 09:44:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599835457; bh=VeiJJJ5bDbdPOe8X83iD+SDZUH01GPEKBkwwWMTRjgc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=UJE/6zWtsV+dKAnUUe1kgx4juYG0EdbHLsIxlqQHR/qXPSPaff8coqPtO9DENjKvM KXBa1Phfd6Bxzs7qBKxWzdfy+oP+0y6GsXXNC9F6nlBk7gsAOEndpke4lriNBhn9v6 AraTG/qSLZARBudKKUIAalacflPPOiQ7+mqZ5TgM= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08BEiH7P001244 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Sep 2020 09:44:17 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 11 Sep 2020 09:44:16 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 11 Sep 2020 09:44:16 -0500 Received: from [10.250.66.146] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08BEiEGY111883; Fri, 11 Sep 2020 09:44:15 -0500 Subject: Re: [v4,3/4] reset-controller: ti: introduce a new reset handler To: Philipp Zabel , Crystal Guo References: <20200817030324.5690-1-crystal.guo@mediatek.com> <20200817030324.5690-4-crystal.guo@mediatek.com> <3a5decee-5f31-e27d-a120-1f835241a87c@ti.com> <1599620279.14806.18.camel@mhfsdcap03> <096362e9-dee8-4e7a-2518-47328068c2fd@ti.com> <1599792140.14806.22.camel@mhfsdcap03> <9d72aaef-49fe-ebb6-215d-05ad3ab27af4@ti.com> <1599804422.14806.27.camel@mhfsdcap03> From: Suman Anna Message-ID: <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> Date: Fri, 11 Sep 2020 09:44:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200911_104421_334334_3FF74B13 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , =?UTF-8?B?WW9uZyBMaWFuZyAo5qKB5YuHKQ==?= , srv_heupstream , =?UTF-8?B?U2VpeWEgV2FuZyAo546L6L+65ZCbKQ==?= , "linux-kernel@vger.kernel.org" , =?UTF-8?B?RmFuIENoZW4gKOmZs+WHoSk=?= , "robh+dt@kernel.org" , "linux-mediatek@lists.infradead.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?WWluZ2pvZSBDaGVuICjpmbPoi7HmtLIp?= , =?UTF-8?B?U3RhbmxleSBDaHUgKOacseWOn+mZnik=?= , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/11/20 9:26 AM, Philipp Zabel wrote: > Hi Crystal, > > On Fri, 2020-09-11 at 14:07 +0800, Crystal Guo wrote: > [...] >> Should I add the SoC-specific data as follows? >> This may also modify the ti original code, is it OK? >> >> + data->reset_data = of_device_get_match_data(&pdev->dev); >> + >> + list = of_get_property(np, data->reset_data->reset_bits, &size); >> >> +static const struct common_reset_data ti_reset_data = { >> + .reset_op_available = false, >> + .reset_bits = "ti, reset-bits", > ^ > That space doesn't belong there. > >> +}; >> + >> +static const struct common_reset_data mediatek_reset_data = { >> + .reset_op_available = true, >> + .reset_bits = "mediatek, reset-bits", >> +}; > > I understand Robs comments as meaning "ti,reset-bits" should have been > called "reset-bits" in the first place, and you shouldn't repeat adding > the vendor prefix, as that is implied by the compatible. So this should > probably be just "reset-bits". Hmm, not sure about that. I think Rob wants the reset data itself to be added in the driver as is being done on some other SoCs (eg: like in reset-qcom-pdc.c). regards Suman > > Otherwise this looks like it should work. > > regards > Philipp > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel