From: Robin Murphy <robin.murphy@arm.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
joro@8bytes.org, will@kernel.org, robh+dt@kernel.org,
heiko@sntech.de, xxm@rock-chips.com
Cc: iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v5 2/4] dt-bindings: iommu: rockchip: Add compatible for v2
Date: Fri, 21 May 2021 12:52:07 +0100 [thread overview]
Message-ID: <40954168-ba5a-d152-2a24-441d5331f4ec@arm.com> (raw)
In-Reply-To: <20210521083637.3221304-3-benjamin.gaignard@collabora.com>
On 2021-05-21 09:36, Benjamin Gaignard wrote:
> Add compatible for the second version of IOMMU hardware block.
> RK356x IOMMU can also be link to a power domain.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/iommu/rockchip,iommu.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> index 099fc2578b54..d2e28a9e3545 100644
> --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml
> @@ -19,7 +19,9 @@ description: |+
>
> properties:
> compatible:
> - const: rockchip,iommu
> + enum:
> + - rockchip,iommu
> + - rockchip,rk3568-iommu
>
> reg:
> items:
> @@ -48,6 +50,9 @@ properties:
> "#iommu-cells":
> const: 0
>
> + power-domains:
> + maxItems: 1
> +
Nit: power domains are already present on various IOMMU nodes since
RK3288 - it feels like strictly this should be in patch #1 to fix the
existing binding as part of the conversion, but on the other hand I
can't really imagine anyone caring *that* much about dtscheck bisecting
cleanly :)
Robin.
> rockchip,disable-mmu-reset:
> $ref: /schemas/types.yaml#/definitions/flag
> description: |
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-21 11:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 8:36 [PATCH v5 0/4] Add IOMMU driver for rk356x Benjamin Gaignard
2021-05-21 8:36 ` [PATCH v5 1/4] dt-bindings: iommu: rockchip: Convert IOMMU to DT schema Benjamin Gaignard
2021-05-21 9:18 ` Heiko Stübner
2021-05-21 8:36 ` [PATCH v5 2/4] dt-bindings: iommu: rockchip: Add compatible for v2 Benjamin Gaignard
2021-05-21 9:18 ` Heiko Stübner
2021-05-21 11:52 ` Robin Murphy [this message]
2021-05-21 8:36 ` [PATCH v5 3/4] iommu: rockchip: Add internal ops to handle variants Benjamin Gaignard
2021-05-21 9:16 ` Heiko Stübner
2021-05-21 12:58 ` Robin Murphy
2021-05-21 13:38 ` Benjamin Gaignard
2021-05-21 14:44 ` Robin Murphy
2021-05-21 8:36 ` [PATCH v5 4/4] iommu: rockchip: Add support for iommu v2 Benjamin Gaignard
2021-05-21 9:17 ` Heiko Stübner
2021-05-21 13:42 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40954168-ba5a-d152-2a24-441d5331f4ec@arm.com \
--to=robin.murphy@arm.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
--cc=xxm@rock-chips.com \
--subject='Re: [PATCH v5 2/4] dt-bindings: iommu: rockchip: Add compatible for v2' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).