From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4D1AC433EF for ; Wed, 29 Jun 2022 08:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YlqsvDcRUaXjv3S8Tfv2rPrObkSOqp5zEI1InAYU+9Y=; b=0fC81Ml+vFSZBP W0XtWvry5WU+iyrVjR5/Q+ywsm4BGxnbbl7m2iweFZjEpfDfHz3KSXP++spbVvk6LN2PzbvQmCD6B +mEonh7cd2IPHhCrlGYC6B9VMdVEcfdcR0dRo0QHQhEpqDzrvx6gKtcbLDQ4znACZy6i7WXk6YaNL 2HExccrkGVC4YAzKMryO8DUptcVekAScJHgWSCMfgLzs+j6yTFaxaZ1EfuN9dXDuZ42jm/os2LODG K3KqA8NBc6zUEp1vJmgrfmduUhRDOxI+BnCXmAEP4AA6Ei8IbN5976iQSKI1NF5knzmDuxuZMu0Je vI7Qhe4OD51xDNRkEDbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Sft-00AHED-Ku; Wed, 29 Jun 2022 08:03:49 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Sfq-00AHC1-Ah for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 08:03:47 +0000 Received: by mail-ej1-x631.google.com with SMTP id ay16so30910191ejb.6 for ; Wed, 29 Jun 2022 01:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cG3vzXy564NxPyQk6j0mH7QQcpmGhb7eglXugVj6hN8=; b=YPK4Y9MtYTlB+9uxDmydPXAD+nm40vRi5kfqNUZQCbI9XYMlU0HSOwbzR6G6bfbW4r F0Zn6240auG9wDCOE9n576wvCFBDgppCXYG/GGdNxBsOj22QcVc7t6BadRxqNBFanvmZ Hj53k762IYyi8RlPckGPXe0GiV3fZlE/f5hgZxLs3SHfwPyJi4N+lVi1HN+S2PINJ23v kp9yJ05aEzIO7rA8z5nrXEOU7q1BAXOszAd9SqDfvt6GNNB+XktIVwUkJTC5bAKL1kpy ZhhY/RXn66UpmjVKgVL/s3pDCyWB5ZJw9FC7ZT4el0lubErnU7RHGWnvC/2zexKIC71j ZQoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cG3vzXy564NxPyQk6j0mH7QQcpmGhb7eglXugVj6hN8=; b=O5goZWJIQ/e4L14wM6zJbVmgc3JF6MJALXG5rCstlueJYdP+c2d03jVYNkEUu94o6p y6mFm8NWOWrOlmA0ClOV6WP8l+xvY6OI2PM6EQ7qnyrvvCEAs1ohGp0JBPquK1B27XdB qXBsPLQQ1sQ0mZkAL/A0lDVplQ81jSxQ0D8KpQnn54w8OirpO/yd3IF89PMTAoi0W0i4 pANBgIRgY5Uka0MFtv5gwA1C6t/n0dngSZuukrw+q5wLNFdfXFC3nx/X0H3C71rxCeZk i5Q0Aqjm1cdEtjMpZNBguACNfFzj7GUSv4l9/ybwJz6egyZf14z4b5sqXL9CglG0iiRE QXAg== X-Gm-Message-State: AJIora8RcZx+sIhH3DLtvXp6aZk7EDOy05lixL1lBYpj/X64jzJaHhqo /3whWtrBS/px1w9+9ZnHQdbz+Q== X-Google-Smtp-Source: AGRyM1vMLNNjC9XXtRvbH3wYlHBLBB1LEnGfbV9c7vENLF2zfPQTUdrjciEn2ZM1kvAcRAd4swllrQ== X-Received: by 2002:a17:907:168f:b0:726:2bd0:1091 with SMTP id hc15-20020a170907168f00b007262bd01091mr2003312ejc.137.1656489821764; Wed, 29 Jun 2022 01:03:41 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g20-20020a50d5d4000000b0042617ba63c2sm10991337edj.76.2022.06.29.01.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 01:03:40 -0700 (PDT) Message-ID: <409af908-5e03-8df7-fcd5-7fab75cdfb34@linaro.org> Date: Wed, 29 Jun 2022 10:03:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE reset definition Content-Language: en-US To: Neal Liu , Corentin Labbe , Christophe JAILLET , Randy Dunlap , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Dhananjay Phadke , Johnny Huang Cc: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BMC-SW References: <20220629032008.1579899-1-neal_liu@aspeedtech.com> <20220629032008.1579899-3-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_010346_462541_DD81DDAB X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/06/2022 09:59, Neal Liu wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Wednesday, June 29, 2022 1:58 PM >> To: Neal Liu ; Corentin Labbe >> ; Christophe JAILLET >> ; Randy Dunlap ; >> Herbert Xu ; David S . Miller >> ; Rob Herring ; Krzysztof >> Kozlowski ; Joel Stanley ; >> Andrew Jeffery ; Dhananjay Phadke >> ; Johnny Huang >> >> Cc: linux-aspeed@lists.ozlabs.org; linux-crypto@vger.kernel.org; >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; BMC-SW >> Subject: Re: [PATCH v5 2/5] dt-bindings: clock: Add AST2500/AST2600 HACE >> reset definition >> >> On 29/06/2022 05:20, Neal Liu wrote: >>> Add HACE reset bit definition for AST2500/AST2600. >>> >>> Signed-off-by: Neal Liu >>> Signed-off-by: Johnny Huang >>> Acked-by: Krzysztof Kozlowski >>> --- >>> include/dt-bindings/clock/aspeed-clock.h | 3 ++- >>> include/dt-bindings/clock/ast2600-clock.h | 1 + >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/dt-bindings/clock/aspeed-clock.h >>> b/include/dt-bindings/clock/aspeed-clock.h >>> index 9ff4f6e4558c..6e040f7c3426 100644 >>> --- a/include/dt-bindings/clock/aspeed-clock.h >>> +++ b/include/dt-bindings/clock/aspeed-clock.h >>> @@ -46,11 +46,12 @@ >>> #define ASPEED_RESET_MCTP 1 >>> #define ASPEED_RESET_ADC 2 >>> #define ASPEED_RESET_JTAG_MASTER 3 >>> -#define ASPEED_RESET_MIC 4 >>> +#define ASPEED_RESET_HACE 4 >> >> I did not ack such change. This is a significant change from previous version, >> invalidating my previous ack. >> >> This breaks the ABI, so NAK without proper explanation why ABI break is >> accepted. > > I changed the original define (MIC) into different value (see below diff), and add a new define for HACE. > How does that break the ABI? I'll be appreciated if you can explain it more details. > And sorry for not remove ack with new change. Yes, this breaks ABI. Previously the ASPEED_RESET_MIC define had value of 4, now it has value of something else. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel