From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6036C4724C for ; Fri, 1 May 2020 15:26:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A056D206D9 for ; Fri, 1 May 2020 15:26:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tSD5KK8U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A056D206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f5T5vtYKL62+dKHirtETanzT+9RmNDk3HpiA4RhV9Yc=; b=tSD5KK8UQcf/iq5R3JoViHBfS +bK99sakk7q1DoJWsYL1Xyok3n1xKXfcb4JYDcjP7MkHxXd666nyGKucCMKa74p0hd02m0UdgQcSQ 2Aj3yzZpa6LLTNd3A0tziMKnv4J7FTMQ1RDNfGLa1hmdiJ2SCMp0W7Lo7PvrY5YtCkg/QpxcMr/Z3 tHc4BqhiHzlvYIzzQyrn1gZYnoMPSUfKNqcsJgalVJ/lgAkg0WnP7RL5tR8YCOqKq6BnXd8c7ZM3v DhyyvjEUMMVwLGTZnkvntXaFU4tJeZz0m6jxrTMwe3xxpZy9DhAa1stLcYRI3wwoRZ6IV0aWfIvxv mmBfs1mmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUXYh-0006tB-6P; Fri, 01 May 2020 15:26:35 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUXYc-0006bQ-I9 for linux-arm-kernel@lists.infradead.org; Fri, 01 May 2020 15:26:32 +0000 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 0D367C3A7F7E74A2CE70; Fri, 1 May 2020 16:26:11 +0100 (IST) Received: from [127.0.0.1] (10.47.3.165) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 1 May 2020 16:26:10 +0100 Subject: Re: [PATCH 5/5] arm/arm64: smccc: Add ARCH_SOC_ID support To: Sudeep Holla , "linux-arm-kernel@lists.infradead.org" References: <20200430114814.14116-1-sudeep.holla@arm.com> <20200430114814.14116-6-sudeep.holla@arm.com> From: John Garry Message-ID: <426ff8ab-9c13-4301-a91e-989c19c4ff58@huawei.com> Date: Fri, 1 May 2020 16:25:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200430114814.14116-6-sudeep.holla@arm.com> Content-Language: en-US X-Originating-IP: [10.47.3.165] X-ClientProxiedBy: lhreml727-chm.china.huawei.com (10.201.108.78) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200501_082630_767826_766FA17B X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , Catalin Marinas , "linux-kernel@vger.kernel.org" , Steven Price , "harb@amperecomputing.com" , Will Deacon Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/04/2020 12:48, Sudeep Holla wrote: > +static int __init smccc_soc_init(void) > +{ > + struct device *dev; > + int ret, soc_id_rev; > + struct arm_smccc_res res; > + static char soc_id_str[8], soc_id_rev_str[12]; > + > + if (arm_smccc_get_version() < ARM_SMCCC_VERSION_1_2) > + return 0; > + > + ret = smccc_soc_id_support_check(); > + if (ret) > + return ret; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_ARCH_SOC_ID, 0, &res); > + > + ret = smccc_map_error_codes(res.a0); > + if (ret) > + return ret; > + > + soc_id_version = res.a0; > + > + arm_smccc_1_1_invoke(ARM_SMCCC_ARCH_SOC_ID, 1, &res); > + > + ret = smccc_map_error_codes(res.a0); > + if (ret) > + return ret; > + > + soc_id_rev = res.a0; > + > + soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); > + if (!soc_dev_attr) > + return -ENOMEM; > + > + sprintf(soc_id_str, "0x%04x", IMP_DEF_SOC_ID(soc_id_version)); > + sprintf(soc_id_rev_str, "0x%08x", soc_id_rev); > + > + soc_dev_attr->soc_id = soc_id_str; > + soc_dev_attr->revision = soc_id_rev_str; > + > + soc_dev = soc_device_register(soc_dev_attr); > + if (IS_ERR(soc_dev)) { > + ret = PTR_ERR(soc_dev); > + goto free_soc; > + } > + > + dev = soc_device_to_device(soc_dev); > + Just wondering, what about if the platform already had a SoC driver - now it could have another one, such that we may have multiple sysfs soc devices, right? Thanks, John > + ret = devm_device_add_groups(dev, jep106_id_groups); > + if (ret) { > + dev_err(dev, "sysfs create failed: %d\n", ret); > + goto unregister_soc; > + } > + > + pr_info("SMCCC SoC ID: %s Revision %s\n", soc_dev_attr->soc_id, > + soc_dev_attr->revision); > + > + return 0; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel