From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 706DCECAAD3 for ; Fri, 9 Sep 2022 08:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/Z3W2wdrUvm9QEIO9Uazd/U5LT2kJVn1U74WlGgHHv0=; b=iiOLgUSIlPh75mGXVOD9HmXbt/ RKiabzCVpstW/ej9VJh96xE5gIGeWCpdgmj/bZXaz2axuAPSoeJI5/igRGsp2sdxPBgVdzwK7zMqq +ig5pWcdbim1mZDiQadNNwlcCArN6VnLyH/2SDG9cNEcVEXPWSktLyKXfxmGEjyI70HcYhoB5YMeJ mVAh3jZ5TJMbaM68mJb1TULbMtLQKukIrz5+7ip6wbOjnnW4AC+BjMnRTSsDvyolMOeYlWKSCb+eO 2Ogc1N942RNdYOZMTnE6NBymanOEEz9PY8UM3hkP+GoYa1s92MEwiKX63y3J6EuC3V1VOcMamRUFO oXvLXpoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWZpx-00EpFA-TU; Fri, 09 Sep 2022 08:58:10 +0000 Received: from 0001.3ffe.de ([159.69.201.130] helo=mail.3ffe.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWZps-00EpCM-BI; Fri, 09 Sep 2022 08:58:06 +0000 Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 1E34721F3; Fri, 9 Sep 2022 10:58:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1662713882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OKWpGy9Sm/h+vL8rknv+UFCIpuNP8hHTtInxhBqUUDg=; b=1q0wZefGZU+a4bo3O0XKv6aSKfvwAMAjX9kZILz6cFvd4hJc7n+RCZAqPbbJWnWs2NG9Ej XTKxJ5WMmUyE+Jf8aY30uRm4NMKCbE1Xr1RoiPmX23porTbAu35EWL/RGX+RjPMVu0CXR6 s1l5XzVG6ytQ2dL3uB/L1QdwhTy7VXdS35mBIdH+eIdB62mbXYjITgDZSGY5Loanzmi0vM yiAOdWIIvKZqoHUfw5imLbdL92IbqSj6VznRJ8FU/rfP7o+UkMeGWusj+mf2TcBL9OgNiz kcsFcOTibFGsYngS5wygKrK9aqqO+wbqskG/E77XNAvy4JDWQaoYg9+Ep2fY3g== MIME-Version: 1.0 Date: Fri, 09 Sep 2022 10:58:01 +0200 From: Michael Walle To: Srinivas Kandagatla Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Li Yang , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Frank Rowand , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ahmad Fatoum , Philipp Zabel Subject: Re: [PATCH v2 13/20] nvmem: core: drop priv pointer in post process callback In-Reply-To: <373b10aa-f5c8-28b3-88b0-f87a1a40b000@linaro.org> References: <20220901221857.2600340-1-michael@walle.cc> <20220901221857.2600340-14-michael@walle.cc> <373b10aa-f5c8-28b3-88b0-f87a1a40b000@linaro.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <42bc3f6796cc75baafc15c6d2c71ec92@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220909_015804_593616_16D28643 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 2022-09-09 10:52, schrieb Srinivas Kandagatla: > On 01/09/2022 23:18, Michael Walle wrote: >> It doesn't make any more sense to have a opaque pointer set up by the >> nvmem device. Usually, the layout isn't associated with a particular >> nvmem device. >> > This is really not a good idea to remove the context pointer, as this > is the only way for callback to get context which it can make use of. In which case? As I mentioned it's the priv to the nvmem driver and all the "normal" callbacks can do very little with it. If there will be a future need, then there should be a proper opaque pointer associated with the layout and not the nvmem driver. -michael > I would prefer this to be left as it is. > > --srini > >> Signed-off-by: Michael Walle >> --- >> changes since v1: >> - new patch >> >> drivers/nvmem/core.c | 4 ++-- >> drivers/nvmem/imx-ocotp.c | 4 ++-- >> include/linux/nvmem-provider.h | 5 +++-- >> 3 files changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c >> index d31d3f0ab517..6910796937f9 100644 >> --- a/drivers/nvmem/core.c >> +++ b/drivers/nvmem/core.c >> @@ -1523,8 +1523,8 @@ static int __nvmem_cell_read(struct nvmem_device >> *nvmem, >> nvmem_shift_read_buffer_in_place(cell, buf); >> if (cell->read_post_process) { >> - rc = cell->read_post_process(nvmem->priv, id, index, >> - cell->offset, buf, cell->bytes); >> + rc = cell->read_post_process(id, index, cell->offset, buf, >> + cell->bytes); >> if (rc) >> return rc; >> } >> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c >> index ac0edb6398f1..5e869d4a81c5 100644 >> --- a/drivers/nvmem/imx-ocotp.c >> +++ b/drivers/nvmem/imx-ocotp.c >> @@ -222,8 +222,8 @@ static int imx_ocotp_read(void *context, unsigned >> int offset, >> return ret; >> } >> -static int imx_ocotp_cell_pp(void *context, const char *id, int >> index, >> - unsigned int offset, void *data, size_t bytes) >> +static int imx_ocotp_cell_pp(const char *id, int index, unsigned int >> offset, >> + void *data, size_t bytes) >> { >> u8 *buf = data; >> int i; >> diff --git a/include/linux/nvmem-provider.h >> b/include/linux/nvmem-provider.h >> index 9d22dc5a3fa5..46067a6a0395 100644 >> --- a/include/linux/nvmem-provider.h >> +++ b/include/linux/nvmem-provider.h >> @@ -19,8 +19,9 @@ typedef int (*nvmem_reg_read_t)(void *priv, unsigned >> int offset, >> typedef int (*nvmem_reg_write_t)(void *priv, unsigned int offset, >> void *val, size_t bytes); >> /* used for vendor specific post processing of cell data */ >> -typedef int (*nvmem_cell_post_process_t)(void *priv, const char *id, >> int index, >> - unsigned int offset, void *buf, size_t bytes); >> +typedef int (*nvmem_cell_post_process_t)(const char *id, int index, >> + unsigned int offset, void *buf, >> + size_t bytes); >> enum nvmem_type { >> NVMEM_TYPE_UNKNOWN = 0, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel