From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9112BC32771 for ; Fri, 19 Aug 2022 12:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F4Do+Qgn0Vd7BoOBphDYlCZoITY6cTfrEpuKJmENRkw=; b=4nuF4c74PJlqMa trQJd7VK1a7oRp3d/zkRiKm37g+nV+qdMAAHZYrPvlugPH5U91DaPeu2SaZxO9lyZ7OWnXBCGZpL3 197BAgVw/lUsAAVVXJhNE2H6D/flaBzhh6JPRtTU8p5j+tZUyMFo+GTk9bb8ulsv/kzyZ063LKWUM g/wMs2KH/7QoJQBDCfSjCY4w+JnFuSYhnpmSztVUeqz4LsF0jVWxtk50xGCXDaWFixn6yXkFMU5kB NXPcW7yf4N25Q48Du6gFgjJzU/7Zp/YVdbvBAS9iTRbwrIMgggtVo+fs6dxYowIEnBHvlLo2GSftZ 4a5RopfIE+/Q0aw8rFNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP0v0-007eDn-Lf; Fri, 19 Aug 2022 12:16:06 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP0ux-007e7K-9S for linux-arm-kernel@lists.infradead.org; Fri, 19 Aug 2022 12:16:04 +0000 Received: by mail-lf1-x12e.google.com with SMTP id m3so227931lfg.10 for ; Fri, 19 Aug 2022 05:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=iRQAht+syD+WoClHi+abQcpzAmB47QGZmxwK52W8goQ=; b=gAnalwOyubLu6+wLXJWbeHG2l/u2fmMgVQ9Vpx1zAjL7bFzAM5ZzxJQcJDTeot4yn+ i1AJkCiTdquYltpTVt2ufhmroC5Uj/FxxUY6TdC9cKeyHf3f/ViVjSeGky44Bm+U7x03 7UcAcO4Ol3ry4gVYmwiLyIvga5mk111OYk+z1mTQjAUBS8QbknoRSmXCcSeqxp3J4BAM lGS55fHy2ePWP/sOp3TCd1gTP+zRBRsgcPLcehqXQBBqRL8CghXkoR/xGnXewBmiDEEG oqeNqSFRTsqamvLgd0nUvdFvmZ0A8GCy2DBVQx14FWpRe3kQcv0YPrMQacMchQJe6X1b 96MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=iRQAht+syD+WoClHi+abQcpzAmB47QGZmxwK52W8goQ=; b=iS7z35UKBigdB7KGC2Kq9RJiESClVPWLW2BdguyG+zX4fWe9qUZs04FKE+6jAJjmIA Fa+GbaoGBesxLQhm5UH41sCaqu3OSf2jd8rPGJSGy+yeYGjRCo2Hr/I534X7Xv5HsGkQ 3qKEAFguKyDLAumQg+oKArA22v0tkaa4MtFS3obwdpmf3ux05KAOmZIqEYDNItOBSIfB CJdDKmggatHsMXK0VuQXSG/W2szfN872b9sIB45dL7BC9zzfxLfbv8qARLvxaqRevJLU 8Kp5egp4oveo8JEVY7EV8PyynljEzOBVl16EZr5ejDFEAPjMZ04er1w6cwWLPyMhvT+w /D3A== X-Gm-Message-State: ACgBeo2f+kW0FUE+kpVQX+yQUd4IM82aDZ3MHd+K9ud52Uf6lpwIHIdj o+b2X2Bbi4PG+H2e5ygj7RTcpw== X-Google-Smtp-Source: AA6agR6ZzDgldit3bbnQaHeffN9D/ccyNG3aT6Z0pYd8NszNFSXmXT7adl+3BQtJYB1uFOadxcnBlQ== X-Received: by 2002:ac2:5e75:0:b0:492:c50a:3a89 with SMTP id a21-20020ac25e75000000b00492c50a3a89mr1449763lfr.68.1660911360346; Fri, 19 Aug 2022 05:16:00 -0700 (PDT) Received: from ?IPV6:2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5? (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id t14-20020a2e8e6e000000b00261af4754bbsm594964ljk.41.2022.08.19.05.15.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 05:15:59 -0700 (PDT) Message-ID: <438da392-f419-ad76-7e91-aa4aab36e12c@linaro.org> Date: Fri, 19 Aug 2022 15:15:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis Content-Language: en-US To: Chunfeng Yun , Vinod Koul , Rob Herring Cc: Kishon Vijay Abraham I , Krzysztof Kozlowski , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Eddie Hung References: <20220819091344.2274-1-chunfeng.yun@mediatek.com> <20220819091344.2274-2-chunfeng.yun@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220819091344.2274-2-chunfeng.yun@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220819_051603_388634_012693DF X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/08/2022 12:13, Chunfeng Yun wrote: > Add a property to set usb2 phy's pre-emphasis. > > Signed-off-by: Chunfeng Yun > --- > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > index 848edfb1f677..aee2f3027371 100644 > --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > @@ -219,6 +219,13 @@ patternProperties: > minimum: 1 > maximum: 15 > > + mediatek,pre-emphasis: > + description: > + The selection of pre-emphasis (U2 phy) > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 3 Instead of hard-coding register values in bindings, you should rather describe here feature/effect. If it is in units, use unit suffixes. If it is some choice, usually string enum is appropriate. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel