From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C16C4338F for ; Fri, 30 Jul 2021 14:31:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C494260E93 for ; Fri, 30 Jul 2021 14:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C494260E93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gQImCVACEc3IisI5ynu/q9s5qYGywi70f0WqaVfHs/4=; b=2hIytMNAP9ervwadGGL4DQyT5H vemrQJ//lCzE/ZbJywPsuCcqJjDYDCQ/u4VduxIbJVE3L9GRweflnNNHCSqL2GybcjgkrqZJibYqD gSoQ6boOqn+LAnHKK32AG2FVvT41T1gff0bjjknFNGwsI/n/RiF0Y/LJppVVutDSaEvigKKU1luye 6/MJjcAmeCDdGjb43hab37USpvn7LvvH+CnPoudzLdPTbl7ZNYbKAPiLhA5wH6uIdSWV3oNLVADcq NHz1P06inPRBRo+p2HESae+195xIn3f98TCxZN8DOGsuOEPYtUq+0Ca5PMe44eM7bl61QOw6C6BMP gRKA1XJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9TVn-008xpS-61; Fri, 30 Jul 2021 14:29:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9TVj-008xoh-NS for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 14:29:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D31BD6D; Fri, 30 Jul 2021 07:29:08 -0700 (PDT) Received: from [10.57.86.111] (unknown [10.57.86.111]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F48C3F70D; Fri, 30 Jul 2021 07:29:06 -0700 (PDT) Subject: Re: [PATCH 05/10] coresight: trbe: Allow driver to choose a different alignment To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, maz@kernel.org, mark.rutland@arm.com References: <20210728135217.591173-1-suzuki.poulose@arm.com> <20210728135217.591173-6-suzuki.poulose@arm.com> <646d73c5-0015-d296-2ac8-63f8bd5a4dc0@arm.com> From: Suzuki K Poulose Message-ID: <43d802e7-d321-6386-19ee-d3bd8e0c1bbb@arm.com> Date: Fri, 30 Jul 2021 15:29:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <646d73c5-0015-d296-2ac8-63f8bd5a4dc0@arm.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_072915_915539_2F25D117 X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2021 12:02, Anshuman Khandual wrote: > > > On 7/28/21 7:22 PM, Suzuki K Poulose wrote: >> The TRBE hardware mandates a minimum alignment for the TRBPTR_EL1, >> advertised via the TRBIDR_EL1. This is used by the driver to >> align the buffer write head. This patch allows the driver to >> choose a different alignment from that of the hardware, by >> decoupling the alignment tracking. This will be useful for >> working around errata. >> >> Cc: Mathieu Poirier >> Cc: Anshuman Khandual >> Cc: Mike Leach >> Cc: Leo Yan >> Signed-off-by: Suzuki K Poulose >> --- >> drivers/hwtracing/coresight/coresight-trbe.c | 12 ++++++++---- >> 1 file changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c >> index 9735d514c5e1..9ea28813182b 100644 >> --- a/drivers/hwtracing/coresight/coresight-trbe.c >> +++ b/drivers/hwtracing/coresight/coresight-trbe.c >> @@ -92,7 +92,8 @@ static unsigned long trbe_errata_cpucaps[TRBE_ERRATA_MAX] = { >> /* >> * struct trbe_cpudata: TRBE instance specific data >> * @trbe_flag - TRBE dirty/access flag support >> - * @tbre_align - Actual TRBE alignment required for TRBPTR_EL1. >> + * @trbe_hw_align - Actual TRBE alignment required for TRBPTR_EL1. >> + * @trbe_align - Software alignment used for the TRBPTR_EL1, >> * @cpu - CPU this TRBE belongs to. >> * @mode - Mode of current operation. (perf/disabled) >> * @drvdata - TRBE specific drvdata >> @@ -100,6 +101,7 @@ static unsigned long trbe_errata_cpucaps[TRBE_ERRATA_MAX] = { >> */ >> struct trbe_cpudata { >> bool trbe_flag; >> + u64 trbe_hw_align; >> u64 trbe_align; >> int cpu; >> enum cs_mode mode; >> @@ -906,7 +908,7 @@ static ssize_t align_show(struct device *dev, struct device_attribute *attr, cha >> { >> struct trbe_cpudata *cpudata = dev_get_drvdata(dev); >> >> - return sprintf(buf, "%llx\n", cpudata->trbe_align); >> + return sprintf(buf, "%llx\n", cpudata->trbe_hw_align); >> } >> static DEVICE_ATTR_RO(align); >> >> @@ -995,11 +997,13 @@ static void arm_trbe_probe_cpu(void *info) >> } >> >> trbe_check_errata(cpudata); >> - cpudata->trbe_align = 1ULL << get_trbe_address_align(trbidr); >> - if (cpudata->trbe_align > SZ_2K) { >> + >> + cpudata->trbe_hw_align = 1ULL << get_trbe_address_align(trbidr); >> + if (cpudata->trbe_hw_align > SZ_2K) { >> pr_err("Unsupported alignment on cpu %d\n", cpu); >> goto cpu_clear; >> } >> + cpudata->trbe_align = cpudata->trbe_hw_align; > > When it changes, it must be asserted that trbe_align would be a multiple > of trbe_hw_align before existing from arm_trbe_probe_cpu(). We only set it to PAGE_SIZE, which is one of 4K, 16K, 64K all of which are aligned to 2K or any of the smaller alignment supported by TRBE. > >> cpudata->trbe_flag = get_trbe_flag_update(trbidr); >> cpudata->cpu = cpu; >> cpudata->drvdata = drvdata; >> > > Reviewed-by: Anshuman Khandual > Thanks Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel